From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 266C1A0524; Thu, 2 Jul 2020 11:16:56 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A6ED41D609; Thu, 2 Jul 2020 11:16:55 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id EC9F81D5E4; Thu, 2 Jul 2020 11:16:53 +0200 (CEST) IronPort-SDR: Avd8AVi9Uie9nqTD4xduVfViETUIlNrzlnhQ87n04sMXNR2fgpWXx1RnGMUyt2WSUufhn8ZFo7 NxmWNMF9iXww== X-IronPort-AV: E=McAfee;i="6000,8403,9669"; a="211879022" X-IronPort-AV: E=Sophos;i="5.75,303,1589266800"; d="scan'208";a="211879022" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2020 02:16:52 -0700 IronPort-SDR: arOBEA6vBD5qMgQVEZfHQ0v8KY3mY2vfjaO1wJtuk+7OmMOwQ/PxUt6Qeq7I0ropWCXw0Vb3JT kZHUr98DlBNg== X-IronPort-AV: E=Sophos;i="5.75,303,1589266800"; d="scan'208";a="455456976" Received: from unknown (HELO bricha3-MOBL.ger.corp.intel.com) ([10.252.18.120]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 02 Jul 2020 02:16:51 -0700 Date: Thu, 2 Jul 2020 10:16:48 +0100 From: Bruce Richardson To: Timothy Redaelli Cc: dev@dpdk.org, harry.van.haaren@intel.com, stable@dpdk.org Message-ID: <20200702091648.GA611@bricha3-MOBL.ger.corp.intel.com> References: <18f843ba879918cf02416f428bb810e7ea8cde10.1593623742.git.tredaelli@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <18f843ba879918cf02416f428bb810e7ea8cde10.1593623742.git.tredaelli@redhat.com> Subject: Re: [dpdk-dev] [PATCH] app/test: fix rpath for drivers in meson build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jul 01, 2020 at 07:16:38PM +0200, Timothy Redaelli wrote: > This commit fixes the setting of relative rpath on dpdk-test for > drivers ($libdir/dpdk/pmd-$abiver) to the correct absolute rpath > ($prefix$libdir/dpdk/pmd-$abiver) > > Fixes: b5dc795a8a55 ("test: build app with meson as dpdk-test") > Cc: harry.van.haaren@intel.com > Cc: stable@dpdk.org > Signed-off-by: Timothy Redaelli > --- > app/test/meson.build | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > I'm not sure I agree with this change. It's better to have a relative rather than absolute rpath, I think. What problems is it causing to have a relative vs absolute rpath?