From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4FE86A00C5; Thu, 2 Jul 2020 12:42:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 27B3A1D8EB; Thu, 2 Jul 2020 12:42:14 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 94C4C1D73D for ; Thu, 2 Jul 2020 12:42:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593686531; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iM5jpBOYGsuee6I0a2P3l8yVYJiw42ZXuFrWcgmUCy8=; b=iEotd3OR1Cf5f3VjLgiiotHbMO+UzScbQi6za78g0aFieKsOxo3PuYtxNWdT6m28XD60bx N1JlvMj0HARsQZhe1mPpjj7FNca8tfOyd/2/2PxLyqP1kFLivbUzdZ8CCU/AV7giGuHgKG TDu+YyRn0INJ2ZHKnKYsj5Z55JjCkmE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-85-lmMw0QX4MaKG9Tl90EaCWA-1; Thu, 02 Jul 2020 06:42:09 -0400 X-MC-Unique: lmMw0QX4MaKG9Tl90EaCWA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BE23A19057A0; Thu, 2 Jul 2020 10:42:08 +0000 (UTC) Received: from aldebaran (ovpn-112-140.phx2.redhat.com [10.3.112.140]) by smtp.corp.redhat.com (Postfix) with ESMTP id AA9B41A921; Thu, 2 Jul 2020 10:42:07 +0000 (UTC) Date: Thu, 2 Jul 2020 12:42:06 +0200 From: Timothy Redaelli To: Bruce Richardson Cc: dev@dpdk.org, harry.van.haaren@intel.com, stable@dpdk.org Message-ID: <20200702124206.76a2cbc2@aldebaran> In-Reply-To: <20200702091648.GA611@bricha3-MOBL.ger.corp.intel.com> References: <18f843ba879918cf02416f428bb810e7ea8cde10.1593623742.git.tredaelli@redhat.com> <20200702091648.GA611@bricha3-MOBL.ger.corp.intel.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=tredaelli@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] app/test: fix rpath for drivers in meson build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 2 Jul 2020 10:16:48 +0100 Bruce Richardson wrote: > On Wed, Jul 01, 2020 at 07:16:38PM +0200, Timothy Redaelli wrote: > > This commit fixes the setting of relative rpath on dpdk-test for > > drivers ($libdir/dpdk/pmd-$abiver) to the correct absolute rpath > > ($prefix$libdir/dpdk/pmd-$abiver) > > > > Fixes: b5dc795a8a55 ("test: build app with meson as dpdk-test") > > Cc: harry.van.haaren@intel.com > > Cc: stable@dpdk.org > > Signed-off-by: Timothy Redaelli > > --- > > app/test/meson.build | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > I'm not sure I agree with this change. It's better to have a relative > rather than absolute rpath, I think. What problems is it causing to have a > relative vs absolute rpath? > I only backported the same fix done in app/meson.build since, currently, app/test/meson.build adds a rpath to "lib64/dpdk/pmd-20.0" that doesn't exists since, in this case, it should be "../lib64/dpdk/pmd-20.0" on Fedora, or "../lib/x86_64-linux-gnu/dpdk/pmds-20.0" on Debian. If we want relative paths we should change "install_rpath:" line on app/meson.build too. Debian workarounded that bug by stripping rpaths from dpdk-test [1], but I'd like to avoid doing that on Fedora/RHEL too, when we'll migrate to meson, since currently check-rpaths (invoked by rpmbuild) is complaining about the invalid rpath: ERROR 0002: file '/usr/bin/dpdk-test' contains an invalid rpath 'lib64/dpdk/pmds-20.0' in [lib64/dpdk/pmds-20.0] [1] https://salsa.debian.org/debian/dpdk/-/blob/unstable/debian/rules#L175