From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 46CEBA0519; Fri, 3 Jul 2020 11:13:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 091201DABB; Fri, 3 Jul 2020 11:13:25 +0200 (CEST) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00056.outbound.protection.outlook.com [40.107.0.56]) by dpdk.org (Postfix) with ESMTP id 0B7801DAB8 for ; Fri, 3 Jul 2020 11:13:24 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YVTPaxhkpCS2PA/P612JYZ31mXpoSpiXL7tJqs46SDxRm5+lIzMCAfTvbX6gSY6WeC88rwhH2ec+PNXIEULQGrqiLQlnMhqX/Z/Bz96FLqs1wvyYiixFyotfHb4Z4uOSqL82EQExVg5IOy6x3FDl5amKygZCgoVU+adBdaYgzIqcc1MYLz4in0kP2wrrXsRYKv0Bpc5qhfZ2N2Itq6IOW0Jg0in/kH3dWaSqpYNt2zhAncmG6qbxmriMazSfZfc64H1Sd7PHRfQ58c9hJUSKxkCpFCDfYhbG5BkapHVQydEm8x934mGQR0+m6Xy8Vb8GQmvTBS35+rqlAjoLeesdoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RpWOBd3pblhqrkJ0OEo5WAC0kGA/NL4QMCyIMNN5gO8=; b=iT+xokGAthacoD/Fl0mznGlTeaTAXl+ALLUUl0GbZHlbqkeJvFY4j9L5Cx6NZcXBeGE7OH1rUqZQ0vJVk4wo83EQarg5NTwY9FAUX4pswMr7UexwLQiuXwnp92heSv6PkoFW4CSvOqlbGO17E6S+GzF8vPvJGkGwBt9f2HvM+8FzrPj2zGK/eCLCpm7UiHBNXG4uvDFH/5JKW05nRYJPWpdzmpHRBxOpQWiQD9oNDeGE4FeFUDV8iKkX6ONTf5FGchUcWnW0YlZAKvARpgCE6aT15gM+NmtzS6nl9dE7Urwcj5VbmqbBWfL//wtANKIgOmh54bDUCPwpB5zo5whFww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RpWOBd3pblhqrkJ0OEo5WAC0kGA/NL4QMCyIMNN5gO8=; b=L8UZFpxxPWLNxZyC6j9r++zoY+/3bZtxgfditC3YGiCPHlGrKGSy1TVndqotDeFdBJPQXiS2FoPQ65SUzrHquY9ZoJYF4Sda75d/C/szI5g8UGGeZ88D2paCPgla0UE4E8M9D3R1X5Lvg0W1iWx8DOlvFAgsso6urWmbH4xZ9dI= Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=mellanox.com; Received: from AM0PR05MB4866.eurprd05.prod.outlook.com (2603:10a6:208:c0::32) by AM0PR05MB4353.eurprd05.prod.outlook.com (2603:10a6:208:67::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.24; Fri, 3 Jul 2020 09:13:23 +0000 Received: from AM0PR05MB4866.eurprd05.prod.outlook.com ([fe80::d44d:a804:c730:d2b7]) by AM0PR05MB4866.eurprd05.prod.outlook.com ([fe80::d44d:a804:c730:d2b7%2]) with mapi id 15.20.3153.024; Fri, 3 Jul 2020 09:13:23 +0000 From: Parav Pandit To: dev@dpdk.org, grive@u256.net, ferruh.yigit@intel.com Cc: thomas@monjalon.net, orika@mellanox.com, matan@mellanox.com, Parav Pandit Date: Fri, 3 Jul 2020 12:12:52 +0300 Message-Id: <20200703091259.2108996-4-parav@mellanox.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200703091259.2108996-1-parav@mellanox.com> References: <20200610171728.89-2-parav@mellanox.com> <20200703091259.2108996-1-parav@mellanox.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: SN4PR0501CA0006.namprd05.prod.outlook.com (2603:10b6:803:40::19) To AM0PR05MB4866.eurprd05.prod.outlook.com (2603:10a6:208:c0::32) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from sw-mtx-036.mtx.labs.mlnx (208.176.44.194) by SN4PR0501CA0006.namprd05.prod.outlook.com (2603:10b6:803:40::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.8 via Frontend Transport; Fri, 3 Jul 2020 09:13:21 +0000 X-Mailer: git-send-email 2.26.2 X-Originating-IP: [208.176.44.194] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: b9249f41-3947-44da-6cf8-08d81f31561a X-MS-TrafficTypeDiagnostic: AM0PR05MB4353: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:327; X-Forefront-PRVS: 045315E1EE X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 488/I+VJ4HAR9keO7Qm3vMq+E42kvQ5qCrRIpNFMoxg6EtimDbPzpPeWCqoWLihFt4bCelwE53vKVvoJ6U3+xCCu2+g6jpcVC9EI762IjrjyFoxJOESaKM3z0RdvSxdFBNhjxFgkuvxOOrLOb0XBXNu1HMxTcX438tj21jpzzWsJe4Y3RFIbi1Bhctx6n/xD8ZRZpjzm8tcOIDPua8QO6fHLE/8SIrdL/Szitm69KbXx6FKUZyE71yMqdnOBvl1108FMTFtlxaG70PONI73xIyxeE4Gn5TpRCEmv/4msqUuXvV7FqRBjKEWkCfxTC7fi X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB4866.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(366004)(346002)(376002)(396003)(39860400002)(136003)(66476007)(86362001)(1076003)(66946007)(4326008)(66556008)(6506007)(6666004)(2906002)(6486002)(107886003)(478600001)(6512007)(16526019)(36756003)(316002)(8676002)(186003)(956004)(52116002)(2616005)(8936002)(83380400001)(5660300002)(26005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: LFYsD28y+rTXPTfrnSldWKJhZ+K65Z2CTV5VIQhI5ao9qyav6gfC2OkKwGKg1I0QnfhILj7p417AWaVnNBzR5eOhz+aMz8sWYG3lq+TcH3cHzgpMVYZ20L2YoXVZwSnBB7uWAbwmSEvEF984PjOelNyPvwE48AvoXkVD1lI1Hv+tU41N4fRTCqrec0M3LtHm/11tJ9jh7zpyS6XL/AFckwezjGRWnJh8y7vm7sWqUheXofpAtirhlq9uQvQULv1zXPEKOoFU5DB1dmkXQC0SLbb5/NytiJOjKa/vfAqe+4mePw+7WNfO0dkdV/jTDgO5U/1/n6HHGwYOoysHly81KOMEKhHxb2HO0ZmXL0J41QDwuY4ojf4rkQl4ktZREPSDPoJXWcf70szJvvt08Ple++n7pwefi+4RhgqXQakRZijgCTE96BLQHPciHSVML2AV4LwUIgeAI0lke/7vqrXEXPloftV4J+jv9Yb2iufsp7m5l3/wM/5WY9Yc6HfzmqbB X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: b9249f41-3947-44da-6cf8-08d81f31561a X-MS-Exchange-CrossTenant-AuthSource: AM0PR05MB4866.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jul 2020 09:13:23.3594 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IKv7mLos0wy9Z99EgTXJZZt0tZTaYpZQnpaUxO29MDkxHVhsQtYvVyyFABpDzJy1g/pNhQI8oHhS0H73GuSyGQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB4353 Subject: [dpdk-dev] [PATCH v3 03/10] common/mlx5: fix empty input style in glue wrappers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Following two errors are reported when compiled with gcc (GCC) 8.3.1 20191121 (Red Hat 8.3.1-5). drivers/common/mlx5/linux/mlx5_glue.h:188:2: error: function declaration isn't a prototype [-Werror=strict-prototypes] drivers/common/mlx5/linux/mlx5_glue.h:188:2: error: function declaration isn't a prototype [-Werror=strict-prototypes] Fix them by adding void data type in empty argument list. Fixes: 34fa7c0268e7 ("net/mlx5: add drop action to Direct Verbs E-Switch") Fixes: 400d985eb586 ("net/mlx5: add VLAN push/pop DR commands to glue") Signed-off-by: Parav Pandit Acked-by: Matan Azrad --- Changelog: v2->v3: - new patch --- drivers/common/mlx5/linux/mlx5_glue.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/common/mlx5/linux/mlx5_glue.h b/drivers/common/mlx5/linux/mlx5_glue.h index 069d8540c..e5e052a6a 100644 --- a/drivers/common/mlx5/linux/mlx5_glue.h +++ b/drivers/common/mlx5/linux/mlx5_glue.h @@ -185,11 +185,11 @@ struct mlx5_glue { void *(*dr_create_flow_action_dest_flow_tbl)(void *tbl); void *(*dr_create_flow_action_dest_port)(void *domain, uint32_t port); - void *(*dr_create_flow_action_drop)(); + void *(*dr_create_flow_action_drop)(void); void *(*dr_create_flow_action_push_vlan) (struct mlx5dv_dr_domain *domain, rte_be32_t vlan_tag); - void *(*dr_create_flow_action_pop_vlan)(); + void *(*dr_create_flow_action_pop_vlan)(void); void *(*dr_create_flow_tbl)(void *domain, uint32_t level); int (*dr_destroy_flow_tbl)(void *tbl); void *(*dr_create_domain)(struct ibv_context *ctx, -- 2.26.2