From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 5F4A0A0519;
Fri, 3 Jul 2020 15:47:33 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id B481F1DBD5;
Fri, 3 Jul 2020 15:47:09 +0200 (CEST)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
(mail-eopbgr70088.outbound.protection.outlook.com [40.107.7.88])
by dpdk.org (Postfix) with ESMTP id 46A121DBBF
for <dev@dpdk.org>; Fri, 3 Jul 2020 15:47:07 +0200 (CEST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=fgi3jSURlX32IsvV+1KiMWJqOObiuS0X/7rTfD8uY4hmdoIeIKnsS5nyEHHC+4wGR4C7bk1f6ppFOBwhgNeQktcZhP18DnKuq4rsDt4L03MzyNJZsjkJ+e6Mj9Xl3t9lInJYL96bKUXPS2Kmu0YJ8MI3Dnd3rLr5jJTBqGJVPLkyuVlrpRMs+0LnIYEAuzcFENDn47/4cRwH9J5p9zImlJSbrmQISguum7OEyMFnGgey67fuGmiZrXujeqeybSk2zvr9FSNJde+YICbb8KLQQecJe4Hkrata4Xlmq7gnnUWgXGpnrRxy+zUb/bv8iPPuri2PnoZo8QwHFrT8gp5F+g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=RpWOBd3pblhqrkJ0OEo5WAC0kGA/NL4QMCyIMNN5gO8=;
b=G+VVDz5UDSJ2NzMMlwMUDB2JZyMFJ4nHXHTBC19uVZuom8t5ORYitntxAZGp1jWxm6ObpfmR5Mm621fCiEKm6tV1NQQOAFIg8saoVa/s7NV156KFZAulxsm3l6bMA038SKqNZLL+vmckBT5FyD7gGe5g8ejtnKt5bVnWlKm1qOK4dRBoVfg1ugHEIlneoHqqilr2eYjY1bAcWrgSbyKz0L3StDOcRoizNKY8pSh2hGHQS2dKB1pWCx2LEIXbUKk+Go3fDbYJe8ElqRtrbnGjugPiHrIPkKQkSObXKEOqBYrkQvKV7RCkC2X6GDzgqDJ8SSfJUpI+ebUn3QYnIZ6xmg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com;
dkim=pass header.d=mellanox.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;
s=selector1;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=RpWOBd3pblhqrkJ0OEo5WAC0kGA/NL4QMCyIMNN5gO8=;
b=CDaNp77HCwOHqNTmxXkx9R92OnqTK2s3nHLN9RluueIur42j64tolw6cfeMw8mmyBJxwnSr0P5pwJyyvJ2EgnJ86iFGReqFXRClpo47clZO1Gw1fUAo3SfOJj2qQXXTkRIXQ8lc+TnMb/qyaZBJiW0papbUmBx45yqKOL00Exr8=
Authentication-Results: dpdk.org; dkim=none (message not signed)
header.d=none;dpdk.org; dmarc=none action=none header.from=mellanox.com;
Received: from AM0PR05MB4866.eurprd05.prod.outlook.com (2603:10a6:208:c0::32)
by AM4PR05MB3345.eurprd05.prod.outlook.com (2603:10a6:205:a::10) with
Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.21; Fri, 3 Jul
2020 13:47:06 +0000
Received: from AM0PR05MB4866.eurprd05.prod.outlook.com
([fe80::d44d:a804:c730:d2b7]) by AM0PR05MB4866.eurprd05.prod.outlook.com
([fe80::d44d:a804:c730:d2b7%2]) with mapi id 15.20.3153.024; Fri, 3 Jul 2020
13:47:06 +0000
From: Parav Pandit <parav@mellanox.com>
To: dev@dpdk.org,
grive@u256.net,
ferruh.yigit@intel.com
Cc: thomas@monjalon.net, orika@mellanox.com, matan@mellanox.com,
Parav Pandit <parav@mellanox.com>
Date: Fri, 3 Jul 2020 16:46:34 +0300
Message-Id: <20200703134641.386297-4-parav@mellanox.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20200703134641.386297-1-parav@mellanox.com>
References: <20200610171728.89-2-parav@mellanox.com>
<20200703134641.386297-1-parav@mellanox.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-ClientProxiedBy: SN4PR0401CA0009.namprd04.prod.outlook.com
(2603:10b6:803:21::19) To AM0PR05MB4866.eurprd05.prod.outlook.com
(2603:10a6:208:c0::32)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from sw-mtx-036.mtx.labs.mlnx (208.176.44.194) by
SN4PR0401CA0009.namprd04.prod.outlook.com (2603:10b6:803:21::19) with
Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.21 via Frontend
Transport; Fri, 3 Jul 2020 13:47:04 +0000
X-Mailer: git-send-email 2.26.2
X-Originating-IP: [208.176.44.194]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: 10edf08a-a617-4065-8991-08d81f5792e9
X-MS-TrafficTypeDiagnostic: AM4PR05MB3345:
X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <AM4PR05MB33453FDDCF801A413FE96337D16A0@AM4PR05MB3345.eurprd05.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:327;
X-Forefront-PRVS: 045315E1EE
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 8qlogqvtAIjzmEuP+aGTq7WKz57HkSb3XRw9LWBNK+HlvZbyYKVCENUFFeZkbASCVIaOLgU2FHg8FQnd9/JyNUaJpoCtZc7Fan3gSq+sDFJ+1i19kQpZkmtFK2t45BRIOiYWGwCJTzfqOHhTEBAoIEXzSjmWa09m3soeyyfEJGicmIaRkv1HLzC7UZeNfSfxB7Z6Xi0xG6YKs+B6r/4m6m9aGDv1fLYfqTNDSse0cnAVwg6uOqiJ74K3RMt4ymBLoHmTQu+0Q2p9kAKGJCHvM8/7Dx6OTn1vFMzvzji4DtRRplDNw9JQn9Q/AH9t0Mha
X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:AM0PR05MB4866.eurprd05.prod.outlook.com; PTR:; CAT:NONE;
SFTY:;
SFS:(4636009)(366004)(346002)(396003)(376002)(136003)(39860400002)(4326008)(66476007)(8936002)(8676002)(6486002)(6506007)(478600001)(66946007)(52116002)(83380400001)(956004)(6666004)(186003)(26005)(1076003)(16526019)(107886003)(66556008)(5660300002)(2616005)(2906002)(86362001)(36756003)(316002)(6512007);
DIR:OUT; SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: 4tOCFjsksaZwEr6FNBoTv3ZODphp2INke/9wOCJI4gsCie8RXeb2Dvh+DjeOyrjrQCAk2wR8Mn56lDHSmGgvI3BQH6mo9Dckp8UX4cP+LkbJ8TUHHNt25DmRZJJL22OHYv39bIGRudh8HewGCcKqSp0kIWTSrr09vBF1F+Sjii5xFBhKsXTnn/auL88xVUPh4E/3yhbULL+YegQVDDJKFYgLASf0FgIyUnrzxSFpC4I5p+6Q/LurI3iaFKEbyndckFm3E2mTDyQ3OThYONvUsACYCFWqLujNaLyAzLGYFLq2sKE0dMFpv7Iz10/I91IMuIQtHJrLakZDkH/DpfrxfHC0pAJNf4JYjvMZmykd/XC+CrgixVorVWAX+s4afLjbRspc6CipmtPdAHU2YFaNed8Pt6lzS0F4a7vAO+MMsrWxgVnoap5N3zT3t/6hkL2pUy+Nuk7oiGTENZ5jk0W4a/BqpfU9dFkSAuaiEBPvWTYIgN1hedQ0nwSVKwPKhNFY
X-OriginatorOrg: Mellanox.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 10edf08a-a617-4065-8991-08d81f5792e9
X-MS-Exchange-CrossTenant-AuthSource: AM0PR05MB4866.eurprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jul 2020 13:47:06.2248 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EAaBjaiDAFuGoXErXe1OqmkCZCZv6irGW59n1pWBeO4KeiymEsuXOmyrGfCv3SQPJF/aXPr/sZxB6GnlSPf1tw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3345
Subject: [dpdk-dev] [PATCH v4 03/10] common/mlx5: fix empty input style in
glue wrappers
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Following two errors are reported when compiled with
gcc (GCC) 8.3.1 20191121 (Red Hat 8.3.1-5).
drivers/common/mlx5/linux/mlx5_glue.h:188:2:
error: function declaration isn't a prototype [-Werror=strict-prototypes]
drivers/common/mlx5/linux/mlx5_glue.h:188:2:
error: function declaration isn't a prototype [-Werror=strict-prototypes]
Fix them by adding void data type in empty argument list.
Fixes: 34fa7c0268e7 ("net/mlx5: add drop action to Direct Verbs E-Switch")
Fixes: 400d985eb586 ("net/mlx5: add VLAN push/pop DR commands to glue")
Signed-off-by: Parav Pandit <parav@mellanox.com>
Acked-by: Matan Azrad <matan@mellanox.com>
---
Changelog:
v2->v3:
- new patch
---
drivers/common/mlx5/linux/mlx5_glue.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/common/mlx5/linux/mlx5_glue.h b/drivers/common/mlx5/linux/mlx5_glue.h
index 069d8540c..e5e052a6a 100644
--- a/drivers/common/mlx5/linux/mlx5_glue.h
+++ b/drivers/common/mlx5/linux/mlx5_glue.h
@@ -185,11 +185,11 @@ struct mlx5_glue {
void *(*dr_create_flow_action_dest_flow_tbl)(void *tbl);
void *(*dr_create_flow_action_dest_port)(void *domain,
uint32_t port);
- void *(*dr_create_flow_action_drop)();
+ void *(*dr_create_flow_action_drop)(void);
void *(*dr_create_flow_action_push_vlan)
(struct mlx5dv_dr_domain *domain,
rte_be32_t vlan_tag);
- void *(*dr_create_flow_action_pop_vlan)();
+ void *(*dr_create_flow_action_pop_vlan)(void);
void *(*dr_create_flow_tbl)(void *domain, uint32_t level);
int (*dr_destroy_flow_tbl)(void *tbl);
void *(*dr_create_domain)(struct ibv_context *ctx,
--
2.26.2