From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8245AA00C5; Sun, 5 Jul 2020 15:48:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A6E441DC3D; Sun, 5 Jul 2020 15:47:55 +0200 (CEST) Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by dpdk.org (Postfix) with ESMTP id 669061DC27 for ; Sun, 5 Jul 2020 15:47:52 +0200 (CEST) Received: from Internal Mail-Server by MTLPINE1 (envelope-from fady@mellanox.com) with SMTP; 5 Jul 2020 16:47:49 +0300 Received: from l-wincomp04-vm.labs.mlnx (l-wincomp04-vm.mtl.labs.mlnx [10.237.1.5]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 065DlnT1001583; Sun, 5 Jul 2020 16:47:49 +0300 From: Fady Bader To: dev@dpdk.org Cc: thomas@monjalon.net, tbashar@mellanox.com, talshn@mellanox.com, yohadt@mellanox.com, dmitry.kozliuk@gmail.com, harini.ramakrishnan@microsoft.com, ocardona@microsoft.com, pallavi.kadam@intel.com, ranjit.menon@intel.com, olivier.matz@6wind.com, arybchenko@solarflare.com, mdr@ashroe.eu, nhorman@tuxdriver.com Date: Sun, 5 Jul 2020 16:47:44 +0300 Message-Id: <20200705134746.26240-2-fady@mellanox.com> X-Mailer: git-send-email 2.16.1.windows.4 In-Reply-To: <20200705134746.26240-1-fady@mellanox.com> References: <20200705114629.2152-1-fady@mellanox.com> <20200705134746.26240-1-fady@mellanox.com> Subject: [dpdk-dev] [PATCH v6 1/3] eal: disable function versioning on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Function versioning implementation is not supported by Windows. Function versioning was disabled on Windows. Signed-off-by: Fady Bader --- lib/librte_eal/include/rte_function_versioning.h | 2 +- lib/meson.build | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/lib/librte_eal/include/rte_function_versioning.h b/lib/librte_eal/include/rte_function_versioning.h index f588f2643b..9890551ba1 100644 --- a/lib/librte_eal/include/rte_function_versioning.h +++ b/lib/librte_eal/include/rte_function_versioning.h @@ -7,7 +7,7 @@ #define _RTE_FUNCTION_VERSIONING_H_ #include -#ifndef RTE_USE_FUNCTION_VERSIONING +#if !defined RTE_USE_FUNCTION_VERSIONING && !defined RTE_EXEC_ENV_WINDOWS #error Use of function versioning disabled, is "use_function_versioning=true" in meson.build? #endif diff --git a/lib/meson.build b/lib/meson.build index c1b9e1633f..a1ab582a51 100644 --- a/lib/meson.build +++ b/lib/meson.build @@ -107,6 +107,11 @@ foreach l:libraries shared_dep = declare_dependency(include_directories: includes) static_dep = shared_dep else + if is_windows and use_function_versioning + message('@0@: Function versioning is not supported by Windows.' + .format(name)) + use_function_versioning = false + endif if use_function_versioning cflags += '-DRTE_USE_FUNCTION_VERSIONING' -- 2.16.1.windows.4