From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2F953A00C5; Mon, 6 Jul 2020 10:00:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1524C1D423; Mon, 6 Jul 2020 10:00:46 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 37D8A1C1A1 for ; Mon, 6 Jul 2020 10:00:44 +0200 (CEST) IronPort-SDR: R5ePGHTZAy1/oq1hTT97PxEtunQ6GnQc9AvoqwPrPegXwtmhfCvN65yPfLbevUyXlEVCosKhuv nEGE+9pEDk5A== X-IronPort-AV: E=McAfee;i="6000,8403,9673"; a="126964631" X-IronPort-AV: E=Sophos;i="5.75,318,1589266800"; d="scan'208";a="126964631" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jul 2020 01:00:43 -0700 IronPort-SDR: ltBXYeNRCU/vOlf+MejlBWWBRbrpe18mILUdIW05lo26NjWx9XkixeHylu5D7h8AVR3yBoryDY q5siIfdv5Cbw== X-IronPort-AV: E=Sophos;i="5.75,318,1589266800"; d="scan'208";a="427011462" Received: from unknown (HELO bricha3-MOBL.ger.corp.intel.com) ([10.252.19.54]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 06 Jul 2020 01:00:36 -0700 Date: Mon, 6 Jul 2020 09:00:33 +0100 From: Bruce Richardson To: Thomas Monjalon Cc: Ori Kam , "jerinj@marvell.com" , "xiang.w.wang@intel.com" , "guyk@marvell.com" , "dev@dpdk.org" , "pbhagavatula@marvell.com" , Shahaf Shuler , "hemant.agrawal@nxp.com" , Opher Reviv , Alex Rosenbaum , "dovrat@marvell.com" , "pkapoor@marvell.com" , "nipun.gupta@nxp.com" , "yang.a.hong@intel.com" , "harry.chang@intel.com" , "gu.jian1@zte.com.cn" , "shanjiangh@chinatelecom.cn" , "zhangy.yun@chinatelecom.cn" , "lixingfu@huachentel.com" , "wushuai@inspur.com" , "yuyingxia@yxlink.com" , "fanchenggang@sunyainfo.com" , "davidfgao@tencent.com" , "liuzhong1@chinaunicom.cn" , "zhaoyong11@huawei.com" , "oc@yunify.com" , "jim@netgate.com" , "hongjun.ni@intel.com" , "deri@ntop.org" , "fc@napatech.com" , "arthur.su@lionic.com" , Parav Pandit Message-ID: <20200706080033.GA636@bricha3-MOBL.ger.corp.intel.com> References: <1585464438-111285-1-git-send-email-orika@mellanox.com> <6699717.7Ub6e2Nl0Q@thomas> <7150376.Hi7RSQvopO@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7150376.Hi7RSQvopO@thomas> Subject: Re: [dpdk-dev] [PATCH v4 3/4] regexdev: add regexdev core functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Jul 06, 2020 at 09:03:49AM +0200, Thomas Monjalon wrote: > 06/07/2020 08:07, Ori Kam: > > From: Thomas Monjalon > > > 02/07/2020 09:46, Ori Kam: > > > > --- a/meson_options.txt > > > > +++ b/meson_options.txt > > > > @@ -30,6 +30,8 @@ option('max_lcores', type: 'integer', value: 128, > > > > description: 'maximum number of cores/threads supported by EAL') > > > > option('max_numa_nodes', type: 'integer', value: 4, > > > > description: 'maximum number of NUMA nodes supported by EAL') > > > > +option('max_regexdev_devs', type: 'integer', value: 32, > > > > + description: 'maximum number of RegEx devices') > > > > > > Do we really want to add such option in meson? > > > Some other classes do not expose any option here. > > > I tend to think it should be hidden. > > > If the max is really varying, it should be dynamic. > > > By the way, the maximum number of ethdev ports should be made infinite > > > with a dynamic array. > > > > > > Bruce, any opinion please? > > > > > Why this is just like ethdev: > > option('max_ethports', type: 'integer', value: 32, > > description: 'maximum number of Ethernet devices') > > Ethdev is the only class exposing such option. > And we already have some requests to replace it with > on-demand runtime dynamic size. > That's why it's better not exposing such bad config. > Anyway we are probably not going to need more than 32 regex engines > in the near future. It gives us time to switch to a dynamic model. > I would tend to agree. In general I do not like adding new config options so I'd prefer this not be exposed unless necessary. For ethdev, since it is by far the mostly widely used, and since we know that people have some varying port requirements, we have exposed this, while other classes have not, indicating that it's probably not necessary for most device categories. /Bruce