From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F2897A00C5; Mon, 6 Jul 2020 10:26:36 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EEF331D999; Mon, 6 Jul 2020 10:24:28 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id C32531D727 for ; Mon, 6 Jul 2020 10:24:26 +0200 (CEST) IronPort-SDR: sq7A5yTOQeA9kKGPXyzXVz5WdFm3Ko7CvfWDxAbEKFlIYxF7jdDK89O4i3+uMhg/xltHgJ9rs2 OOzsvJKDUGIw== X-IronPort-AV: E=McAfee;i="6000,8403,9673"; a="147379312" X-IronPort-AV: E=Sophos;i="5.75,318,1589266800"; d="scan'208";a="147379312" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jul 2020 01:24:26 -0700 IronPort-SDR: 3Xj9mxsH00kMRAtUCcpC0k+yJt9vzHBJILaOr9LzObRszOx76H3ZShYaz848uD2l/VLgrVzk7E 8mciTxdEKHbg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,318,1589266800"; d="scan'208";a="388128942" Received: from intel.sh.intel.com ([10.239.255.48]) by fmsmga001.fm.intel.com with ESMTP; 06 Jul 2020 01:24:24 -0700 From: Guinan Sun To: dev@dpdk.org Cc: Jeff Guo , Zhao1 Wei , Guinan Sun , Jeb Cramer Date: Mon, 6 Jul 2020 08:12:12 +0000 Message-Id: <20200706081222.19279-18-guinanx.sun@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200706081222.19279-1-guinanx.sun@intel.com> References: <20200622064634.70941-1-guinanx.sun@intel.com> <20200706081222.19279-1-guinanx.sun@intel.com> Subject: [dpdk-dev] [PATCH v3 17/27] net/e1000/base: remove useless statement X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" As it stands now, this fix will not change the current functionality of the code. In addition, we remove the comment that seemed to be a copy/paste from a separate implementation. Signed-off-by: Jeb Cramer Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_ich8lan.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/net/e1000/base/e1000_ich8lan.c b/drivers/net/e1000/base/e1000_ich8lan.c index b79e3bad8..9b9cc7d90 100644 --- a/drivers/net/e1000/base/e1000_ich8lan.c +++ b/drivers/net/e1000/base/e1000_ich8lan.c @@ -4113,13 +4113,6 @@ STATIC s32 e1000_update_nvm_checksum_spt(struct e1000_hw *hw) if (ret_val) goto release; - /* And invalidate the previously valid segment by setting - * its signature word (0x13) high_byte to 0b. This can be - * done without an erase because flash erase sets all bits - * to 1's. We can write 1's to 0's without an erase - */ - act_offset = (old_bank_offset + E1000_ICH_NVM_SIG_WORD) * 2 + 1; - /* offset in words but we read dword*/ act_offset = old_bank_offset + E1000_ICH_NVM_SIG_WORD - 1; ret_val = e1000_read_flash_dword_ich8lan(hw, act_offset, &dword); -- 2.17.1