From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A3FE2A00C5; Mon, 6 Jul 2020 14:22:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 41F1F1D727; Mon, 6 Jul 2020 14:22:35 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 3FA1A1D722 for ; Mon, 6 Jul 2020 14:22:32 +0200 (CEST) IronPort-SDR: bO7TGlikxnQ5uxwykT15AOWBWqkboSW08jzyGdUMGIMMFhPMfK1nlaxYXomIHx/6jV7GEiKVS6 RUvKfByrKxnQ== X-IronPort-AV: E=McAfee;i="6000,8403,9673"; a="146482847" X-IronPort-AV: E=Sophos;i="5.75,318,1589266800"; d="scan'208";a="146482847" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jul 2020 05:22:14 -0700 IronPort-SDR: QiZ+EOA0h7eFZUN3PofUD03GTytdl7bfR4pSSg42DpnyWmCTRIbmwo1L7W6/uGCY+OhERH4fww YVvKW/2sx0bA== X-IronPort-AV: E=Sophos;i="5.75,318,1589266800"; d="scan'208";a="456704003" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.19.54]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 06 Jul 2020 05:22:11 -0700 Date: Mon, 6 Jul 2020 13:22:08 +0100 From: Bruce Richardson To: Fady Bader Cc: dev@dpdk.org, thomas@monjalon.net, tbashar@mellanox.com, talshn@mellanox.com, yohadt@mellanox.com, dmitry.kozliuk@gmail.com, harini.ramakrishnan@microsoft.com, ocardona@microsoft.com, pallavi.kadam@intel.com, ranjit.menon@intel.com, olivier.matz@6wind.com, arybchenko@solarflare.com, mdr@ashroe.eu, nhorman@tuxdriver.com Message-ID: <20200706122208.GE636@bricha3-MOBL.ger.corp.intel.com> References: <20200705134746.26240-1-fady@mellanox.com> <20200706113241.28748-1-fady@mellanox.com> <20200706113241.28748-2-fady@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200706113241.28748-2-fady@mellanox.com> Subject: Re: [dpdk-dev] [PATCH v7 1/3] eal: disable function versioning on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Jul 06, 2020 at 02:32:39PM +0300, Fady Bader wrote: > Function versioning implementation is not supported by Windows. > Function versioning is disabled on Windows. > > Signed-off-by: Fady Bader > --- > doc/guides/windows_gsg/intro.rst | 4 ++++ > lib/meson.build | 6 +++++- > 2 files changed, 9 insertions(+), 1 deletion(-) > > diff --git a/doc/guides/windows_gsg/intro.rst b/doc/guides/windows_gsg/intro.rst > index a0285732df..58c6246404 100644 > --- a/doc/guides/windows_gsg/intro.rst > +++ b/doc/guides/windows_gsg/intro.rst > @@ -18,3 +18,7 @@ DPDK for Windows is currently a work in progress. Not all DPDK source files > compile. Support is being added in pieces so as to limit the overall scope > of any individual patch series. The goal is to be able to run any DPDK > application natively on Windows. > + > +The :doc:`../contributing/abi_policy` cannot be respected for Windows. > +Minor ABI versions may be incompatible > +because function versioning is not supported on Windows. > diff --git a/lib/meson.build b/lib/meson.build > index c1b9e1633f..dadf151f78 100644 > --- a/lib/meson.build > +++ b/lib/meson.build > @@ -107,6 +107,10 @@ foreach l:libraries > shared_dep = declare_dependency(include_directories: includes) > static_dep = shared_dep > else > + if is_windows and use_function_versioning > + message('@0@: Function versioning is not supported by Windows.' > + .format(name)) > + endif > This is ok here, but I think it might be better just moved to somewhere like config/meson.build, so that it is always just printed once for each build. I don't see an issue with having it printed even if there is no function versioning in the build itself. > if use_function_versioning > cflags += '-DRTE_USE_FUNCTION_VERSIONING' > @@ -138,7 +142,7 @@ foreach l:libraries > include_directories: includes, > dependencies: static_deps) > > - if not use_function_versioning > + if not use_function_versioning or is_windows > # use pre-build objects to build shared lib > sources = [] > objs += static_lib.extract_all_objects(recursive: false) > -- > 2.16.1.windows.4 > With or without the code move above, which is just a suggestion, Acked-by: Bruce Richardson