DPDK patches and discussions
 help / color / mirror / Atom feed
From: <jerinj@marvell.com>
To: <dev@dpdk.org>, Matan Azrad <matan@mellanox.com>,
	Viacheslav Ovsiienko <viacheslavo@mellanox.com>,
	Jerin Jacob <jerinj@marvell.com>,
	Kiran Kumar K <kirankumark@marvell.com>,
	Nithin Dabilpuram <ndabilpuram@marvell.com>,
	"Nipun Gupta" <nipun.gupta@nxp.com>,
	Hemant Agrawal <hemant.agrawal@nxp.com>,
	"Gage Eads" <gage.eads@intel.com>,
	Olivier Matz <olivier.matz@6wind.com>,
	"Adam Dybkowski" <adamx.dybkowski@intel.com>,
	Sachin Saxena <sachin.saxena@nxp.com>,
	Akhil Goyal <akhil.goyal@nxp.com>
Cc: <thomas@monjalon.net>, <david.marchand@redhat.com>
Subject: [dpdk-dev]  [PATCH] log: remove unneeded log type declaration
Date: Mon, 6 Jul 2020 18:38:11 +0530	[thread overview]
Message-ID: <20200706130811.3512556-1-jerinj@marvell.com> (raw)

From: Jerin Jacob <jerinj@marvell.com>

RTE_LOG_REGISTER macro already declares the the log type.
Remove the unneeded log type declaration.

Fixes: 9c99878aa1b16de2 ("log: introduce logtype register macro")

Reported-by: David Marchand <david.marchand@redhat.com>
Signed-off-by: Jerin Jacob <jerinj@marvell.com>
---
 drivers/vdpa/mlx5/mlx5_vdpa.c  | 1 -
 lib/librte_graph/graph.c       | 1 -
 lib/librte_rawdev/rte_rawdev.c | 3 ---
 lib/librte_stack/rte_stack.c   | 2 --
 4 files changed, 7 deletions(-)

diff --git a/drivers/vdpa/mlx5/mlx5_vdpa.c b/drivers/vdpa/mlx5/mlx5_vdpa.c
index a60fc4ef0..9bb462e95 100644
--- a/drivers/vdpa/mlx5/mlx5_vdpa.c
+++ b/drivers/vdpa/mlx5/mlx5_vdpa.c
@@ -48,7 +48,6 @@
 TAILQ_HEAD(mlx5_vdpa_privs, mlx5_vdpa_priv) priv_list =
 					      TAILQ_HEAD_INITIALIZER(priv_list);
 static pthread_mutex_t priv_list_lock = PTHREAD_MUTEX_INITIALIZER;
-int mlx5_vdpa_logtype;
 
 static struct mlx5_vdpa_priv *
 mlx5_vdpa_find_priv_resource_by_vdev(struct rte_vdpa_device *vdev)
diff --git a/lib/librte_graph/graph.c b/lib/librte_graph/graph.c
index baa383cd7..7224b00a7 100644
--- a/lib/librte_graph/graph.c
+++ b/lib/librte_graph/graph.c
@@ -18,7 +18,6 @@
 static struct graph_head graph_list = STAILQ_HEAD_INITIALIZER(graph_list);
 static rte_spinlock_t graph_lock = RTE_SPINLOCK_INITIALIZER;
 static rte_graph_t graph_id;
-int rte_graph_logtype;
 
 #define GRAPH_ID_CHECK(id) ID_CHECK(id, graph_id)
 
diff --git a/lib/librte_rawdev/rte_rawdev.c b/lib/librte_rawdev/rte_rawdev.c
index aec61f425..2eb7b3bc3 100644
--- a/lib/librte_rawdev/rte_rawdev.c
+++ b/lib/librte_rawdev/rte_rawdev.c
@@ -34,9 +34,6 @@
 #include "rte_rawdev.h"
 #include "rte_rawdev_pmd.h"
 
-/* dynamic log identifier */
-int librawdev_logtype;
-
 static struct rte_rawdev rte_rawdevices[RTE_RAWDEV_MAX_DEVS];
 
 struct rte_rawdev *rte_rawdevs = rte_rawdevices;
diff --git a/lib/librte_stack/rte_stack.c b/lib/librte_stack/rte_stack.c
index e4c0ce131..8a51fba17 100644
--- a/lib/librte_stack/rte_stack.c
+++ b/lib/librte_stack/rte_stack.c
@@ -17,8 +17,6 @@
 #include "rte_stack.h"
 #include "stack_pvt.h"
 
-int stack_logtype;
-
 TAILQ_HEAD(rte_stack_list, rte_tailq_entry);
 
 static struct rte_tailq_elem rte_stack_tailq = {
-- 
2.27.0


             reply	other threads:[~2020-07-06 13:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-06 13:08 jerinj [this message]
2020-07-06 18:10 ` Eads, Gage
2020-07-07 11:14   ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200706130811.3512556-1-jerinj@marvell.com \
    --to=jerinj@marvell.com \
    --cc=adamx.dybkowski@intel.com \
    --cc=akhil.goyal@nxp.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=gage.eads@intel.com \
    --cc=hemant.agrawal@nxp.com \
    --cc=kirankumark@marvell.com \
    --cc=matan@mellanox.com \
    --cc=ndabilpuram@marvell.com \
    --cc=nipun.gupta@nxp.com \
    --cc=olivier.matz@6wind.com \
    --cc=sachin.saxena@nxp.com \
    --cc=thomas@monjalon.net \
    --cc=viacheslavo@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).