From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A49FEA00C5; Mon, 6 Jul 2020 23:30:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 75D9D1D9DF; Mon, 6 Jul 2020 23:30:38 +0200 (CEST) Received: from mail-pj1-f65.google.com (mail-pj1-f65.google.com [209.85.216.65]) by dpdk.org (Postfix) with ESMTP id 1515E1D997 for ; Mon, 6 Jul 2020 23:30:36 +0200 (CEST) Received: by mail-pj1-f65.google.com with SMTP id md7so2436772pjb.1 for ; Mon, 06 Jul 2020 14:30:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=59YgZXzGZdrOEbAVgT8KhsK8M5ebrUXVk99UNdlAsMo=; b=ZBQt7HGEU4F3/zd4F5lAsIDj068ql7COskmySvF8E9dNfTro25hVm6st2NcOpRvmSs HwMawjOLxG8Ep9U621/FU88B8hS+H7r+8xGkV761iVvidA/WUDVCS2QN3soRTbqcMiFz btkHDVbpdASQbiYUVfl6faCbItNJFOjoXbTmtR33T0jzsrQNh3SaMPm+iy9u1lAFN8LR oFnfRE1IV2Kh6ioOFHsHvTvN/jdaeYHelLMLz5pMY47qpxyuQubii/6ob5oZJTzYeZjA ZmhCRBiARWaVOGDaiJN7Miq2j/8XkgzRbQm+HozXaAOYM5nW6NaZ2TCNr/q7SMME2+7p JABw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=59YgZXzGZdrOEbAVgT8KhsK8M5ebrUXVk99UNdlAsMo=; b=iHpsdZtaUipubrkHtD2iXe8Njza/c/4bLlDLxIwyLdrWPIGqVdyhZLxT0Cq79qsprT 1wLFYftvsG0HW7L/3N9fh2kkuSEjAnfO4gVOgkbqvn4eXRpnbkrOWORMDk5Hxavnqxuu 4LcxQRstrgOpP3caPOiUUULBhoXkcyTRc9g3NTdNmi4hv64c8U92wZJqKacV9hENJcVb SL+YT8AjzLnx2GKQQZAr2UJD21086klYhU2ioBsLVWKs7zJGmio+k3RJzX00jOKC1R1P me1tFZtraUnAh0tH/QqWX81/5E2eQvj46KbDO74PKVtLLP1B8lpLVsplR/EvAYZ015i3 sNQQ== X-Gm-Message-State: AOAM532X9+QjeYsX6dDOr/TplEVvgqtsWsKSnsuXoGXqXfOTw1OoYIq+ oa47Sds5LfuYIXWRF+gmSTGQRg== X-Google-Smtp-Source: ABdhPJzUhbMPj+gZva37tmGvKWQQ/lV587I1OIsuMBv1UuQg7HXKC/RVBKz5bw3jgkYnfmM1KwmfGw== X-Received: by 2002:a17:902:bb93:: with SMTP id m19mr42415175pls.137.1594071035335; Mon, 06 Jul 2020 14:30:35 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id c27sm19866955pfj.163.2020.07.06.14.30.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 14:30:35 -0700 (PDT) Date: Mon, 6 Jul 2020 14:30:26 -0700 From: Stephen Hemminger To: Ivan Dyukov Cc: dev@dpdk.org, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Message-ID: <20200706143026.35992c6a@hermes.lan> In-Reply-To: <20200706203743.29416-3-i.dyukov@samsung.com> References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200706203743.29416-1-i.dyukov@samsung.com> <20200706203743.29416-3-i.dyukov@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v6 02/25] ethdev: add a link status text representation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 6 Jul 2020 23:37:16 +0300 Ivan Dyukov wrote: > + /* Error cases */ > + default: > + return -1; > + Since very little of the code is checking for errors, why return on bad format. Why not do what printf() does and ignore what is not specified. Example: r = printf("Wierd %W format\n", x); printf("returned %d\n", r); Wierd %W format returned 16