From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F01A7A00BE; Tue, 7 Jul 2020 14:33:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 666B11DC85; Tue, 7 Jul 2020 14:33:21 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 508521D703; Tue, 7 Jul 2020 14:33:19 +0200 (CEST) IronPort-SDR: sTXvL7IwCqmTKJnzi774L86xXU2mfM+dKrBijyUU70oWguD/Z72o5I0rptkSIiYKMd6XsLGoTn +zq3cCZVcXog== X-IronPort-AV: E=McAfee;i="6000,8403,9674"; a="127173896" X-IronPort-AV: E=Sophos;i="5.75,323,1589266800"; d="scan'208";a="127173896" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jul 2020 05:33:18 -0700 IronPort-SDR: 5HU/mrcy7flkkVcKkkAHX8fk8x7Nu9pDooQVq2Z0Umv+BIuKudS1CYLzvXEQEEIhyCFvyqW91D Qar0bGU8sBSw== X-IronPort-AV: E=Sophos;i="5.75,323,1589266800"; d="scan'208";a="483499259" Received: from bricha3-mobl.ger.corp.intel.com ([10.251.82.195]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 07 Jul 2020 05:33:16 -0700 Date: Tue, 7 Jul 2020 13:33:13 +0100 From: Bruce Richardson To: Thomas Monjalon Cc: nipun.gupta@nxp.com, hemant.agrawal@nxp.com, dev@dpdk.org, stable@dpdk.org Message-ID: <20200707123313.GB651@bricha3-MOBL.ger.corp.intel.com> References: <20200706103132.7691-1-bruce.richardson@intel.com> <20200706103132.7691-3-bruce.richardson@intel.com> <2153624.PyFq22NkSC@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2153624.PyFq22NkSC@thomas> Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 2/3] rawdev: return NUMA socket id to the user X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jul 07, 2020 at 02:23:04PM +0200, Thomas Monjalon wrote: > 06/07/2020 12:31, Bruce Richardson: > > The rawdev info struct has a socket_id field which was not filled in. > > > > We can also omit the checks for the parameter struct being null, since > > that is previously checked in the function. > > > > Cc: stable@dpdk.org > > It looks to be a fix. > Which commit introduced this bug? The original one? > Fixes: c88b3f2558ed ("rawdev: introduce raw device library") > Yes, it can be viewed as a fix and that is the commit introducing the issue. /Bruce