From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: Tal Shnaiderman <talshn@mellanox.com>
Cc: Ranjit Menon <ranjit.menon@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
Pallavi Kadam <pallavi.kadam@intel.com>
Subject: Re: [dpdk-dev] [PATCH] eal/windows: detect insufficient privileges for hugepages
Date: Wed, 8 Jul 2020 10:49:34 +0300 [thread overview]
Message-ID: <20200708104934.5e0c7ef3@sovereign> (raw)
In-Reply-To: <AM0PR05MB53135E0FEC7AFD8CC16FCFA0A9670@AM0PR05MB5313.eurprd05.prod.outlook.com>
On Wed, 8 Jul 2020 06:43:57 +0000, Tal Shnaiderman wrote:
[snip]
Thanks for the testing.
> Do you think this is enough or do we want to give the user further indication that configuration action from his side might be needed? Something alike "Please verify OS Large-Page support is enabled for the current user"
Yes, troubleshooting suggestions would be useful.
From Microsoft "Error Message Guidelines" [1]:
Avoid the word "please". It can be interpreted to mean that a
required action is optional.
[1]:
https://docs.microsoft.com/en-us/windows/win32/debug/error-message-guidelines
--
Dmitry Kozlyuk
next prev parent reply other threads:[~2020-07-08 7:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 20:22 Dmitry Kozlyuk
2020-07-07 23:45 ` Ranjit Menon
2020-07-08 0:20 ` Dmitry Kozlyuk
2020-07-08 6:43 ` Tal Shnaiderman
2020-07-08 7:49 ` Dmitry Kozlyuk [this message]
2020-07-08 21:48 ` [dpdk-dev] [PATCH v2] " Dmitry Kozlyuk
2020-07-08 22:27 ` Ranjit Menon
2020-07-10 21:25 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200708104934.5e0c7ef3@sovereign \
--to=dmitry.kozliuk@gmail.com \
--cc=dev@dpdk.org \
--cc=navasile@linux.microsoft.com \
--cc=pallavi.kadam@intel.com \
--cc=ranjit.menon@intel.com \
--cc=talshn@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).