From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 5190DA0528;
	Thu,  9 Jul 2020 12:42:42 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 2ECA01DC07;
	Thu,  9 Jul 2020 12:42:42 +0200 (CEST)
Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58])
 by dpdk.org (Postfix) with ESMTP id F0DD11DB89
 for <dev@dpdk.org>; Thu,  9 Jul 2020 12:42:40 +0200 (CEST)
Received: from [2605:a601:a627:ca00:88f6:82e4:5f1a:31bb] (helo=localhost)
 by smtp.tuxdriver.com with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.63)
 (envelope-from <nhorman@tuxdriver.com>)
 id 1jtU0b-0006JM-Bc; Thu, 09 Jul 2020 06:42:35 -0400
Date: Thu, 9 Jul 2020 06:42:23 -0400
From: Neil Horman <nhorman@tuxdriver.com>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
 Thomas Monjalon <thomas@monjalon.net>, robin.jarry@6wind.com,
 Jie Zhou <jizh@microsoft.com>, Tal Shnaiderman <talshn@mellanox.com>
Message-ID: <20200709104223.GA2078886@hmswarspite.think-freely.org>
References: <20200708005355.7102-1-dmitry.kozliuk@gmail.com>
 <20200708212335.25338-1-dmitry.kozliuk@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200708212335.25338-1-dmitry.kozliuk@gmail.com>
X-Spam-Score: -2.9 (--)
X-Spam-Status: No
Subject: Re: [dpdk-dev] [PATCH v4 0/4] pmdinfogen: rewrite in Python
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Jul 09, 2020 at 12:23:31AM +0300, Dmitry Kozlyuk wrote:
> This patchset implements existing pmdinfogen logic in Python, replaces
> and removes the old code. The goals of rewriting are:
> 
> * easier maintenance by using a more high-level language,
> * simpler build process without host application and libelf.
> 
> Travis CI script is adjusted to install python3-pyelftools, but other CI
> systems may need similar tweaking. Particularly, testing on FreeBSD and
> big-endian targets is desired.
> 
> ---
> Changes in v4:
> 
> Fix build by removing redundant check.
> 
> Changes in v3:
> 
> 1. Rebase on ToT, add package to CI.
> 2. Add copyrights, fixup maintainers file.
> 3. Remove C implementation.
> 
> Changes in v2:
> 
> 1. pyelftools is used instead of hand-written ELF parser.
> 2. Makefiles are adjusted.
> 3. f-strings replaced with % formatting to support Python 3.5.
> 4. Wrapper script does not hide stderr from ar and pmdinfogen.
> 
> ---
> Dmitry Kozlyuk (4):
>   pmdinfogen: add Python implementation
>   build: use Python pmdinfogen
>   doc/linux_gsg: require pyelftools for pmdinfogen
>   pmdinfogen: remove C implementation
> 

I'm not currently setup to test with cross compiling, but for direct targets
(tested on power and x86), it seems to work well

Acked-by: Neil Horman <nhorman@tuxdriver.com>