From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id E1A37A052A;
	Fri, 10 Jul 2020 17:22:22 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 23AED1DA1C;
	Fri, 10 Jul 2020 17:22:22 +0200 (CEST)
Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com
 [209.85.210.193]) by dpdk.org (Postfix) with ESMTP id AB2D01DA19
 for <dev@dpdk.org>; Fri, 10 Jul 2020 17:22:20 +0200 (CEST)
Received: by mail-pf1-f193.google.com with SMTP id z3so2655863pfn.12
 for <dev@dpdk.org>; Fri, 10 Jul 2020 08:22:20 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=x+vw7mpQX8UrowpKKnn5fQhjcZBKH6iZHUrBHAcfi7s=;
 b=DmEupdTfih2s88N/hl0V/byuWk3fHSnAIH7ufiJSN07D7vts1c9B1veYW6m0xAI8iC
 buYktG/qSjJsDSCNNE3bKgIR+uYKD6j2FGfrgdnjWWGJy9XI9yvnA5jUXntzKfaMsw9z
 bzPFRVcEAXWyfIl+5cXL84OVnPjZy0OjykeJ7cp8cxZYQiMruuwoceJ5oxTs7hUYQXav
 kUr2t7E/0RTmS5FiYz8sdpoupZ1dINtscf8/mEddh0n7QYsAwTZmmkl1Y8D9R93s/iys
 wuEVPaQ3nLoujY1xlvgtxhu+p8A2GtNBSmZXUb02wT55Ww6wMYdFvVfyUUzcFCTyAHv4
 2Fkg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=x+vw7mpQX8UrowpKKnn5fQhjcZBKH6iZHUrBHAcfi7s=;
 b=o8kW6sQVgIz18IxXKj/aZjupTtlVmdJNNJHV2OGSmCdC5YqizV0HF0i1Rj/N6njYAs
 Wo0Jl6xM67sC/LIXl0nU1gPMYysuDZD9w3u91xUNCpILcbCVc2Fo3NbYRTIo0Ot/H/xN
 8Pu9QGowmISzDFOLMWnkwU9jf5oN8Y+cD3qfyeWhdhu6IQkBhTMgf62o7QVQ6kKsNAjN
 2XKQNLtyMtwTvpcDfssdgFB1uBrxShsW7u8qYT8WJ/ZvCSnpTu8aqKoepaPW4+ut7CvY
 urzsLPkVCIwI84s/WpiI9XigTGUL0zfNbAPUCsRNiLPFWUgmPvCepN7cEt1Gr/SrarwA
 9fhg==
X-Gm-Message-State: AOAM531a2/JJXu2M/GIF2CjBEJP6l45xsSX9sgrU57lQncH536yE/Af9
 0f/aQKoAZRTVHoNmAOa9iWiVng==
X-Google-Smtp-Source: ABdhPJyQPsE5khL8smCB6PVDO1PAxe1iOD2mmcWXjWFKXfYYHXez/IF/X4nokNE+M4yV+tS/zZfBJQ==
X-Received: by 2002:a63:2c96:: with SMTP id
 s144mr57638202pgs.359.1594394539891; 
 Fri, 10 Jul 2020 08:22:19 -0700 (PDT)
Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])
 by smtp.gmail.com with ESMTPSA id d37sm6166498pgd.18.2020.07.10.08.22.18
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 10 Jul 2020 08:22:19 -0700 (PDT)
Date: Fri, 10 Jul 2020 08:22:16 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>
Cc: "i.dyukov@samsung.com" <i.dyukov@samsung.com>, "dev@dpdk.org"
 <dev@dpdk.org>, "v.kuramshin@samsung.com" <v.kuramshin@samsung.com>,
 "thomas@monjalon.net" <thomas@monjalon.net>, "david.marchand@redhat.com"
 <david.marchand@redhat.com>, "arybchenko@solarflare.com"
 <arybchenko@solarflare.com>, "Zhao1, Wei" <wei.zhao1@intel.com>, "Guo, Jia"
 <jia.guo@intel.com>, "Xing, Beilei" <beilei.xing@intel.com>, "Yang, Qiming"
 <qiming.yang@intel.com>, "Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
 "mb@smartsharesystems.com" <mb@smartsharesystems.com>, "Chautru, Nicolas"
 <nicolas.chautru@intel.com>, "Richardson, Bruce"
 <bruce.richardson@intel.com>, "Ananyev, Konstantin"
 <konstantin.ananyev@intel.com>, "Dumitrescu, Cristian"
 <cristian.dumitrescu@intel.com>, "Nicolau, Radu" <radu.nicolau@intel.com>,
 "akhil.goyal@nxp.com" <akhil.goyal@nxp.com>, "Doherty, Declan"
 <declan.doherty@intel.com>, "skori@marvell.com" <skori@marvell.com>,
 "pbhagavatula@marvell.com" <pbhagavatula@marvell.com>, "jerinj@marvell.com"
 <jerinj@marvell.com>, "kirankumark@marvell.com" <kirankumark@marvell.com>,
 "Hunt, David" <david.hunt@intel.com>, "Burakov, Anatoly"
 <anatoly.burakov@intel.com>, "Li, Xiaoyun" <xiaoyun.li@intel.com>, "Wu,
 Jingjing" <jingjing.wu@intel.com>, "Mcnamara, John"
 <john.mcnamara@intel.com>, "Singh, Jasvinder" <jasvinder.singh@intel.com>,
 "Marohn, Byron" <byron.marohn@intel.com>, "Wang, Yipeng1"
 <yipeng1.wang@intel.com>
Message-ID: <20200710082216.19edf2c4@hermes.lan>
In-Reply-To: <fa873f2d21a74ed9960fe0aaf28491da@intel.com>
References: <20200427095737.11082-1-i.dyukov@samsung.com>
 <20200710070226.6045-1-i.dyukov@samsung.com>
 <CGME20200710070242eucas1p2d638073836aab0f37966a801996ee08b@eucas1p2.samsung.com>
 <20200710070226.6045-3-i.dyukov@samsung.com>
 <fa873f2d21a74ed9960fe0aaf28491da@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v7 02/25] ethdev: add a link status text
	representation
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, 10 Jul 2020 13:06:02 +0000
"Yigit, Ferruh" <ferruh.yigit@intel.com> wrote:

> > +			/* ignore unknown specifier */
> > +			default:
> > +				*str_cur = '%';
> > +				offset++;
> > +				fmt_cur--;
> > +				break;  
> 
> What do you think ignoring the unknown specifiers and keep continue
> processing the string, instead of break? Just keep unknown specifier
> as it is in the output string.

My comment was that the function should behave the same as
snprintf() does when handed unknown specifier. What snprintf
does is duplicate the string in the output buffer (like any
other non format character).