From: Hemant Agrawal <hemant.agrawal@nxp.com>
To: dev@dpdk.org
Cc: ferruh.yigit@intel.com, Hemant Agrawal <hemant.agrawal@nxp.com>
Subject: [dpdk-dev] [PATCH 6/9] net/dpaa2: report error on queue deferred start
Date: Fri, 10 Jul 2020 21:51:34 +0530 [thread overview]
Message-ID: <20200710162137.22973-6-hemant.agrawal@nxp.com> (raw)
In-Reply-To: <20200710162137.22973-1-hemant.agrawal@nxp.com>
This patch add support to reports errors on configuring
deferred start for rx or tx queues.
Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
drivers/net/dpaa2/dpaa2_ethdev.c | 18 ++++++++++++++++--
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c
index a7195f6c1..701a6ca68 100644
--- a/drivers/net/dpaa2/dpaa2_ethdev.c
+++ b/drivers/net/dpaa2/dpaa2_ethdev.c
@@ -649,7 +649,7 @@ dpaa2_dev_rx_queue_setup(struct rte_eth_dev *dev,
uint16_t rx_queue_id,
uint16_t nb_rx_desc,
unsigned int socket_id __rte_unused,
- const struct rte_eth_rxconf *rx_conf __rte_unused,
+ const struct rte_eth_rxconf *rx_conf,
struct rte_mempool *mb_pool)
{
struct dpaa2_dev_priv *priv = dev->data->dev_private;
@@ -666,6 +666,13 @@ dpaa2_dev_rx_queue_setup(struct rte_eth_dev *dev,
DPAA2_PMD_DEBUG("dev =%p, queue =%d, pool = %p, conf =%p",
dev, rx_queue_id, mb_pool, rx_conf);
+ /* Rx deferred start is not supported */
+ if (rx_conf->rx_deferred_start) {
+ DPAA2_PMD_ERR("%p:Rx deferred start not supported",
+ (void *)dev);
+ return -EINVAL;
+ }
+
if (!priv->bp_list || priv->bp_list->mp != mb_pool) {
bpid = mempool_to_bpid(mb_pool);
ret = dpaa2_attach_bp_list(priv,
@@ -794,7 +801,7 @@ dpaa2_dev_tx_queue_setup(struct rte_eth_dev *dev,
uint16_t tx_queue_id,
uint16_t nb_tx_desc __rte_unused,
unsigned int socket_id __rte_unused,
- const struct rte_eth_txconf *tx_conf __rte_unused)
+ const struct rte_eth_txconf *tx_conf)
{
struct dpaa2_dev_priv *priv = dev->data->dev_private;
struct dpaa2_queue *dpaa2_q = (struct dpaa2_queue *)
@@ -811,6 +818,13 @@ dpaa2_dev_tx_queue_setup(struct rte_eth_dev *dev,
PMD_INIT_FUNC_TRACE();
+ /* Tx deferred start is not supported */
+ if (tx_conf->tx_deferred_start) {
+ DPAA2_PMD_ERR("%p:Tx deferred start not supported",
+ (void *)dev);
+ return -EINVAL;
+ }
+
/* Return if queue already configured */
if (dpaa2_q->flow_id != 0xffff) {
dev->data->tx_queues[tx_queue_id] = dpaa2_q;
--
2.17.1
next prev parent reply other threads:[~2020-07-10 16:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-10 16:21 [dpdk-dev] [PATCH 1/9] net/dpaa2: remove Rx timestamp enable PMD API Hemant Agrawal
2020-07-10 16:21 ` [dpdk-dev] [PATCH 2/9] net/dpaa2: support per port Rx mbuf timestamp Hemant Agrawal
2020-07-10 16:21 ` [dpdk-dev] [PATCH 3/9] net/dpaa: add Tx/Rx burst mode info Hemant Agrawal
2020-07-10 16:21 ` [dpdk-dev] [PATCH 4/9] net/dpaa2: " Hemant Agrawal
2020-07-10 16:21 ` [dpdk-dev] [PATCH 5/9] net/dpaa: report error on using deferred start Hemant Agrawal
2020-07-10 16:21 ` Hemant Agrawal [this message]
2020-07-10 16:21 ` [dpdk-dev] [PATCH 7/9] net/dpaa2: add support to use Tx Queue desc size Hemant Agrawal
2020-07-10 16:21 ` [dpdk-dev] [PATCH 8/9] net/dpaa2: support Rxq and Txq info routines Hemant Agrawal
2020-07-10 16:21 ` [dpdk-dev] [PATCH 9/9] net/dpaa: " Hemant Agrawal
2020-07-21 1:32 ` [dpdk-dev] [PATCH 1/9] net/dpaa2: remove Rx timestamp enable PMD API Ferruh Yigit
2020-07-21 3:26 ` Hemant Agrawal
2020-07-21 8:56 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200710162137.22973-6-hemant.agrawal@nxp.com \
--to=hemant.agrawal@nxp.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).