From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F02CAA052A; Sun, 12 Jul 2020 21:21:23 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 987A61D502; Sun, 12 Jul 2020 21:21:22 +0200 (CEST) Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) by dpdk.org (Postfix) with ESMTP id DDA821D501 for ; Sun, 12 Jul 2020 21:21:21 +0200 (CEST) Received: by mail-pl1-f195.google.com with SMTP id p1so4513297pls.4 for ; Sun, 12 Jul 2020 12:21:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=e4MbmtvJKMXA6LLRgMHKKcifmtXRMsIz1NOxreiDyDU=; b=zt6JrVL5kA/WBdKjAO4bMzvEDx9dYDLA6nAJIBjkv1HcqAb3OTDoiMwop5zDJe0SS6 MdGV66SnNduRBAC97PWsaLkKHnzcirUWks0objT8khIOk2yZ6XWZSMMi4Ezi0wBhlOYZ xt4b3RhUDq0pkaRqRuXJCOrKH7Td2d/29Qgf3/6zMWVcW0KnHH8NXC6IZsKo+8RVJC8+ fb0WuVXBHvXdT5h+6VJGZMI2SE7u/YVJqBmpcOX8rlzh0CVSc7fuf/y7XD9RDT0bdOTA 7L05wRuFb/jhAvSZbR3fqRn7hhlvLadKuolqU2yTN5wAiqUczKl3pmJzbpS7FyVGyLxs rrTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=e4MbmtvJKMXA6LLRgMHKKcifmtXRMsIz1NOxreiDyDU=; b=hCPUJcz/LQQYNIln2gcWYKJJJJxjgoTMVvZpixPeBWH18efTcqaF8x4PNFbu1adrU4 8jMfGhKUZkPYZTsG8tutbUZ/zu8+FPsycvoexFbOX92Du/D04viyPTcOYmLHv2OlIV5r Mxl4E21rSQZH+tuDRSh3dtvHPtpDvJVC1Dw0AHhSMGPveCf81V1V2azuVScRbSn1pYvg ylt1LXUBlF2SEDP4NRCBDAFZsx/gjbMz4K9TockyVxbMcGsToXEM5brcCWVc1B/9XtCc mikl2U9hiBw/mevlbPlhZ35NmA1xUq8IwPA5/1bMtsKFusziC4S8A+T7zNTFGtoDN8C1 pyFw== X-Gm-Message-State: AOAM53268inYdMphZ/ib82+r0Tatc9mhOrS3o0upP04jkV9IHmUgPtL6 RYWVIO5fc5iPqSlhJESm/1hfwg== X-Google-Smtp-Source: ABdhPJx+eWiYCXaeWaG1zQWMjwG/mY5tac7dIsrfK5cAIbMcyrVC1WgH9KooXtEdDzBfmdvBoC7HSQ== X-Received: by 2002:a17:90a:fef:: with SMTP id 102mr16526894pjz.104.1594581680796; Sun, 12 Jul 2020 12:21:20 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id 19sm12567026pfy.193.2020.07.12.12.21.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Jul 2020 12:21:20 -0700 (PDT) Date: Sun, 12 Jul 2020 12:21:11 -0700 From: Stephen Hemminger To: Thomas Monjalon Cc: Ivan Dyukov , dev@dpdk.org, v.kuramshin@samsung.com, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com, olivier.matz@6wind.com Message-ID: <20200712122111.7b4cb0e8@hermes.lan> In-Reply-To: <1954009.Q9tCs6qVOH@thomas> References: <20200427095737.11082-1-i.dyukov@samsung.com> <1652895.iZPJ0jMcVD@thomas> <424d7367-e947-0d48-ff6e-879ae3268b27@samsung.com> <1954009.Q9tCs6qVOH@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v8 02/24] ethdev: add a link status text representation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sun, 12 Jul 2020 09:35:23 +0200 Thomas Monjalon wrote: > 11/07/2020 20:58, Ivan Dyukov: > > 11.07.2020 14:27, Thomas Monjalon =D0=BF=D0=B8=D1=88=D0=B5=D1=82: =20 > > > 11/07/2020 12:43, Ivan Dyukov: =20 > > >> +__rte_experimental > > >> +int rte_eth_link_printf(const char *const fmt, > > >> + const struct rte_eth_link *eth_link); > > >> =20 > > > Maybe I missed your reply, > > > I still don't understand the need for this function. > > > =20 > > I used it few times in apps in this patchset. It allows to avoid code= =20 > > duplication in examples. i.e. declare array, call rte_eth_link_to_str,= =20 > > call printf. > >=20 > > It's simple and usefull function. Why not? =20 >=20 > Why not is not a good justification :) > We must avoid adding too much in the API. >=20 >=20 I agree with Thomas, this whole exercise seems like a lot of effort for a log message that probably should be debug only. The DPDK should adopt the policy that all core and drivers print no log messages by default, and only log at NOTICE or higher in case of error.