From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 96A13A0540; Mon, 13 Jul 2020 11:21:56 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7337E1D566; Mon, 13 Jul 2020 11:21:56 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id A43101D544 for ; Mon, 13 Jul 2020 11:21:55 +0200 (CEST) IronPort-SDR: JJ1eYwcr6ZunC/0JfQI0wHQET+LKlS/PH4IId2B0cXZTc6G1tyLL9tjABdO5uyTUwg2YGjmFyi uqD+4S77vFiA== X-IronPort-AV: E=McAfee;i="6000,8403,9680"; a="150039386" X-IronPort-AV: E=Sophos;i="5.75,347,1589266800"; d="scan'208";a="150039386" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2020 02:21:54 -0700 IronPort-SDR: u4J33C99aj84FkLiyzXFHTzYG5fMxS89E4BcbCn2/GmVpuGrW4CLcgwwLhOvjFzR4Ymqw8QPSr OPcJEcWALYew== X-IronPort-AV: E=Sophos;i="5.75,347,1589266800"; d="scan'208";a="459228551" Received: from bricha3-mobl.ger.corp.intel.com ([10.249.32.149]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 13 Jul 2020 02:21:53 -0700 Date: Mon, 13 Jul 2020 10:21:49 +0100 From: Bruce Richardson To: Robin Jarry Cc: Louise Kilheeney , dev@dpdk.org, david.marchand@redhat.com Message-ID: <20200713092149.GB694@bricha3-MOBL.ger.corp.intel.com> References: <20200710101055.33671-1-louise.kilheeney@intel.com> <20200710133358.j535wy7onvelu3ln@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200710133358.j535wy7onvelu3ln@6wind.com> Subject: Re: [dpdk-dev] [PATCH 0/9] python2 deprecation notice X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Jul 10, 2020 at 03:33:58PM +0200, Robin Jarry wrote: > Hi Louise, > > 2020-07-10, Louise Kilheeney: > > This patchset adds deprecation notices to python scripts, > > warning of the removal of python2 support from the DPDK 20.11 release. > > While showing warnings to users about Python 2 support drop in 20.11 is > good, it seems like the shebangs in a lot of these scripts still refer > to "python". > > dpdk$ git describe > v20.05-623-geff30b59cc2e > dpdk$ git grep '#.*!.*python\>' > app/test-bbdev/test-bbdev.py:1:#!/usr/bin/env python > app/test-cmdline/cmdline_test.py:1:#!/usr/bin/env python > app/test/autotest.py:1:#!/usr/bin/env python > buildtools/map_to_win.py:1:#!/usr/bin/env python > config/arm/armv8_machine.py:1:#!/usr/bin/python > devtools/update_version_map_abi.py:1:#!/usr/bin/env python > usertools/cpu_layout.py:1:#!/usr/bin/env python > usertools/dpdk-devbind.py:1:#! /usr/bin/env python > usertools/dpdk-pmdinfo.py:1:#!/usr/bin/env python > usertools/dpdk-telemetry-client.py:1:#! /usr/bin/env python > > On many distros, "python" still points (as of today) to python2. You > series will cause warnings that cannot be avoided. > > Also, on some distros, "python" does not exist at all (RHEL 8 and CentOS > 8 for example). And only "python2" or "python3" are available. > > I wonder if it would not be better to find a way to make these shebangs > "dynamic" somehow. It is not trivial and I don't see any other solution > than plain modification of the shebangs at build time. > > However, there is no way (to my knowledge) to specify which version of > python is "selected" during the build. > > Does anyone have a proper solution? > In the absense of a "proper" solution, is the simplest option to change the shebangs to all be python3, but leave the python2 compatibility in place, and add the warnings for anyone running it explicitly using python2?