From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2B946A0540; Mon, 13 Jul 2020 14:57:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 091E31D6BE; Mon, 13 Jul 2020 14:57:35 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 76A591D69D for ; Mon, 13 Jul 2020 14:57:33 +0200 (CEST) IronPort-SDR: T0luabT7cITsyYSiO2SDY6/Z1Rxs+zYkUc86rIgfRUbPO3pB945QkmHgd8JtABCvXlmC6bCdzJ q6gYJn7H2KuQ== X-IronPort-AV: E=McAfee;i="6000,8403,9680"; a="210139176" X-IronPort-AV: E=Sophos;i="5.75,347,1589266800"; d="scan'208";a="210139176" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2020 05:57:32 -0700 IronPort-SDR: yLbb8Ejvzq7Wj/fN8oDXomiVsJwA5EZ688DWdnDbFlnQ6aolaJUyR5MzNj2IoXon0zxl2pfJuU lzAaQ9STyT5Q== X-IronPort-AV: E=Sophos;i="5.75,347,1589266800"; d="scan'208";a="459282873" Received: from bricha3-mobl.ger.corp.intel.com ([10.249.32.149]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 13 Jul 2020 05:57:30 -0700 Date: Mon, 13 Jul 2020 13:57:24 +0100 From: Bruce Richardson To: "Trahe, Fiona" Cc: "Nicolau, Radu" , "dev@dpdk.org" , "Xing, Beilei" , "Guo, Jia" , "Ananyev, Konstantin" , "jerinjacobk@gmail.com" , "david.marchand@redhat.com" , "Zhao1, Wei" Message-ID: <20200713125724.GG694@bricha3-MOBL.ger.corp.intel.com> References: <1591870283-7776-1-git-send-email-radu.nicolau@intel.com> <1594643247-11094-1-git-send-email-radu.nicolau@intel.com> <1594643247-11094-4-git-send-email-radu.nicolau@intel.com> <20200713124441.GF694@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH v6 3/4] qat: use WC store to update queue tail registers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Jul 13, 2020 at 01:52:24PM +0100, Trahe, Fiona wrote: > > > > -----Original Message----- > > From: Bruce Richardson > > Sent: Monday, July 13, 2020 1:45 PM > > To: Nicolau, Radu > > Cc: dev@dpdk.org; Xing, Beilei ; Guo, Jia ; Ananyev, Konstantin > > ; jerinjacobk@gmail.com; david.marchand@redhat.com; Trahe, Fiona > > ; Zhao1, Wei > > Subject: Re: [PATCH v6 3/4] qat: use WC store to update queue tail registers > > > > On Mon, Jul 13, 2020 at 01:27:26PM +0100, Radu Nicolau wrote: > > > Performance improvement: use a write combining store > > > instead of a regular mmio write to update queue tail > > > registers. > > > > > > Signed-off-by: Radu Nicolau > > > --- > > minor nit, I think the subject prefix on the patch should be crypto/qat. > when it affects all qat PMDs, i.e. crypto sym, crypto asym and compression, as > this does we usually use drivers/qat Ah, yes, sorry, I forgot that there was more than one qat directory in drivers. In this case, the changes are in common only, so common/qat would seem to be the right prefix. Not that it matters to the patch functionality, mind... :-)