From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 29ACCA0540; Tue, 14 Jul 2020 06:43:21 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 775A11D538; Tue, 14 Jul 2020 06:43:20 +0200 (CEST) Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) by dpdk.org (Postfix) with ESMTP id 1C2FF1C2DE for ; Tue, 14 Jul 2020 06:43:18 +0200 (CEST) Received: by mail-pl1-f195.google.com with SMTP id d1so1249765plr.8 for ; Mon, 13 Jul 2020 21:43:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pfpQ+4IikX3x4rCmu926UYTUmwZbpl/wbthOxUv1e9g=; b=lTZViLfHgP/WEtLb/Ps/OGYUeX4ldI85/z+wo4/VzDGwrzQQOLbt7IsdRTVJZWusYq k/PxOo1ziIgC/rIrkh4SrjQZkdlddmWF/m+3WkLsHAqeyt34Laap+HqHKUpyy27UOhpu iMKTEKayMPpjBr4+RNr5F5FSF2fcA+US/0ODzqlNF4ADsbzQpd0Ma57FCcZPmytkKYqt S+uaNV6G7V1ozOjVolSSpfas5YVrmT7avyJys2GZNpi94JhewLqvvPBvLh8RQ3wEv3N3 TuYMHL1Oe/5hdY9BBKyOE0d7A0CskQbdSCSbfkXBmWgOF8ZJKeNGGuaHJNbUpqeXseL0 zJYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pfpQ+4IikX3x4rCmu926UYTUmwZbpl/wbthOxUv1e9g=; b=Tln5JL+l+57sgjLLElTFvHM5lpeoyWe5fc/GzF5bDo7yQI0o76kvpIF/37ILVgInOi FKFa2tc9Qv0jDQRvXv1jRsReH0TUyAHwpH9Q79lRl0k0nwKSh3pJY6nvvbFR2gN9geGK sIvfRMSB3Vs2LG4AeEy2oX/AJ5KwAZjeMGv5jqJS68q7hB9dCKPdRbQODpMF6l4LN99E XPRYKevOzIdmEQ4umLC0TrSFq8Lw7snh1ltU79HpL5QZf1a2BOJiTAeRge9YLCNFTvCr vVpOD6bkbGt+Y6l19p7/7LtMWF0lRFOLR9O/M90F2BvHaqmpqChvx6Rga7eviyynA0ec uIsw== X-Gm-Message-State: AOAM532QJVIwbSLDUXQJwpJh3qF+TP0sWgiYBo4jaObo0MXwPcojV3ma lXkf+ioFvO30bcoF9Lly0X/hxA== X-Google-Smtp-Source: ABdhPJweH9MzZOHBWzyPqPnLCVJxR4qnZ3LtqrHnqDsyZz/Yc2c+Zf6ElVD0BHEatBKE1Sw/MQoweg== X-Received: by 2002:a17:90b:4d08:: with SMTP id mw8mr2683739pjb.119.1594701797952; Mon, 13 Jul 2020 21:43:17 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id f131sm14625310pgc.14.2020.07.13.21.43.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2020 21:43:17 -0700 (PDT) Date: Mon, 13 Jul 2020 21:43:09 -0700 From: Stephen Hemminger To: David Marchand Cc: dev , techboard@dpdk.org, Luca Boccassi , "Mcnamara, John" Message-ID: <20200713214309.7310c8c3@hermes.lan> In-Reply-To: References: <20200613000055.7909-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 00/10] rename blacklist/whitelist to block/allow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 10 Jul 2020 17:06:11 +0200 David Marchand wrote: > On Sat, Jun 13, 2020 at 2:01 AM Stephen Hemminger > wrote: > > > > The terms blacklist and whitelist are often seen as reminders > > of the divisions in society. Instead, use more exact terms for > > handling of which devices are used in DPDK. > > > > This is a proposed change for DPDK 20.08 to replace the names > > blacklist and whitelist in API and command lines. > > > > The first three patches fix some other unnecessary use of > > blacklist/whitelist and have no user visible impact. > > > > The rest change the PCI blacklist to be blocklist and > > whitelist to be allowlist. > > Thanks for working on this. > > I agree, the first patches can go in right now. > > But I have some concerns about the rest. > > New options in EAL are not consistent with "allow"/"block" list: > + "b:" /* pci-skip-probe */ > + "w:" /* pci-only-probe */ > +#define OPT_PCI_SKIP_PROBE "pci-skip-probe" > + OPT_PCI_SKIP_PROBE_NUM = 'b', > +#define OPT_PCI_ONLY_PROBE "pci-only-probe" > + OPT_PCI_ONLY_PROBE_NUM = 'w', > > The CI flagged the series as failing, because the unit test for EAL > flags is unaligned: > +#define pci_allowlist "--pci-allowlist" > https://travis-ci.com/github/ovsrobot/dpdk/jobs/348668299#L5657 > > > The ABI check complains about the enum update: > https://travis-ci.com/github/ovsrobot/dpdk/jobs/348668301#L2400 > Either we deal with this, or we need a libabigail exception rule. > > > About deprecating existing API/EAL flags in this release, this should > go through the standard deprecation process. > I would go with introducing new options + full compatibility + a > deprecation notice in the 20.08 release. > The actual deprecation/API flagging will go in 20.11. > Removal will come later. > > The next version will use different flags, and the old flags will cause runtime deprecation warning.