From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5A806A0546; Thu, 16 Jul 2020 12:02:29 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 032751BE98; Thu, 16 Jul 2020 12:02:28 +0200 (CEST) Received: from relay10.mail.gandi.net (relay10.mail.gandi.net [217.70.178.230]) by dpdk.org (Postfix) with ESMTP id 0583A1BE95 for ; Thu, 16 Jul 2020 12:02:26 +0200 (CEST) Received: from u256.net (lfbn-idf2-1-1144-40.w90-92.abo.wanadoo.fr [90.92.205.40]) (Authenticated sender: grive@u256.net) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 0AFFA24002A for ; Thu, 16 Jul 2020 10:02:00 +0000 (UTC) Resent-From: =?utf-8?Q?Ga=C3=ABtan?= Rivet Resent-Date: Thu, 16 Jul 2020 12:01:54 +0200 Resent-Message-ID: <20200716100154.e75dwiiuntebzcmf@u256.net> Resent-To: dev@dpdk.org Date: Thu, 16 Jul 2020 11:43:50 +0200 From: =?utf-8?Q?Ga=C3=ABtan?= Rivet To: Manish Chopra , ferruh.yigit@intel.com, Thomas Monjalon Cc: jerinjacobk@gmail.com, irusskikh@marvell.com, rmody@marvell.com, GR-Everest-DPDK-Dev@marvell.com, anatoly.burakov@intel.com, xavier.huwei@huawei.com, humin29@huawei.com, yisen.zhuang@huawei.com, xiao.w.wang@intel.com, qiming.yang@intel.com, qi.z.zhang@intel.com, heinrich.kuhn@netronome.com Message-ID: <20200716094341.psrbvcpxc4ojvgju@u256.net> References: <20200713151319.17547-1-manishc@marvell.com> <20200713151319.17547-2-manishc@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200713151319.17547-2-manishc@marvell.com> Subject: Re: [dpdk-dev] [PATCH v2 1/7] lib/librte_pci: add rte_pci_regs.h X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 13/07/20 08:13 -0700, Manish Chopra wrote: > This is merely copy of latest linux/pci_regs.h in > order to avoid dependency of dpdk on user headers. > I guess this dependency is an issue on non-linux systems, when you must use those defines in a generic implementation. Can you confirm this is the motivation here? If so, I think it would be clearer to state "in order to avoid dependency of DPDK on linux headers". > Signed-off-by: Manish Chopra > Signed-off-by: Igor Russkikh > --- > drivers/bus/pci/linux/pci_uio.c | 2 +- > drivers/bus/pci/linux/pci_vfio.c | 2 +- > drivers/net/bnx2x/bnx2x.h | 2 +- > drivers/net/hns3/hns3_ethdev_vf.c | 2 +- > drivers/vdpa/ifc/base/ifcvf_osdep.h | 2 +- > lib/librte_pci/Makefile | 1 + > lib/librte_pci/meson.build | 2 +- > lib/librte_pci/rte_pci_regs.h | 1075 +++++++++++++++++++++++++++ > 8 files changed, 1082 insertions(+), 6 deletions(-) > create mode 100644 lib/librte_pci/rte_pci_regs.h > [...] > diff --git a/lib/librte_pci/rte_pci_regs.h b/lib/librte_pci/rte_pci_regs.h > new file mode 100644 > index 000000000..1d11f4de5 > --- /dev/null > +++ b/lib/librte_pci/rte_pci_regs.h > @@ -0,0 +1,1075 @@ > +/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */ > +/* This file is delivered alongside the PCI lib, targeting userspace. This seems to be an exception to the license policy described in license/README. Code shared between kernel and userspace is expected to be dual-licensed BSD-3 and GPL-2.0. As it is a copy of Linux user includes, re-licensing it as BSD-3 as well is not possible. So I think it might require a techboard + governing board exception approval. Ferruh or Thomas, what do you think? -- Gaëtan