From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 749E0A053B; Fri, 17 Jul 2020 15:50:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C148D1C1A8; Fri, 17 Jul 2020 15:49:55 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2085.outbound.protection.outlook.com [40.107.20.85]) by dpdk.org (Postfix) with ESMTP id A35541C197 for ; Fri, 17 Jul 2020 15:49:53 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kYflIP0GYuujzmI7xYhHhxj4jPL3h7FZLjDQSImKxZBcqkljtE7iA70mGNkFvxb5HKrlu28+/nA9TutnhtBPk5lXpVH2wVgL8cibUvJRqJopsIT6/Uh3G+MOMzmRpT/DMoA9/x12uMaL7EgpgPS9Y2146Ij5kRBcaSRkk1/YkBfJEexBEvttmcPa3GdsmQuv0eFpTQJnU2VI18K3g6uNWqxO2m1mrHVgXxI5XTPnDvV7rCJs5Y2yJpoKDoO3gPvdzyoomvu9l9jbOfoGKMpvGG6+AHi3u13vJEwFeJet76fc+wpiFPIRMlNmm8ZUQXdYuhEsyODRzZWkNQAyOTRQgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0Cj9bmJpkMdo2vYDrWuVQAiHPCBtvOWB1vGWWm2mziI=; b=OY4ybjUAfWxidlQCynI+1C1bXCMwhQbgYxe3HuF8WSmjijKTSjoMa2DdS69vGcGNg3auRUGu9zpyeSdedsidQLyB5GjmMLFLK+Hd5AgE9dv+sqjSo6/XqMUlMqrOc38RM19qBDyxmtDajHQ7PQ3XsBuUoB9rAy8/J40/62fFmRXs0viBtpY1KXjCB+4v6WtOxPcbSEEHBJ4l+pTahEtsr8I9c7gpzB52D+71kF0lI5CLOfOwTi+dS0CAPPZ1JTOXECGP5nCac3Cptdse7NRrKbxRy00nhL5tkKNsSdzyXlX9cIyM0ZaGaPvgo204Y/SrlIk8REY95P9K+ABSQ0nNrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0Cj9bmJpkMdo2vYDrWuVQAiHPCBtvOWB1vGWWm2mziI=; b=ayg8x84xSSlynJuVplk4id/WcEiuzR29VbgWVGj3eT+U3mSbLSa6BDrvYRu6ry1N6TsKKuA/ZmWshpQzoNbDxFNr5a5HzfUNlGB27kgq4IrXRrCBGImN51nmLX45HtmgioHIwZfgENgQQFz2wtZXrQlAmN1Qy5jW+y9Vq47ND2k= Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=mellanox.com; Received: from AM0PR05MB4866.eurprd05.prod.outlook.com (2603:10a6:208:c0::32) by AM0PR05MB4355.eurprd05.prod.outlook.com (2603:10a6:208:59::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.21; Fri, 17 Jul 2020 13:49:52 +0000 Received: from AM0PR05MB4866.eurprd05.prod.outlook.com ([fe80::d44d:a804:c730:d2b7]) by AM0PR05MB4866.eurprd05.prod.outlook.com ([fe80::d44d:a804:c730:d2b7%2]) with mapi id 15.20.3174.026; Fri, 17 Jul 2020 13:49:52 +0000 From: Parav Pandit To: dev@dpdk.org, grive@u256.net, ferruh.yigit@intel.com, thomas@monjalon.net Cc: rasland@mellanox.com, orika@mellanox.com, matan@mellanox.com, joyce.kong@arm.com, Parav Pandit Date: Fri, 17 Jul 2020 16:49:18 +0300 Message-Id: <20200717134924.922390-4-parav@mellanox.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200717134924.922390-1-parav@mellanox.com> References: <20200610171728.89-2-parav@mellanox.com> <20200717134924.922390-1-parav@mellanox.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: DM3PR03CA0013.namprd03.prod.outlook.com (2603:10b6:0:50::23) To AM0PR05MB4866.eurprd05.prod.outlook.com (2603:10a6:208:c0::32) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from sw-mtx-036.mtx.labs.mlnx (208.176.44.194) by DM3PR03CA0013.namprd03.prod.outlook.com (2603:10b6:0:50::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.19 via Frontend Transport; Fri, 17 Jul 2020 13:49:50 +0000 X-Mailer: git-send-email 2.26.2 X-Originating-IP: [208.176.44.194] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: ed0d7b28-835c-4ddc-638d-08d82a5847cb X-MS-TrafficTypeDiagnostic: AM0PR05MB4355: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtFwd,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:327; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6NN4A5L6fxa/bgZ+UBfjKoJt8pjSC+dLptdnL87KyWumD4p4UzUOj7HFFVWxsxGxvpg5coDxbEBxs0k2maIe9GP06hK2TJIIoNJIptHIC4UmnKJh3DQzWnTADQHndsoaxSKRqb9ooMzaeht5AgQpM0IodScChe9raoapLdWSvyTULO4PAEhkL9VxF4u7f65onhv3/gun8gTpr9y5WPjHkwMC1v3MHwOk5yrur1oEnCbHDez5+k/tAuiRxmEDUH7U4szh71O9ENKZWYD5bLiBptP6eJZtpfpNHZTRMZ2uRDZ7i3bY0AxTOckkk5Igll2k X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB4866.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(346002)(396003)(39860400002)(376002)(366004)(8936002)(6666004)(83380400001)(2616005)(107886003)(956004)(86362001)(478600001)(4326008)(16526019)(186003)(26005)(6512007)(52116002)(1076003)(6506007)(66476007)(66946007)(5660300002)(2906002)(8676002)(66556008)(316002)(36756003)(6486002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: q7dTt2vsMmoqNuwojgdwf/dNPkgBgB80N8yhgR3loH3OYz0qJuLVukWbmlJ/C+SJ73fvG/hQeOkOYQ+T2r2lVcgr7RxjzNzVbGY8J5mpByRukxKPM5Jc37wFNgeUIi5ipihZG87PN5Fc2Hex1czN/q5ZPTdhOUEu5jsFa9yJkSTkZvQ/3EWvhTwAvqSypvmc6yWCu+1q850UwzZDjlyw1YDn9oFJuawGFyS8sT52/G/xx9lxGbcFxk5MMiJAwXnbX6fC3E62Cjh9wfLi+pkt8VxTRghCNoI+RteyNdaZ9QaK/tQgb0NuwLumV8jipM4/iXK+wmxbg4PUnTIiC/637Wabrwd01P2JREGlRH56sPiV05W2+kT1h31mQ7v5M0KVzQ2OQja1T0EiE9gU0u5EidJgCcKFWxtwcaQK2Z5GoUiSM4dujenT2VqFw1OI4Nslcxqq0ykDWo8DbpauBWY7YWyZO2/l0pT62ydvlORmG1wIfqr0jvdc/zbA9vwnOQlw X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: ed0d7b28-835c-4ddc-638d-08d82a5847cb X-MS-Exchange-CrossTenant-AuthSource: AM0PR05MB4866.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2020 13:49:52.5124 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ErB+3aqS+dCmuPcNvXB8YEjFInps76+zqs6onAxKaUT8eXj96NF8UhKzZKGnSh/YCqtwh2qdfBz8YPfFy3vLLw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB4355 Subject: [dpdk-dev] [PATCH v7 3/9] common/mlx5: fix empty input style in glue wrappers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Following two errors are reported when compiled with gcc (GCC) 8.3.1 20191121 (Red Hat 8.3.1-5). drivers/common/mlx5/linux/mlx5_glue.h:188:2: error: function declaration isn't a prototype [-Werror=strict-prototypes] drivers/common/mlx5/linux/mlx5_glue.h:188:2: error: function declaration isn't a prototype [-Werror=strict-prototypes] Fix them by adding void data type in empty argument list. Fixes: 34fa7c0268e7 ("net/mlx5: add drop action to Direct Verbs E-Switch") Fixes: 400d985eb586 ("net/mlx5: add VLAN push/pop DR commands to glue") Signed-off-by: Parav Pandit Acked-by: Matan Azrad --- Changelog: v2->v3: - new patch --- drivers/common/mlx5/linux/mlx5_glue.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/common/mlx5/linux/mlx5_glue.h b/drivers/common/mlx5/linux/mlx5_glue.h index c4f9b006a..734ace2a3 100644 --- a/drivers/common/mlx5/linux/mlx5_glue.h +++ b/drivers/common/mlx5/linux/mlx5_glue.h @@ -185,11 +185,11 @@ struct mlx5_glue { void *(*dr_create_flow_action_dest_flow_tbl)(void *tbl); void *(*dr_create_flow_action_dest_port)(void *domain, uint32_t port); - void *(*dr_create_flow_action_drop)(); + void *(*dr_create_flow_action_drop)(void); void *(*dr_create_flow_action_push_vlan) (struct mlx5dv_dr_domain *domain, rte_be32_t vlan_tag); - void *(*dr_create_flow_action_pop_vlan)(); + void *(*dr_create_flow_action_pop_vlan)(void); void *(*dr_create_flow_tbl)(void *domain, uint32_t level); int (*dr_destroy_flow_tbl)(void *tbl); void *(*dr_create_domain)(struct ibv_context *ctx, -- 2.26.2