From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4E147A0527; Sat, 18 Jul 2020 04:22:42 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E105F1BF7E; Sat, 18 Jul 2020 04:22:40 +0200 (CEST) Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by dpdk.org (Postfix) with ESMTP id 548AA1BF70 for ; Sat, 18 Jul 2020 04:22:39 +0200 (CEST) Received: by mail-pf1-f196.google.com with SMTP id a14so6241817pfi.2 for ; Fri, 17 Jul 2020 19:22:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fthfi9GQD0U7T0HTh3GIyvCJBO2zf/gnMOfP8z4e9U8=; b=HpWV5kKmHb7Y3b9rhP/inXo8ImTVciBImoQkivzgEVm41GpwIiuaEf0blrUvCgFtFI RU+s7Svor6Cl/m4VJmlSRqZ/ZfbD00/5ymTNPmT0b0ZHHuxT2jtUwPbpKpladiXdSAEC lNUB6CAgtqbUSUJEDA/JeIIgaFGG0I6ZRZCz6ty8Q2z00R0f1KnhzjGXQNQlXaSTNMv/ bgOXpAmQ2OQLrQQuwv9x5DpOHhlgqfjr6lVPz59OCyTqEyvQwt1wv1s1kjmtJNZVA0wA ClJPPYpSQ9ZaB2ZxJDAwd0gYlVnoU7I1WTiYVNLQ1gtt5UQl6pmYGc3suCvmyPAHmj1P UU6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fthfi9GQD0U7T0HTh3GIyvCJBO2zf/gnMOfP8z4e9U8=; b=gjO8yoRFPOuTmaj92iMw78x14bYf2848WUOvSMgjL05/iCLnhPfbiIlyZzHAo/nYRa r9Lp0fxZF/HlDEpFv9YNYLTbaxZZQAy7YIYHnstS4PTTcE/BfjgrY2k+KdLFKhO9vohd Sv8ML1bMmxlkDQDlUnVVjCiHyyOVit6c2PaEyWU2Gnuk6e0uHBkC211SsCSDI03+31Ca sPQegkp29mG43wAHnTtIgkSye/5/pwWTyCohTEFoPh24DU4bN/UMa2OMJIvFI+xtKAk2 ioYXLQzKxO/euc8La6Yu9JkDKn2tkFisMS0mzq2kBrISIBGX/yqV9DvrEHMK/Pamj2o5 6+vg== X-Gm-Message-State: AOAM531/k/sCPbaeBPZQylHZS4Y5aP6F03oM5pWNGRb4nZJRMsb7ztDl pxNYnF6P5Q3Jncd2bDVZD5ffAA== X-Google-Smtp-Source: ABdhPJya7+TORHHZybuDS3RnJjA5Q/Rcd2f0fnrX9dbNdxP+CQEMLndPM2j9ARlAEp/1mqrDq3foXw== X-Received: by 2002:a62:3204:: with SMTP id y4mr10052740pfy.50.1595038958412; Fri, 17 Jul 2020 19:22:38 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id y63sm8562668pgb.49.2020.07.17.19.22.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 19:22:38 -0700 (PDT) Date: Fri, 17 Jul 2020 19:22:35 -0700 From: Stephen Hemminger To: "Burakov, Anatoly" Cc: dev@dpdk.org Message-ID: <20200717192235.3636fcce@hermes.lan> In-Reply-To: <88cf6911-c0e5-1f37-5f2d-51232d8dc787@intel.com> References: <20200604210200.25405-1-stephen@networkplumber.org> <20200701202359.17006-1-stephen@networkplumber.org> <20200701202359.17006-26-stephen@networkplumber.org> <20200715132910.5aaa11ed@hermes.lan> <2e34fe08-6548-e474-a7bc-f10e4bef947a@intel.com> <20200716150429.664a524e@hermes.lan> <88cf6911-c0e5-1f37-5f2d-51232d8dc787@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 25/27] eal: mark old naming as deprecated X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 17 Jul 2020 16:21:37 +0100 "Burakov, Anatoly" wrote: > On 16-Jul-20 11:04 PM, Stephen Hemminger wrote: > > On Thu, 16 Jul 2020 14:41:41 +0100 > > "Burakov, Anatoly" wrote: > > > >> On 15-Jul-20 9:29 PM, Stephen Hemminger wrote: > >>> On Wed, 15 Jul 2020 14:28:17 +0100 > >>> "Burakov, Anatoly" wrote: > >>> > >>>>> -#define SKIP_MASTER SKIP_INITIAL > >>>>> -#define CALL_MASTER CALL_INITIAL > >>>>> +#define SKIP_MASTER _Pragma("GCC warning \"'SKIP_MASTER' is deprecated\"") SKIP_INITIAL > >>>>> +#define CALL_MASTER _Pragma("GCC warning \"'CALL_MASTER' is deprecated\"") CALL_INITIAL > >>>> > >>>> Presumably this is a generic header, should we introduce GCC-specific > >>>> things there? > >>> > >>> It works with Clang as well. Likely ICC but don't have that. > >>> > >> > >> What about MSVC? > >> > > > > _Pragma is C99 standard so MSVC know it. > > MSVC should ignore any pragman it doesn't understand. > > > > There is a better pragma for deprecating keywords in MSVC, but GCC and Clang don't > > understand it. > > > > Deprecating macros sounds like something we might want to do in the > future, can't we put some macro into rte_common.h to address this? e.g. > something like > > #ifdef MSVC > #define rte_deprecated_macro _msvc_pragma_whatever() > #else > #define rte_deprecated_macro _Pragma("GCC warning ...") > #endif > > and use this macro here? It gets hard to do macro in a macro,