From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DFE9BA0540; Mon, 20 Jul 2020 11:43:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9802929CB; Mon, 20 Jul 2020 11:43:02 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id B567C1AFB for ; Mon, 20 Jul 2020 11:43:00 +0200 (CEST) IronPort-SDR: Y3N6rIUpROPPQwd654p9ofZH0dxvnDcpZGijiXASuQlLV2K60UraSilpfeY6NEZhQYpOpVied+ OO++NiFzqlAg== X-IronPort-AV: E=McAfee;i="6000,8403,9687"; a="147379265" X-IronPort-AV: E=Sophos;i="5.75,374,1589266800"; d="scan'208";a="147379265" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jul 2020 02:42:59 -0700 IronPort-SDR: vBfzxmvg8/KzrpnnuwfGQH1ZvXUYnctNofCIj2sevC7Al5gueULjZCmSbF1yL7PwKoX7hEDifm PmS0r4NAAgtw== X-IronPort-AV: E=Sophos;i="5.75,374,1589266800"; d="scan'208";a="461626292" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.33.168]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 20 Jul 2020 02:42:56 -0700 Date: Mon, 20 Jul 2020 10:42:52 +0100 From: Bruce Richardson To: Akhil Goyal Cc: "asomalap@amd.com" , "anoobj@marvell.com" , "roy.fan.zhang@intel.com" , "fiona.trahe@intel.com" , "rnagadheeraj@marvell.com" , "adwivedi@marvell.com" , "jianjay.zhou@huawei.com" , "pablo.de.lara.guarch@intel.com" , "adamx.dybkowski@intel.com" , "ruifeng.wang@arm.com" , "declan.doherty@intel.com" , "dev@dpdk.org" Message-ID: <20200720094252.GA726@bricha3-MOBL.ger.corp.intel.com> References: <20200520152612.2920-1-akhil.goyal@nxp.com> <20200716190713.23296-1-akhil.goyal@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH v2] test/crypto: skip unsupported cases X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Jul 20, 2020 at 09:27:57AM +0000, Akhil Goyal wrote: > Hi All, > > > blockcipher cases are either returning TEST_SUCCESS > > or TEST_FAILED as status, but the test may not be > > supported by the PMD which is also a success case > > for the PMD. Hence checking for status == TEST_FAILED > > for setting the overall status as failed. > > > > Signed-off-by: Akhil Goyal > > --- > > Any comments on this patch? > Not an expert on the crypto area, but on code-review the changes look good to me as it makes the return value match the output describing what is happening. Reviewed-by: Bruce Richardson