From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1838EA0527; Mon, 20 Jul 2020 16:32:41 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EA3161BFC4; Mon, 20 Jul 2020 16:32:40 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id CDA20A69 for ; Mon, 20 Jul 2020 16:32:39 +0200 (CEST) IronPort-SDR: g6LxZspd6PwKlII0a8V8iKV/ZMZCtxpyXuA6jHvMoX16DiRE/ss3oumAUCPAL9py+oi4tv97OP 4Sly0ptug8gg== X-IronPort-AV: E=McAfee;i="6000,8403,9687"; a="129998584" X-IronPort-AV: E=Sophos;i="5.75,375,1589266800"; d="scan'208";a="129998584" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jul 2020 07:32:39 -0700 IronPort-SDR: d6geSD8MA1K77Kct5XSPYmwnH6a9Psgut81G/e/er85kNEsUJdRggQ+IsyYNnM4qjAOdbFTreh kXbTgTvYOkvQ== X-IronPort-AV: E=Sophos;i="5.75,375,1589266800"; d="scan'208";a="461708301" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.33.168]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 20 Jul 2020 07:32:36 -0700 Date: Mon, 20 Jul 2020 15:32:32 +0100 From: Bruce Richardson To: Ciara Power Cc: kevin.laatz@intel.com, thomas@monjalon.net, ferruh.yigit@intel.com, arybchenko@solarflare.com, dev@dpdk.org, keith.wiles@intel.com, Louise Kilheeney Message-ID: <20200720143232.GA731@bricha3-MOBL.ger.corp.intel.com> References: <20200612105344.15383-1-ciara.power@intel.com> <20200720140403.69865-1-ciara.power@intel.com> <20200720140403.69865-3-ciara.power@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200720140403.69865-3-ciara.power@intel.com> Subject: Re: [dpdk-dev] [PATCH v7 2/3] test/test_telemetry_data: add unit tests for data to JSON X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Jul 20, 2020 at 03:04:02PM +0100, Ciara Power wrote: > From: Louise Kilheeney > > This patch adds tests for verifying telemetry data structures are > converted to JSON as expected. Both flat and recursive data structures > are tested, for all possible value types. > > The app connects to the telemetry socket as a client, and registers one > command with a corresponding callback function. Each time the callback > function is called, it copies a global data variable to the data pointer > passed in by telemetry. > When a test case is run, the test case function builds up the global > data variable with the relevant data types, and the expected json string > output which should be generated from that. The 'test_output()' function > is used to trigger the callback and ensure the actual output matches > that expected. > > Signed-off-by: Louise Kilheeney > Signed-off-by: Ciara Power > Acked-by: Bruce Richardson