From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E657BA0526; Tue, 21 Jul 2020 15:51:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 559F01BFEB; Tue, 21 Jul 2020 15:51:14 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 1CAB01BFE7 for ; Tue, 21 Jul 2020 15:51:12 +0200 (CEST) IronPort-SDR: Nbg+cCHtajVUpekUc24qXdWzzJdIDgKLMCbAplV4mW/m6Hvw2/iD78tRioXVEZ90+Vjgqt4K6w ZH3FIGr7Nt0A== X-IronPort-AV: E=McAfee;i="6000,8403,9688"; a="149279632" X-IronPort-AV: E=Sophos;i="5.75,379,1589266800"; d="scan'208";a="149279632" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jul 2020 06:51:12 -0700 IronPort-SDR: XydRPZBlqz4mDobCYZdJYxIMVgfwL0n5y3xr1hYG4O4PUl+A7//UvG34np42sAa2z7COMCbtWd I5H5pFcfoA5A== X-IronPort-AV: E=Sophos;i="5.75,379,1589266800"; d="scan'208";a="488088895" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.9.114]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 21 Jul 2020 06:51:10 -0700 Date: Tue, 21 Jul 2020 14:51:07 +0100 From: Bruce Richardson To: Dmitry Kozlyuk Cc: dev@dpdk.org, Neil Horman , Thomas Monjalon , robin.jarry@6wind.com, Jie Zhou , Tal Shnaiderman Message-ID: <20200721135107.GD735@bricha3-MOBL.ger.corp.intel.com> References: <20200708005355.7102-1-dmitry.kozliuk@gmail.com> <20200708212335.25338-1-dmitry.kozliuk@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200708212335.25338-1-dmitry.kozliuk@gmail.com> Subject: Re: [dpdk-dev] [PATCH v4 0/4] pmdinfogen: rewrite in Python X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jul 09, 2020 at 12:23:31AM +0300, Dmitry Kozlyuk wrote: > This patchset implements existing pmdinfogen logic in Python, replaces > and removes the old code. The goals of rewriting are: > > * easier maintenance by using a more high-level language, > * simpler build process without host application and libelf. > > Travis CI script is adjusted to install python3-pyelftools, but other CI > systems may need similar tweaking. Particularly, testing on FreeBSD and > big-endian targets is desired. > > --- > Changes in v4: > > Fix build by removing redundant check. > > Changes in v3: > > 1. Rebase on ToT, add package to CI. > 2. Add copyrights, fixup maintainers file. > 3. Remove C implementation. > > Changes in v2: > > 1. pyelftools is used instead of hand-written ELF parser. > 2. Makefiles are adjusted. > 3. f-strings replaced with % formatting to support Python 3.5. > 4. Wrapper script does not hide stderr from ar and pmdinfogen. > > --- > Dmitry Kozlyuk (4): > pmdinfogen: add Python implementation > build: use Python pmdinfogen > doc/linux_gsg: require pyelftools for pmdinfogen > pmdinfogen: remove C implementation > I've done builds with this patchset on linux and FreeBSD and checked the results with dpdk-pmdinfo script. All looks ok to me. Series-tested-by: Bruce Richardson