From: Bruce Richardson <bruce.richardson@intel.com>
To: Ciara Power <ciara.power@intel.com>
Cc: kevin.laatz@intel.com, dev@dpdk.org, john.mcnamara@intel.com,
marko.kovacevic@intel.com
Subject: Re: [dpdk-dev] [PATCH v2] doc: add more detail to telemetry guides
Date: Tue, 21 Jul 2020 18:38:52 +0100 [thread overview]
Message-ID: <20200721173852.GK735@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20200721160924.62082-1-ciara.power@intel.com>
On Tue, Jul 21, 2020 at 05:09:24PM +0100, Ciara Power wrote:
> This patch adds examples to the Telemetry HowTo guide, to demonstrate
> commands that use parameters. The programmer's guide is also modified to
> include details on writing a callback function for a new command.
>
> Signed-off-by: Ciara Power <ciara.power@intel.com>
>
> ---
> v2:
> - Replaced examples of using commands in the programmer's guide with
> a link to the HowTo guide.
> - Added an example showing the use of a single string value.
> - Replaced inline functions with a synthetic example function below
> the list of parameters.
> ---
> doc/guides/howto/telemetry.rst | 46 ++++++-
> doc/guides/prog_guide/telemetry_lib.rst | 172 ++++++++++++++++++++----
> 2 files changed, 187 insertions(+), 31 deletions(-)
>
Missed threading patch with v1, but content looks fine to me.
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
next prev parent reply other threads:[~2020-07-21 17:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 16:09 Ciara Power
2020-07-21 17:38 ` Bruce Richardson [this message]
2020-07-22 17:27 ` Thomas Monjalon
2020-07-24 11:32 ` Power, Ciara
2020-07-24 11:20 ` [dpdk-dev] [PATCH v3] " Ciara Power
2020-07-24 11:45 ` Power, Ciara
2020-07-30 18:28 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200721173852.GK735@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=ciara.power@intel.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=kevin.laatz@intel.com \
--cc=marko.kovacevic@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).