From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BCB82A0526; Tue, 21 Jul 2020 19:38:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8655F1BFBB; Tue, 21 Jul 2020 19:38:59 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id E8399E07 for ; Tue, 21 Jul 2020 19:38:57 +0200 (CEST) IronPort-SDR: 4x1nAhmCkYGFT3P4RHWXfND2YVYmKiaaj813hxgFCF8ctLsAbtHzotFU6TtJVhOuHY5G3jOjdJ vH/mGYBRcnDA== X-IronPort-AV: E=McAfee;i="6000,8403,9689"; a="138279835" X-IronPort-AV: E=Sophos;i="5.75,379,1589266800"; d="scan'208";a="138279835" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jul 2020 10:38:57 -0700 IronPort-SDR: F+D+ne2lFAOPGN+Yik0kr/FxQpTcqxGsdSBSO0M1kDyMCem7x/GYbpGS9xKDaReDoAXuPV6N90 /4n6I/jAWVIw== X-IronPort-AV: E=Sophos;i="5.75,379,1589266800"; d="scan'208";a="462158359" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.9.114]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 21 Jul 2020 10:38:55 -0700 Date: Tue, 21 Jul 2020 18:38:52 +0100 From: Bruce Richardson To: Ciara Power Cc: kevin.laatz@intel.com, dev@dpdk.org, john.mcnamara@intel.com, marko.kovacevic@intel.com Message-ID: <20200721173852.GK735@bricha3-MOBL.ger.corp.intel.com> References: <20200721160924.62082-1-ciara.power@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200721160924.62082-1-ciara.power@intel.com> Subject: Re: [dpdk-dev] [PATCH v2] doc: add more detail to telemetry guides X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jul 21, 2020 at 05:09:24PM +0100, Ciara Power wrote: > This patch adds examples to the Telemetry HowTo guide, to demonstrate > commands that use parameters. The programmer's guide is also modified to > include details on writing a callback function for a new command. > > Signed-off-by: Ciara Power > > --- > v2: > - Replaced examples of using commands in the programmer's guide with > a link to the HowTo guide. > - Added an example showing the use of a single string value. > - Replaced inline functions with a synthetic example function below > the list of parameters. > --- > doc/guides/howto/telemetry.rst | 46 ++++++- > doc/guides/prog_guide/telemetry_lib.rst | 172 ++++++++++++++++++++---- > 2 files changed, 187 insertions(+), 31 deletions(-) > Missed threading patch with v1, but content looks fine to me. Acked-by: Bruce Richardson