From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EF4B6A0526; Tue, 21 Jul 2020 16:59:17 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CFEFA1C000; Tue, 21 Jul 2020 16:59:17 +0200 (CEST) Received: from mail-lf1-f66.google.com (mail-lf1-f66.google.com [209.85.167.66]) by dpdk.org (Postfix) with ESMTP id BE50B1BFE7 for ; Tue, 21 Jul 2020 16:59:15 +0200 (CEST) Received: by mail-lf1-f66.google.com with SMTP id o4so11859117lfi.7 for ; Tue, 21 Jul 2020 07:59:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=jTnkZyF9N+vVdkd9pfIA+atbDc1100FUfEK+YCdF3K8=; b=Qq5PwgF6LrpGreU1fTDRQqHiHbnn8+hazQjDCCImVVqyZ3mvURLxhGbCaXFy8d2nvT IQpJizO9a4kLXs+hEGGb71NewwZMKktdoBDG1Ga0akUr5Q4jnmq0xehfdM8DksBMIZ79 mPeZFB7yaUxg9j0bfkFeMUYEtBakqW7lPLIeQzECGN2HSdlbmFLo/vj4uVKdx+JNQ11x JUfK3GK/en0rri0Ltz4lA+eGcYQrccZj5CqiYWdb0l24Aw99b+DOsPJQO2PAbsD3L1Q5 fyAnwjsoq7PRdvzjVO9l0ByTjWccxDvInVrwEcXFLRbXRI+D/Iw/aKFO+2xUcKIvdgN+ PZIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=jTnkZyF9N+vVdkd9pfIA+atbDc1100FUfEK+YCdF3K8=; b=r6acqX1NACzB0ZNCik1j8E879XU6m8ziWcZliqmuaNF0DH21OV/QKFKKX2SQEkP36f IbTAg9qVF3JrVGFC6sEP5ZeciweI8o0bisX8pITLisUFhIM0H6rt4gapixhOkjTHu4CF mLHljzOWva3t844wwGs6HxA8zOyCf/5Qszh8tkCyJ1AIJdBpwEy9W/iw1/9GS9sdkK6X y7qbiADMU4GZdBwVPyUgq4OjO35HP3PMupRen+G31q+CAK9AdW+lIgBVvu4LkgiTgqmz rX6ZZ1oeAHZ5MO5fRwXtCC5BMn+l5r1TbLP8Gxqt+jv467XEvGp/9AuRJRgCxI7YpLPM 3LhQ== X-Gm-Message-State: AOAM531lZgPJkk9Z6GoGiu9VNIBBhrtS1GAqmH/HcHVft3ONXgQG4dg4 +ziQgWiqSd6ylV4dvhTK/Kc= X-Google-Smtp-Source: ABdhPJwQk8EUpZvjAZUwPE+pLR38DpKuUFFzxM+NAojcUU9DnLER0V21hPFmmXxQPVSNrP8xXSx2Iw== X-Received: by 2002:a05:6512:3150:: with SMTP id s16mr13735424lfi.47.1595343555250; Tue, 21 Jul 2020 07:59:15 -0700 (PDT) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id h15sm4577911ljj.105.2020.07.21.07.59.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jul 2020 07:59:14 -0700 (PDT) Date: Tue, 21 Jul 2020 17:59:07 +0300 From: Dmitry Kozlyuk To: Bruce Richardson Cc: dev@dpdk.org, Neil Horman , Thomas Monjalon , robin.jarry@6wind.com, Jie Zhou , Tal Shnaiderman , Aaron Conole , Michael Santana Message-ID: <20200721175907.609ef040@sovereign> In-Reply-To: <20200721140411.GE735@bricha3-MOBL.ger.corp.intel.com> References: <20200708005355.7102-1-dmitry.kozliuk@gmail.com> <20200708212335.25338-1-dmitry.kozliuk@gmail.com> <20200708212335.25338-3-dmitry.kozliuk@gmail.com> <20200721140411.GE735@bricha3-MOBL.ger.corp.intel.com> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 2/4] build: use Python pmdinfogen X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 21 Jul 2020 15:04:11 +0100, Bruce Richardson wrote: > On Thu, Jul 09, 2020 at 12:23:33AM +0300, Dmitry Kozlyuk wrote: [snip] > > diff --git a/buildtools/gen-pmdinfo-cfile.sh b/buildtools/gen-pmdinfo-cfile.sh > > index 43059cf36..109ee461e 100755 > > --- a/buildtools/gen-pmdinfo-cfile.sh > > +++ b/buildtools/gen-pmdinfo-cfile.sh > > @@ -4,11 +4,11 @@ > > > > arfile=$1 > > output=$2 > > -pmdinfogen=$3 > > +shift 2 > > +pmdinfogen=$* > > > > # The generated file must not be empty if compiled in pedantic mode > > echo 'static __attribute__((unused)) const char *generator = "'$0'";' > $output > > for ofile in `ar t $arfile` ; do > > - ar p $arfile $ofile | $pmdinfogen - - >> $output 2> /dev/null > > + ar p $arfile $ofile | $pmdinfogen - - >> $output > > done > > -exit 0 > > For 20.11, since make build system is being removed, I think we should look > to merge this into the python script rather than having an extra layer of > wrapper and having meson pass the command from one script to another. > However, since out-of-the-box python doesn't seem to have support for > reading .a files, this is fine for now. Or Meson can only tell the Python script whether to process ELF of COFF and the path to an archiver tool (ar or lib.exe). This way we'd get rid of shell (which is non-portable to Windows) and need no libraries to read .a or .lib.