From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A34B8A0524; Mon, 27 Jul 2020 09:35:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1D6451BFE2; Mon, 27 Jul 2020 09:35:02 +0200 (CEST) Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by dpdk.org (Postfix) with ESMTP id D7C2C1BE90 for ; Mon, 27 Jul 2020 09:35:00 +0200 (CEST) Received: by mail-wm1-f65.google.com with SMTP id p14so12824966wmg.1 for ; Mon, 27 Jul 2020 00:35:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=8ccHOaaNUQjfU7MUkogPmzhhkam1RInJPA/deC1HUr8=; b=ZpGPqpLaScT37PQ2p5dbyfRV+8O/MhFOUlRyIuyaYKrtv/Ykva/VngctEO5MvDsdlt hW/bwq4Ks94+0FKoyI3fDNpVSyarW+KEhwPfq+yAEvEKZZrtZEwLb47tLA7DEyz+xxKn wR/EnvqsKYNi6GXUXNzll5hXAlXLrHTP+SCrASDUixjNrgMfI5Wzejen/lM9gc+E1V3Z RZi8/3dIVyrRn2cQQia4SM8hvhFDYOFBitu2ABJzEzUPaPmIb5jMR0YkR76rv44DOY77 30CrY2/BD/1g1RttgPRvBOy446bRfnI/exIFF1oPWUX/p+XL0CG9QqX9MP0q7kUyvx6o TdFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=8ccHOaaNUQjfU7MUkogPmzhhkam1RInJPA/deC1HUr8=; b=DUmoTN1ARceStiN++jAGyEj52cKfn7bIsvLpj6vDBCg8X5HPBqqi0f2cKbF1tfEl+x U/xsac/UN0EefzPiYmb+aWQWap2uaLzvrPpEOGqYroloSlAooxIk902XItfCB/Klp4DN h2BAJU8pSFejqhy5B2gul19upGHXI2mPqcXcKjIC301HN3tlr7Oui4aAGrPhZ8bd15tu XEk5UM77NuQrK5iVPGexIIfJS9F61h9cM4oXtrAJGfRn8G/iJyALByE6weSmM5GJNRMe xHcFhQBYMwceq/fO43p26AMJ/vLDYv09QLKg/G2eUKb7sEftSFxozmfjoBzcG4TT9lxm Kpag== X-Gm-Message-State: AOAM530r3cf/bsiG6WcjYw9a2TOf47TdkCqqzcuFl5NGZgkDDczfraME vm66zdi+TTzDIN0lhdP87QfeUg== X-Google-Smtp-Source: ABdhPJw1z1vnDGgTN3sco+tR4FW9bCtqGkNk91czonPRRi7HOHcKQ3VbEZghR8XwS+edxPPsTxmTNg== X-Received: by 2002:a1c:61d5:: with SMTP id v204mr17008276wmb.102.1595835300489; Mon, 27 Jul 2020 00:35:00 -0700 (PDT) Received: from 6wind.com (2a01cb0c0005a600345636f7e65ed1a0.ipv6.abo.wanadoo.fr. [2a01:cb0c:5:a600:3456:36f7:e65e:d1a0]) by smtp.gmail.com with ESMTPSA id j11sm11216356wrq.69.2020.07.27.00.34.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jul 2020 00:34:59 -0700 (PDT) Date: Mon, 27 Jul 2020 09:34:58 +0200 From: Olivier Matz To: Morten =?iso-8859-1?Q?Br=F8rup?= Cc: ferruh.yigit@intel.com, harry.van.haaren@intel.com, konstantin.ananyev@intel.com, jerinjacobk@gmail.com, dev@dpdk.org Message-ID: <20200727073458.GP5869@platinum> References: <20200626165135.119557-1-mb@smartsharesystems.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200626165135.119557-1-mb@smartsharesystems.com> User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH] net: rte_ether minor optimizations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Jun 26, 2020 at 06:51:35PM +0200, Morten Brørup wrote: > * rte_is_broadcast_ether_addr(): > Use binary logic instead of comparisons and boolean logic, thus reducing > the number of branches. > It now resembles rte_is_zero_ether_addr(). > > * rte_ether_addr_copy(): > The source code modifications were discussed on the mailing list: > http://mails.dpdk.org/archives/dev/2020-June/171584.html > Remove obsolete ICC-specific code and related comment. > Restrict pointer aliasing (suggested by Jerin Jacob). > Remove superfluous "Fast" from function description headline; all DPDK > data plane functions are supposed to be fast. > > Signed-off-by: Morten Brørup Acked-by: Olivier Matz