From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 2C3DCA053E;
	Mon, 27 Jul 2020 20:53:03 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 106482B9C;
	Mon, 27 Jul 2020 20:53:03 +0200 (CEST)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by dpdk.org (Postfix) with ESMTP id 546BA1023
 for <dev@dpdk.org>; Mon, 27 Jul 2020 20:53:01 +0200 (CEST)
Received: by linux.microsoft.com (Postfix, from userid 1059)
 id 95C0620B4908; Mon, 27 Jul 2020 11:53:00 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 95C0620B4908
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1595875980;
 bh=+1YE9zjhbWnMouM/6S68HqYumktum9AvK/vNZAoFJcQ=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=c3irquiEtaMFGgr1JOazpnDUlx1rHZyHdViLfyhGDXuUqogVJOs34UFBh+2VdiHOc
 tSoSk8+5h3LyJzoZeqhXX0XTjMmBCpjmrmwKptLfvOCv2o3ej65Z1BsZ+/M86SJxuL
 zlUfJzGpFNjgOhEtaHlsE7BztgElXxN6rILqCm4E=
Date: Mon, 27 Jul 2020 11:53:00 -0700
From: Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>
To: Fady Bader <fady@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>,
 Tasnim Bashar <tbashar@mellanox.com>,
 Tal Shnaiderman <talshn@mellanox.com>, Yohad Tor <yohadt@mellanox.com>,
 "dmitry.kozliuk@gmail.com" <dmitry.kozliuk@gmail.com>,
 "harini.ramakrishnan@microsoft.com" <harini.ramakrishnan@microsoft.com>,
 "ocardona@microsoft.com" <ocardona@microsoft.com>,
 "ranjit.menon@intel.com" <ranjit.menon@intel.com>,
 "pallavi.kadam@intel.com" <pallavi.kadam@intel.com>,
 "kevin.laatz@intel.com" <kevin.laatz@intel.com>,
 "ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
 "arybchenko@solarflare.com" <arybchenko@solarflare.com>,
 "ciara.power@intel.com" <ciara.power@intel.com>
Message-ID: <20200727185300.GA35876@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <20200625133038.25180-2-fady@mellanox.com>
 <20200628105851.14916-1-fady@mellanox.com>
 <VI1PR05MB5872E81F14613EE05A7D312ABF750@VI1PR05MB5872.eurprd05.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <VI1PR05MB5872E81F14613EE05A7D312ABF750@VI1PR05MB5872.eurprd05.prod.outlook.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Subject: Re: [dpdk-dev] [PATCH v2 0/5] compiling ethdev lib under windows
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Sun, Jul 26, 2020 at 09:24:26AM +0000, Fady Bader wrote:
> Hi Narcisa,
> I saw that the net patch was acked, can you also review this patch too to see if more work should be done.
> 
Hi Fady,

Yes, I will look at it.

> Thanks,
> Fady
> 
> 
> > -----Original Message-----
> > From: Fady Bader <fady@mellanox.com>
> > Sent: Sunday, June 28, 2020 1:59 PM
> > To: dev@dpdk.org
> > Cc: Fady Bader <fady@mellanox.com>; Thomas Monjalon
> > <thomas@monjalon.net>; Tasnim Bashar <tbashar@mellanox.com>; Tal
> > Shnaiderman <talshn@mellanox.com>; Yohad Tor <yohadt@mellanox.com>;
> > dmitry.kozliuk@gmail.com; harini.ramakrishnan@microsoft.com;
> > ocardona@microsoft.com; ranjit.menon@intel.com; pallavi.kadam@intel.com;
> > kevin.laatz@intel.com; ferruh.yigit@intel.com; arybchenko@solarflare.com;
> > ciara.power@intel.com
> > Subject: [PATCH v2 0/5] compiling ethdev lib under windows
> > 
> > Added needed changes in order to get ethdev compiling under windows.
> > 
> > Depends-on: series-10382 ("compile librte_net for windows")
> > 
> > v2: fixed logging issue in telemetry lib.
> > 
> > Fady Bader (5):
> >   eal: added interrupts empty stubs
> >   eal: updated export list for Windows
> >   ethdev: remove structs from export list
> >   telemetry: implement empty stubs for Windows
> >   ethdev: compiling ethdev under Windows
> > 
> >  lib/librte_eal/rte_eal_exports.def       | 10 +++++++
> >  lib/librte_eal/windows/eal_interrupts.c  | 17 +++++++++++
> >  lib/librte_eal/windows/meson.build       |  1 +
> >  lib/librte_ethdev/rte_ethdev_version.map |  2 --
> >  lib/librte_telemetry/rte_telemetry.h     |  4 +++
> >  lib/librte_telemetry/telemetry.c         | 51
> > +++++++++++++++++++++++++++++++-
> >  lib/librte_telemetry/telemetry_legacy.c  | 26 +++++++++++++++-
> >  lib/meson.build                          |  7 +++--
> >  8 files changed, 112 insertions(+), 6 deletions(-)  create mode 100644
> > lib/librte_eal/windows/eal_interrupts.c
> > 
> > --
> > 2.16.1.windows.4