From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6D508A052B; Tue, 28 Jul 2020 10:57:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 485B71BE8A; Tue, 28 Jul 2020 10:57:15 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 2DB401BE8A for ; Tue, 28 Jul 2020 10:57:13 +0200 (CEST) IronPort-SDR: Cfo8qf7LN/fT8sJ+4ojm6KhV0wqOVbOj8LwiQ7nbquKSQkx6Wh3v08xyZPJnkuqKQaeD0ya4ax OC/fHDJmY2mw== X-IronPort-AV: E=McAfee;i="6000,8403,9695"; a="236035835" X-IronPort-AV: E=Sophos;i="5.75,405,1589266800"; d="scan'208";a="236035835" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jul 2020 01:57:12 -0700 IronPort-SDR: +RyjW+swGewKRA0311xaPfpXUQ7hNLgUgcpFpIocyHYqN8IRdzrbFP/pSrGyNNxXRunsMWCEBh lGf4Qds+3vhQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,405,1589266800"; d="scan'208";a="312535999" Received: from dpdk-yyzhang2.sh.intel.com ([10.67.117.186]) by fmsmga004.fm.intel.com with ESMTP; 28 Jul 2020 01:57:10 -0700 From: Yuying Zhang To: dev@dpdk.org, olivier.matz@6wind.com, qi.z.zhang@intel.com, qiming.yang@intel.com Cc: Yuying Zhang Date: Tue, 28 Jul 2020 08:55:31 +0000 Message-Id: <20200728085531.204296-1-yuying.zhang@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v1] net: fix TSO packet checksum incorrect X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The ol_flags check lacks of PKT_TX_IPV6 which causes checksum flag configuration error while IPv6/TCP TSO packet is sent. This patch fixes the issue using PKT_TX_OFFLOAD_MASK. Fixes: 520059a41aa9 ("net: check fragmented headers in non-debug as well") Signed-off-by: Yuying Zhang --- lib/librte_net/rte_net.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_net/rte_net.h b/lib/librte_net/rte_net.h index 1edc283a4..4b617ab4c 100644 --- a/lib/librte_net/rte_net.h +++ b/lib/librte_net/rte_net.h @@ -125,7 +125,7 @@ rte_net_intel_cksum_flags_prepare(struct rte_mbuf *m, uint64_t ol_flags) * Mainly it is required to avoid fragmented headers check if * no offloads are requested. */ - if (!(ol_flags & (PKT_TX_IP_CKSUM | PKT_TX_L4_MASK))) + if (!(ol_flags & PKT_TX_OFFLOAD_MASK)) return 0; if (ol_flags & (PKT_TX_OUTER_IPV4 | PKT_TX_OUTER_IPV6)) -- 2.25.1