From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 82B0AA052B; Tue, 28 Jul 2020 21:59:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 576DF2B86; Tue, 28 Jul 2020 21:59:33 +0200 (CEST) Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com [209.85.214.196]) by dpdk.org (Postfix) with ESMTP id 24DEEE07 for ; Tue, 28 Jul 2020 21:59:32 +0200 (CEST) Received: by mail-pl1-f196.google.com with SMTP id k4so10523230pld.12 for ; Tue, 28 Jul 2020 12:59:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=C1ThJHggzkdE54l5t1gEuGGS9u97vx/kvPkLpQy1Uz8=; b=sQykncUT6O/6wCvCMKDUgAwPyw97ayRemXrQMv6+JKoqcDLNVOZOMKCFXnv33BYNrD aMLL9N4yFfYaNIRsepvhEzEGtU6/kiz82vXAB+qqCd2Vq4NKxV3og0Ey3lAVUNxWAgH3 4x7k7BoNElYEef9D6hIYstJl2DY5RKEz2xKUr9RF0kJRGqPfIHRwnpIcYIxd06xfJu1+ 9UVZdojODQeXlFMYkrsgZ+90WkfEWnIKzF6WaOTy0nM5dolZYSbq+lA1vMBlQKbagbs9 g+IYWywEWAp5waA2lPCRRUORSaESqB0IkI/MgzOLZELdAHiK57UMGdwkMVeQoIr8Y/6I zpJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=C1ThJHggzkdE54l5t1gEuGGS9u97vx/kvPkLpQy1Uz8=; b=qGh5f3+4S248Hdxv+RNfjl/3CWUusk+u8r4yNOFwYrPO5i525pFJg1dafXOwLspZ0G 5lx66FiRcBMhxz5bNWVOMRmqdPMtl+AmZJFYPR9ERDySpCHGnCkTpohk3dp4tF3LA0+y bRVWp3JCV6oo2Ud57mo3KbRI1GBTupLKfBfL8u0wFcblHL6Q4QcoJ4QZNT8kHxEtZg12 oke0dePa+ISNlLxIlATE7PwQHeGT9+2rT8SvQbDZ7LiuVXKoMOOuHqbiYo40pIAU5l5R prMwjf4GxUL/1OZA6oA57DONBNOsn4KpQSZK1C7I9GgSsGGXoFOkkkHgEO66GkU9A/Ai D4Zw== X-Gm-Message-State: AOAM531I7GVL60V/sKCcJpMClGG5iNRaWO52C7Gu/fEQH3Nx0QwKZzZx k/g78tA/I+OQzc252loLONTNnw== X-Google-Smtp-Source: ABdhPJzbmyLw9gCGGVyZpmE6lsUUJyvtrsJ7IOXJVv0GJ1O6YkjM9C5HJYLy8IhFN2xnJnnCwlxITw== X-Received: by 2002:a17:90a:20af:: with SMTP id f44mr1191877pjg.169.1595966371248; Tue, 28 Jul 2020 12:59:31 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id y69sm6760757pfc.111.2020.07.28.12.59.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jul 2020 12:59:30 -0700 (PDT) Date: Tue, 28 Jul 2020 12:59:22 -0700 From: Stephen Hemminger To: Bruce Richardson Cc: Anatoly Burakov , dev@dpdk.org, remy.horton@intel.com, ciara.power@intel.com Message-ID: <20200728125922.7bf9082a@hermes.lan> In-Reply-To: <20200728102458.GA2333@bricha3-MOBL.ger.corp.intel.com> References: <20200702172852.6201-1-stephen@networkplumber.org> <20200728102458.GA2333@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] metrics: make number of metrics names configurable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 28 Jul 2020 11:24:58 +0100 Bruce Richardson wrote: > On Thu, Jul 02, 2020 at 10:28:52AM -0700, Stephen Hemminger wrote: > > The maximum number of metrics is hardcoded at 256. > > This severely limits the usefulness of the library. > > It should be configurable like other limits in DPDK. > > > > Fixes: 349950ddb9c5 ("metrics: add information metrics library") > > Cc: remy.horton@intel.com > > Cc: ciara.power@intel.com > > Signed-off-by: Stephen Hemminger > > --- > > config/common_base | 1 + > > config/meson.build | 2 +- > > lib/librte_metrics/rte_metrics.h | 1 - > > 3 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/config/common_base b/config/common_base > > index fe30c515e5a3..f0212faec80c 100644 > > --- a/config/common_base > > +++ b/config/common_base > > @@ -917,6 +917,7 @@ CONFIG_RTE_LIBRTE_JOBSTATS=y > > # Compile the device metrics library > > # > > CONFIG_RTE_LIBRTE_METRICS=y > > +CONFIG_RTE_METRICS_MAX_METRICS=256 > > > > # > > # Compile the bitrate statistics library > > diff --git a/config/meson.build b/config/meson.build > > index 351e268c1f5b..cc8cb8fbf2f0 100644 > > --- a/config/meson.build > > +++ b/config/meson.build > > @@ -238,7 +238,7 @@ dpdk_conf.set('RTE_ENABLE_TRACE_FP', get_option('enable_trace_fp')) > > dpdk_conf.set('RTE_MAX_VFIO_GROUPS', 64) > > dpdk_conf.set('RTE_DRIVER_MEMPOOL_BUCKET_SIZE_KB', 64) > > dpdk_conf.set('RTE_LIBRTE_DPAA2_USE_PHYS_IOVA', true) > > - > > +dpdk_conf.set('RTE_METRICS_MAX_METRICS', 256) > > > > The meson.build file should really just be used for computed values, I > think. For build-time constants like this it's probably better put in > config/rte_config.h file. config/rte_config.h is generated isn't it?