From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 824BEA052B; Wed, 29 Jul 2020 15:58:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1C462F04; Wed, 29 Jul 2020 15:58:51 +0200 (CEST) Received: from mail-qt1-f194.google.com (mail-qt1-f194.google.com [209.85.160.194]) by dpdk.org (Postfix) with ESMTP id 4ACB02AB; Wed, 29 Jul 2020 15:58:50 +0200 (CEST) Received: by mail-qt1-f194.google.com with SMTP id s23so17625934qtq.12; Wed, 29 Jul 2020 06:58:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=YWWtF9L+tHUiKVjB5e3yAMALTNBWLknYlfvwMBGmF+0=; b=aJ/yL8BwIvlJn1sPFyj9rhGvO6Mk/wiPy+bPLECZuFOmi9/D861MKIO7/qHXoH4Xgy 5Lm9naQKYSeUG+7eOXd2WpyOVJDOsPAxgFrWQDsehaboF3iVZAH4Ik60Lx8Pa6CtsgqQ WWN/Rld4DrmMK6hKtdDOh7nL+8DgITXorPBya5lUBASaI9tomAX32MXUFRMMwakNVcZ4 QF6QMDs+cqruYOrwlOwS5zy/XCIg6LVgwwKuZhRup+Q9fA+Uo0W5gmUCdlxe4qQTNMP3 UM6+LLnCsCCwcgv3Idfoy8hLWOJWvvaYk0ZSdjdyUqbZqeiWWFzy9+6AcCKsP8BXLHc/ mzRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=YWWtF9L+tHUiKVjB5e3yAMALTNBWLknYlfvwMBGmF+0=; b=p7x0CGBH0E2QXUmVno9AatTko3qeS8pYnHVY4u/PbNXswqQ1uXKCNZNc/eHOuERg9r WQpCjd3jWhDlpC8L9lXwn9wlNMwm+BIE5DULLrWzu/la4Clh+u95R2XHAXwReu2i2SqM Z/FlW33g2w7N9M5R+Rk//wLfC4vfVls+7G6LVqSb+f14wKXGtdxqzhPAzuiDZxrsenAg sGYTqxnPL87Xg59gKBlM9iMw8T8b8HicCysbbm7UsuNV12soHJjYnios1E+lDU+lOGIq mdRKeN5DKzUtJQa54xUC08Kk0HGcc4QCHQPTL7msbZXvIw8NwgYVu0JHUzEqI/iqr+Ag imFQ== X-Gm-Message-State: AOAM530uGncMO4ntBKxztaD9TJQ0w4pcW5HGL6x17rsOrMIcPWjjbTDG BCBBVE+4jtZ03KL80Je1Are6mnqA X-Google-Smtp-Source: ABdhPJx1ZFuPiWaoWdl1J8oiiZQatHkJG3bcnjgH9fBb6Gwt50lGL3nkEYh0l0pIb8htv1AyqIoqiQ== X-Received: by 2002:aed:2ae2:: with SMTP id t89mr15744568qtd.171.1596031129560; Wed, 29 Jul 2020 06:58:49 -0700 (PDT) Received: from monolith.fios-router.home (pool-96-255-60-31.washdc.fios.verizon.net. [96.255.60.31]) by smtp.googlemail.com with ESMTPSA id t12sm1521861qkt.56.2020.07.29.06.58.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jul 2020 06:58:49 -0700 (PDT) From: Chas Williams <3chas3@gmail.com> To: dev@dpdk.org Cc: sthemmin@microsoft.com, kys@microsoft.com, haiyangz@microsoft.com, longli@microsoft.com, Chas Williams <3chas3@gmail.com>, stable@dpdk.org Date: Wed, 29 Jul 2020 09:58:44 -0400 Message-Id: <20200729135844.16689-1-3chas3@gmail.com> X-Mailer: git-send-email 2.21.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH] net/netvsc: fix seg fault during transmit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Commit cc0251813277 ("net/netvsc: split send buffers from Tx descriptors") changed the way that transmit descriptors are allocated. They come from a single pool instead of being individually attached to each mbuf. To find the IOVA, you need to calculate the offset from the base of the pool. Fixes: cc0251813277 ("net/netvsc: split send buffers from Tx descriptors") Cc: stable@dpdk.org Signed-off-by: Chas Williams <3chas3@gmail.com> --- drivers/net/netvsc/hn_rxtx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/netvsc/hn_rxtx.c b/drivers/net/netvsc/hn_rxtx.c index 86a4c0d74..0428c586a 100644 --- a/drivers/net/netvsc/hn_rxtx.c +++ b/drivers/net/netvsc/hn_rxtx.c @@ -1421,11 +1421,12 @@ static int hn_xmit_sg(struct hn_tx_queue *txq, hn_rndis_dump(txd->rndis_pkt); /* pass IOVA of rndis header in first segment */ - addr = rte_malloc_virt2iova(txd->rndis_pkt); + addr = rte_malloc_virt2iova(txq->tx_rndis); if (unlikely(addr == RTE_BAD_IOVA)) { PMD_DRV_LOG(ERR, "RNDIS transmit can not get iova"); return -EINVAL; } + addr = addr + ((char *)txd->rndis_pkt - (char *)txq->tx_rndis); sg[0].page = addr / PAGE_SIZE; sg[0].ofs = addr & PAGE_MASK; -- 2.21.3