From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 22E5CA052B; Thu, 30 Jul 2020 05:28:16 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 85C27E07; Thu, 30 Jul 2020 05:28:14 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 890B2A3 for ; Thu, 30 Jul 2020 05:28:12 +0200 (CEST) IronPort-SDR: lYWNG2BHX/psTPog9kWsAa0OAQKNNJQAD3WvX27crmSanN9JceBnJXnU3AaDjSK4FDpaKy1qr0 BdZT8o3w9n/g== X-IronPort-AV: E=McAfee;i="6000,8403,9697"; a="131601496" X-IronPort-AV: E=Sophos;i="5.75,412,1589266800"; d="scan'208";a="131601496" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jul 2020 20:28:11 -0700 IronPort-SDR: Demap9/LgsKzCDHhNMbnD+Dw3CYTHjhNRqGXMvzqFAr1cEtUYhpnlDhVTuLEBoF0GoAVuqVbm1 tk7de2mLPbFQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,412,1589266800"; d="scan'208";a="286721019" Received: from npg-dpdk-patrickfu-casc2.sh.intel.com ([10.67.119.92]) by orsmga003.jf.intel.com with ESMTP; 29 Jul 2020 20:28:07 -0700 From: Patrick Fu To: dev@dpdk.org Cc: thomas@monjalon.net, ferruh.yigit@intel.com, maxime.coquelin@redhat.com, bruce.richardson@intel.com, zhihong.wang@intel.com, liang-min.wang@intel.com, konstantin.ananyev@intel.com, timothy.miskell@intel.com, cunming.liang@intel.com, patrick.fu@intel.com Date: Thu, 30 Jul 2020 11:23:32 +0800 Message-Id: <20200730032332.3742259-1-patrick.fu@intel.com> X-Mailer: git-send-email 2.18.4 Subject: [dpdk-dev] [RFC] lib: introduce traffic mirroring API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Network Test Access Point (TAP) is the network monitoring service commonly adotpted in SDN-based network infrastructures. When VMs are inter-connected over virtual switches, TAP requires vSwitch to mirror out network traffics from specific workload VM ports to the TAP device/VM ports. Classical mirroring impmentations in vSwitch make an extra copy of the source packets, which results in significant degradation in the throughput levels vSwitch could normally archieve. Therefore, we propose a new set of APIs to support high-throughput packet mirroring through hardware offloading. The proposal is consisted of three major parts: - Mirror registration APIs - Mirror offload/customization callbacks - Shared mirror data path In this proposal, mirroring happens between a pair of ethdev ports (one for the source port and the other for the mirror port), which is configurable on a per-port per-direction basis. i.e. applications invoke the mirroring API to register source ports and traffic directions (tx or rx). The registration API will then attach the mirror data path to the source port as a standard ethdev tx or rx callback. If any custom mirror offload functions are specified by applications, the offload function will be executed within the mirror data path. The mirror data path intercepts the packets flowing over the registered source ports and, rather than doing extra packets copy operations, simply transmits packets to the destination (mirror) port with an incremented mbuf reference count. In this way, an identical copy of the packet data is transmitted to both the mirror port and the original traffic destination. In addition, with the proposed APIs we can implement even more complicated mirrorings scenarios. Two examples include flow based mirroring and MAC address matching, both of which have common usage within the industry. Mirror registration API proto-types are defined as follows: int rte_mirror_register(uint16_t src_port, struct rte_mirror_param *param); int rte_mirror_unregister(uint16_t src_port); struct rte_mirror_param contains all of the parameters the mirror data path will use, e.g. the mirror port number, the source traffic direction to be mirrored, the custom mirroring offload function pointer, the application context, etc. Notablely, applications should passdown a spinlock through this structure, which is used to synchronize the packet data access between application and the mirror data path. Our prior studies demonstrate that this methedology is capble of doubling the mirroring performance as compared to the default OVS port mirroring performance (refer to the paper in IEEE xplore for further details: https://ieeexplore.ieee.org/document/9110293) An OVS implementation was also suggested to the OVS community for review and comments (refer to the following OVS RFC patch: https://patchwork.ozlabs.org/project/openvswitch/patch/ 1595596858-78846-2-git-send-email-emma.finn@intel.com/) We are considering implementing the mirroring APIs as a standalone library in DPDK, but it's also reasonble to place it inside ethdev layer or within the vhost-pmd considering the potential usage scenarios. Signed-off-by: Liang-min Wang Signed-off-by: Patrick Fu Signed-off-by: Timothy Miskell