From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 22FA3A052B; Thu, 30 Jul 2020 10:42:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A249511A2; Thu, 30 Jul 2020 10:42:18 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id D0451255 for ; Thu, 30 Jul 2020 10:42:16 +0200 (CEST) IronPort-SDR: pc2XwPXHrgekKZVTW8o4HkkCglX41EobggiNvaEQNtUXGMfztqedQFbNOU9OBptYbYTZPGeOwV T3eybXUCOHBw== X-IronPort-AV: E=McAfee;i="6000,8403,9697"; a="236425862" X-IronPort-AV: E=Sophos;i="5.75,413,1589266800"; d="scan'208";a="236425862" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jul 2020 01:42:15 -0700 IronPort-SDR: taFOjCjcNXeAbZxbIjFuCoeFDX2h/f+dsN0IzftTUyQTLQmo/+FHFbPDzYTb8RvrcsUEGneCps mebo790JlA3w== X-IronPort-AV: E=Sophos;i="5.75,413,1589266800"; d="scan'208";a="465170025" Received: from bricha3-mobl.ger.corp.intel.com ([10.249.40.75]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 30 Jul 2020 01:42:14 -0700 Date: Thu, 30 Jul 2020 09:42:10 +0100 From: Bruce Richardson To: Stephen Hemminger Cc: dev@dpdk.org Message-ID: <20200730084210.GA241@bricha3-MOBL.ger.corp.intel.com> References: <20200604210200.25405-1-stephen@networkplumber.org> <20200730005804.19251-1-stephen@networkplumber.org> <20200730005804.19251-2-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200730005804.19251-2-stephen@networkplumber.org> Subject: Re: [dpdk-dev] [PATCH v2 20.08 1/6] doc: announce deprecation of master lcore X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jul 29, 2020 at 05:57:59PM -0700, Stephen Hemminger wrote: > Announce upcoming changes related to master/slave in reference > to lcore. > > Signed-off-by: Stephen Hemminger > --- > doc/guides/rel_notes/deprecation.rst | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > index 99c98062ffc2..7c60779f3e68 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -148,3 +148,20 @@ Deprecation Notices > Python 2 support will be completely removed in 20.11. > In 20.08, explicit deprecation warnings will be displayed when running > scripts with Python 2. > + > +* eal: To be more inclusive in choice of naming, the DPDK project > + will replace uses of master/slave in the API's and command line arguments. > + > + References to master/slave in relation to lcore will be renamed > + to initial/worker. The function ``rte_get_master_lcore()`` > + will be renamed to ``rte_get_initial_lcore()``. > + For the 20.11, release both names will be present and the > + old function will be marked with the deprecated tag. > + The old function will be removed in 21.11 version. Since 20.11 is going to be ABI incompatible with previous versions anyway, can we not have the function as a macro alias for the new, allowing us to remove the old sooner without breaking any apps? Even if this is not the case, I think it might be better to change "21.11 version" to "a future release" to allow us some flexibility on when to remove them in case we can remove them sooner. > + > + The iterator for worker lcores will also change: > + ``RTE_LCORE_FOREACH_SLAVE`` will be replaced with > + ``RTE_LCORE_FOREACH_WORKER``. > + > + The ``master-lcore`` argument to testpmd will be replaced > + with ``initial-lcore``. > -- With the above comment. Acked-by: Bruce Richardson