From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 31CA2A052B; Fri, 31 Jul 2020 14:55:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 08EB41C002; Fri, 31 Jul 2020 14:55:19 +0200 (CEST) Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by dpdk.org (Postfix) with ESMTP id 43B481BFFD for ; Fri, 31 Jul 2020 14:55:18 +0200 (CEST) Received: by mail-wm1-f67.google.com with SMTP id q76so7929734wme.4 for ; Fri, 31 Jul 2020 05:55:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=eNqN0FXs9P3XBQf7G1GeUXyPa100mAcFRrpaun8LHdk=; b=NiOGi6vQk+i6RaBXe2FS2O3qsSpVS9n3wNymd+ZTSvg4p6iZ8POGS2kiRlpk5N4xiO 1GKWKewxZqfZ45fmqot1GCKvCVcvCD3rOFLjwYSEviOJ15BkSjhKGKrcb1icCXWpUS7h PU6Y1UKiwKE63UFDEHuUY5zqxaO63eDTpYB0a54+bLSs5ftJ1EDYf8GB8tXbKnnW+U95 GBp6NCjSZnQsByubYQrtab1dVy1B9klOrhNBCcqS7eTFCoeWCKaGeraLKb0rX127eF12 9OGCCbRkcKksQb4OvLc33xGDQ0JbSA8BjO0Ev0eXQzDW+cIFbEd2zKWXPyNeJZFtSqUb Nd2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=eNqN0FXs9P3XBQf7G1GeUXyPa100mAcFRrpaun8LHdk=; b=ZBxlyppwBk7IWXz8Kflp7n0RnSsKPi/ZEB8GtSms5YR7Wd23/GLstEyqG2G57C+Fue NZ17RQg0AYarCkEUD93qX9+QNOsDAu/lMCaYVNPUNGMtpTw2N/6J24IbswgQL2Z6jgqK XKJajjyoCUSaaU1CSLfbDp5ARHlDW535NmMU/DxaxtbH0KZvFv2adYud0VLED8LSFjGY su3I0m8Lin+VJzYMLa3OHRbJTYT6BrMya+ASinG9u9fDkDU1AbxQ8bDblJmWIQ23b3gB AfPahIRp5QaNSfrB/7QDKksZpPWpX5fCd58SN6mvr9/m6x04OqLPQO2Dc4gVluoN5vea +Vng== X-Gm-Message-State: AOAM532swH4CCcbLNaEWhefD7WxzzOx7PcgdtnS1F2zPbz9/j8Sh6GG7 1tSidDhVRAw+IaoWKPtudIMfOw== X-Google-Smtp-Source: ABdhPJzWHX1WPqpHk2MEgm3IJKyZ/EuPXAImbjarJB0PL8XlUC4ZblJC4pf76inXXI6LlI0pIkvh0w== X-Received: by 2002:a7b:cb46:: with SMTP id v6mr4043187wmj.73.1596200117987; Fri, 31 Jul 2020 05:55:17 -0700 (PDT) Received: from 6wind.com (2a01cb0c0005a600345636f7e65ed1a0.ipv6.abo.wanadoo.fr. [2a01:cb0c:5:a600:3456:36f7:e65e:d1a0]) by smtp.gmail.com with ESMTPSA id x204sm20698907wmg.2.2020.07.31.05.55.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2020 05:55:17 -0700 (PDT) Date: Fri, 31 Jul 2020 14:55:16 +0200 From: Olivier Matz To: David Marchand Cc: Wisam Jaddo , dev , Raslan , Thomas Monjalon , "Iremonger, Bernard" , dpdk stable Message-ID: <20200731125516.GG5869@platinum> References: <1582204709-7992-1-git-send-email-wisamm@mellanox.com> <1582210386-27331-1-git-send-email-wisamm@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH v3] cmdline: increase maximum line length X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Ressurecting this old thread. On Sat, Feb 22, 2020 at 04:28:15PM +0100, David Marchand wrote: > This patch is flagged as an ABI breakage: > https://travis-ci.com/ovsrobot/dpdk/jobs/289313318#L2273 > In case we want this fix for 20.11, should we do a deprecation notice in 20.08? Olivier > > On Thu, Feb 20, 2020 at 3:53 PM Wisam Jaddo wrote: > > > > This increase due to the usage of cmdline in dpdk applications > > as config commands such as testpmd do for rte_flow rules creation. > > > > The current size of buffer is not enough to fill > > many cases of rte_flow commands validation/creation. > > > > rte_flow now can have outer items, inner items, modify > > actions, meta data actions, duplicate action, fate action and > > more in one single rte flow, thus 512 char will not be enough > > to validate such rte flow rules. > > > > Such change shouldn't affect the memory since the cmdline > > reading again using the same buffer. > > I don't get your point here. > > > > Cc: stable@dpdk.org > > This is not a fix. > > > -- > David Marchand >