From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4DF88A053A; Tue, 4 Aug 2020 18:22:16 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B742F2BB5; Tue, 4 Aug 2020 18:22:15 +0200 (CEST) Received: from mail-pl1-f193.google.com (mail-pl1-f193.google.com [209.85.214.193]) by dpdk.org (Postfix) with ESMTP id C7A2D29D2 for ; Tue, 4 Aug 2020 18:22:13 +0200 (CEST) Received: by mail-pl1-f193.google.com with SMTP id t10so17945685plz.10 for ; Tue, 04 Aug 2020 09:22:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Q45vAUBZR/c9y+RmLJu6H3KOtcbtOsjdFqkzPAckRoY=; b=e8nW2dZmuooVs7GnPO3xDnBNY6kGRxFeRQ+nHGKjYEBdIcfppgHRqCAtfKUL37G0F1 LCI2zBXqkh84U8ixjzwAjNp7Idzp0YpiERexDO+873erP56Gk8eSqowq6i3QjZrnm8x/ SLY0nO4X9SDzy0bfc7FIrDJA3TaYMXc5QE7JvZOJw/DuaJ/IYKc30UZ1w81YMPCC1vaA m9zt6UjEqM86+ydTX+QIW56or0t92tEXeZFmpo3zcb9PGV1eCwvGdjeHgSeVdfsZ2irf 7CxbeHSdMhpqQkRB4vsTXfLBbJNN9zGmGaeETpBjBy4+KaQapaF9o+/ftUR9L8eKvm7r 9p6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Q45vAUBZR/c9y+RmLJu6H3KOtcbtOsjdFqkzPAckRoY=; b=SP3unKa1pS2gQbcmf+jqIkN9xCo3MXPyvXWvSZp/nvYJ47HqKTvRwgKsvx1/gxsxii GRsJpjdHROCDPKaH9yyQMLwyV6+MzqxKRjlGT9bn5ygsLiQ/Rm7ytRj0OEnpHCQopQ6r 81FlJm/WpDVlPh1ZllHU9sA8RtXNquVnEydE3d7zISIdA1Dytkt7cgwkmUxP342U5hDp EBEMsQ5mwzFfezLr0JWL74uh1Obq1i5/t5wpnKak1DexKnFddLyfo8HVsnFWCeP0vIOX 243FWKhI7AMCgTUTknwJkgPJaGcnDOMkWC1lj5NGn99COioZQDXjw9jHT6kwaf0oL4ny OF3A== X-Gm-Message-State: AOAM531gG1gklFXlEePKPddcMuc7wJHVEMWI2hwFvGdtiJVKswybGxTU vHbrCgD6V7QBldrh2mu8oN7Gkw== X-Google-Smtp-Source: ABdhPJxvJo1jUm6C9E9dLp92syfO40tO/lK29txjhUUlvncJtYjDaN93a2SHRBro7T7obhKiNpHjtw== X-Received: by 2002:a17:90a:d986:: with SMTP id d6mr4760660pjv.134.1596558132840; Tue, 04 Aug 2020 09:22:12 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id n9sm3185130pjo.53.2020.08.04.09.22.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2020 09:22:12 -0700 (PDT) Date: Tue, 4 Aug 2020 09:22:09 -0700 From: Stephen Hemminger To: Dekel Peled Cc: ferruh.yigit@intel.com, arybchenko@solarflare.com, orika@mellanox.com, thomas@monjalon.net, asafp@mellanox.com, matan@mellanox.com, elibr@mellanox.com, dev@dpdk.org Message-ID: <20200804092209.1d68e8c2@hermes.lan> In-Reply-To: <6e8b7c61a92b51749b11ac3bfae5c0201352f9b3.1596550675.git.dekelp@mellanox.com> References: <6e8b7c61a92b51749b11ac3bfae5c0201352f9b3.1596550675.git.dekelp@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC] ethdev: add VLAN attributes to ETH item X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 4 Aug 2020 18:36:20 +0300 Dekel Peled wrote: > In existing code the match on tagged/untagged packets is not explicit. > Recent documentation update [1] describes the different patterns and > clarifies the intended use of different patterns. > > This patch proposes an update to ETH item struct, to clearly define the > required characteristic of a packet, and enable precise match criteria. > > [1] http://mails.dpdk.org/archives/dev/2020-May/166257.html > > Signed-off-by: Dekel Peled > --- > lib/librte_ethdev/rte_flow.h | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h > index cf0eccb..345feb5 100644 > --- a/lib/librte_ethdev/rte_flow.h > +++ b/lib/librte_ethdev/rte_flow.h > @@ -726,11 +726,20 @@ struct rte_flow_item_raw { > * If the @p ETH item is the only item in the pattern, and the @p type field > * is not specified, then both tagged and untagged packets will match the > * pattern. > + * The fields @p cvlan_exist and @p svlan_exist can be used to match specific > + * packet types, instead of using the @p type field. This can be used to match > + * on packets that do/don't contain either cvlan, svlan, or both. > + * The field @p num_of_vlans can be used to match packets by the exact number > + * of VLANs in header. > */ > struct rte_flow_item_eth { > struct rte_ether_addr dst; /**< Destination MAC. */ > struct rte_ether_addr src; /**< Source MAC. */ > rte_be16_t type; /**< EtherType or TPID. */ > + uint32_t cvlan_exist:1; /**< C-tag VLAN exist in header. */ > + uint32_t svlan_exist:1; /**< S-tag VLAN exist in header. */ > + uint32_t reserved:14; /**< Reserved, must be zero. */ > + uint32_t num_of_vlans:16; /**< Number of VLANs in header. */ > }; > > /** Default mask for RTE_FLOW_ITEM_TYPE_ETH. */ You are making life easy for you but harder for existing users of flow_item_eth API. Why not add new flow_item for vlan and handle multiple levels there.