From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2BBACA053A; Tue, 4 Aug 2020 13:20:23 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 68315F04; Tue, 4 Aug 2020 13:20:22 +0200 (CEST) Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by dpdk.org (Postfix) with ESMTP id 9191423D for ; Tue, 4 Aug 2020 13:20:20 +0200 (CEST) X-Originating-IP: 90.92.205.40 Received: from u256.net (lfbn-idf2-1-1144-40.w90-92.abo.wanadoo.fr [90.92.205.40]) (Authenticated sender: grive@u256.net) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id AE60F40006; Tue, 4 Aug 2020 11:20:19 +0000 (UTC) Date: Tue, 4 Aug 2020 13:20:13 +0200 From: =?utf-8?Q?Ga=C3=ABtan?= Rivet To: Jerin Jacob Cc: David Marchand , dpdk-dev , Thomas Monjalon , Dmitry Kozlyuk Message-ID: <20200804112013.vvwdyphqfmbn3ase@u256.net> References: <20200804084732.882-1-david.marchand@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Subject: Re: [dpdk-dev] [PATCH] doc: announce PCI resources map API removal X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 04/08/20 14:22 +0530, Jerin Jacob wrote: > On Tue, Aug 4, 2020 at 2:18 PM David Marchand wrote: > > > > The PCI resources map API (pci_map_resource/pci_unmap_resource) was > > imposing use of Unix mmap flags while it does not make sense on Windows. > > This API was only used to internally setup PCI devices in the PCI bus > > driver and has no known external users. > > > > Announce its removal in 20.11 with its associated structures. > > > > The workaround implemented in the commit 9d2b24593724 ("pci: keep API > > compatibility with mmap values") will be removed at the same time. > > > > Signed-off-by: David Marchand > > Acked-by: Jerin Jacob > Acked-by: Gaetan Rivet > > > --- > > doc/guides/rel_notes/deprecation.rst | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > > index ea4cfa7a48..24808c002c 100644 > > --- a/doc/guides/rel_notes/deprecation.rst > > +++ b/doc/guides/rel_notes/deprecation.rst > > @@ -67,6 +67,17 @@ Deprecation Notices > > us extending existing enum/define. > > One solution can be using a fixed size array instead of ``.*MAX.*`` value. > > > > +* pci: The PCI resources map API (``pci_map_resource`` and > > + ``pci_unmap_resource``) was not abstracting the Unix mmap flags (see the > > + workaround for Windows support implemented in the commit > > + 9d2b24593724 ("pci: keep API compatibility with mmap values")). > > + This API will be removed from the public API in 20.11 and moved to the PCI > > + bus driver along with the PCI resources lists and associated structures > > + (``pci_map``, ``pci_msix_table``, ``mapped_pci_resource`` and > > + ``mapped_pci_res_list``). > > + With this removal, there won't be a need for the mentioned workaround which > > + will be reverted. > > + > > * ethdev: Split the ``struct eth_dev_ops`` struct to hide it as much as possible > > will be done in 20.11. > > Currently the ``struct eth_dev_ops`` struct is accessible by the application > > -- > > 2.23.0 > > -- Gaëtan