From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E6E14A053A; Wed, 5 Aug 2020 01:39:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 359EA1BFF7; Wed, 5 Aug 2020 01:39:30 +0200 (CEST) Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com [209.85.208.193]) by dpdk.org (Postfix) with ESMTP id C041AE07 for <dev@dpdk.org>; Wed, 5 Aug 2020 01:39:29 +0200 (CEST) Received: by mail-lj1-f193.google.com with SMTP id w14so15717809ljj.4 for <dev@dpdk.org>; Tue, 04 Aug 2020 16:39:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rwLXxRI+6QB/0esukJMjMrBUYEeTJO7h6DwyEHW0POg=; b=dmdTOCzAHzINmQXDvqYigmHvYQkujBY9LKkQUtH2O7SzsO6TMbB1h3KiO2Px/HfE5G 4npqcxRP20DFGAPgrMIXGGNsMQrdF5W0sbiXvSSOEvNXyn8p8z2Jz4hNTCaqf9j0twCY 1pB0KXJ9sUSgyLEtykm38i0fkQ2RTXO5DzMGQt+Wq1aih9JYV2PaXp/J8uwWnMxFCxUM I/zxg/IEnOzEd6lI/Zi1PzTjOA5zzGdF6yjDy275mjI/vySp1dwNb4NqSk3QEM2eKqOX p/lcSWT+LOPWSwYlU4AzMDg21k3KXJuIt4ID/Tx4fiiOKXwiTDvHSo/Mt8pxOTSWByv/ CvWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rwLXxRI+6QB/0esukJMjMrBUYEeTJO7h6DwyEHW0POg=; b=RlNBNzSTAX9DUKUEJ3twYVgnvF3hcJerc7ltxjDlqijEgQf0tN7y73Z7Spu/pegKIA Fv3Ltb6hRj46+unjjdHf8akJbiLCU4Z8vu9FzfYHXs0ckUshIbD/PqnoDHWO2Iv2iMT0 KTcgHsc+XZf9MiV/rp1nTRIuU/ts2G5CeT2xGxVgivw5CdU1ZrriCOz03zs+nBJcjmNw j8WZOHmgCYlQmZFcIkTOhBxNk3LrfoJo0DLwDuc9KIrWi49cv5lhZdJnefX/aji/zq1u grJfjGB4yNs2866pOlAM49Vw6qmkMjTYsllXsck4cwiDgQoEjE5CzygEw0gLukaZjC2N R93w== X-Gm-Message-State: AOAM533dn1ZeCyEfyRMqLLkK5B58L8RZ7RvVQaiW1WRbdsMjvSN5CJtY GFsis2uF8ObjNYeJyv5UkBM= X-Google-Smtp-Source: ABdhPJwUTAnTvmzPL7pImXnLiXJnkEYLmxXU0AbSbnd922VvaflHxP/YxffBMGkEWlj76ct/gVOHxg== X-Received: by 2002:a2e:7c0f:: with SMTP id x15mr95960ljc.205.1596584369236; Tue, 04 Aug 2020 16:39:29 -0700 (PDT) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id 72sm225240lfh.97.2020.08.04.16.39.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2020 16:39:28 -0700 (PDT) Date: Wed, 5 Aug 2020 02:39:26 +0300 From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com> To: Fady Bader <fady@mellanox.com> Cc: dev@dpdk.org, thomas@monjalon.net, tbashar@mellanox.com, talshn@mellanox.com, yohadt@mellanox.com, harini.ramakrishnan@microsoft.com, ocardona@microsoft.com, pallavi.kadam@intel.com, ranjit.menon@intel.com, kevin.laatz@intel.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, ciara.power@intel.com, navasile@linux.microsoft.com Message-ID: <20200805023926.210646e2@sovereign> In-Reply-To: <20200804062947.6176-5-fady@mellanox.com> References: <20200625133038.25180-1-fady@mellanox.com> <20200804062947.6176-1-fady@mellanox.com> <20200804062947.6176-5-fady@mellanox.com> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 4/5] telemetry: implement empty stubs for Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On Tue, 4 Aug 2020 09:29:46 +0300, Fady Bader wrote: > Telemetry didn't compile under Windows. > Empty stubs implementation was added for Windows. > > Signed-off-by: Fady Bader <fady@mellanox.com> > --- > lib/librte_telemetry/rte_telemetry.h | 4 +++ > lib/librte_telemetry/telemetry.c | 51 ++++++++++++++++++++++++++++++++- > lib/librte_telemetry/telemetry_legacy.c | 26 ++++++++++++++++- > 3 files changed, 79 insertions(+), 2 deletions(-) You could #ifdef code in librte_ethdev that uses librte_telemetry and not build librte_telemetry at all. This approach is already taken in eal_common_options.c and it avoids spreading #ifdef throughout telemetry code.