From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 72F97A053A; Wed, 5 Aug 2020 12:02:58 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B6FD51B203; Wed, 5 Aug 2020 12:02:57 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 61D782C28 for ; Wed, 5 Aug 2020 12:02:55 +0200 (CEST) IronPort-SDR: iINXuaoI8O/+Mik0pAA+VBloDaNyumCGUX3T4kmLV6NLYRWzmZIQhYXzuK+ZTOa96WEppsKitv CUbj77n3QCsA== X-IronPort-AV: E=McAfee;i="6000,8403,9703"; a="214035251" X-IronPort-AV: E=Sophos;i="5.75,436,1589266800"; d="scan'208";a="214035251" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Aug 2020 03:02:54 -0700 IronPort-SDR: zTJSBBKv8rOByTsuVQ7k/O/MGSTs0h5XGOpRsKML46k/0DGJuJilXbbrQLfrV8iRLunVGdGct4 gBZ7qe7rYVYg== X-IronPort-AV: E=Sophos;i="5.75,436,1589266800"; d="scan'208";a="437114460" Received: from bricha3-mobl.ger.corp.intel.com ([10.213.255.148]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 05 Aug 2020 03:02:50 -0700 Date: Wed, 5 Aug 2020 11:02:47 +0100 From: Bruce Richardson To: Thomas Monjalon Cc: kevin.laatz@intel.com, ciara.power@intel.com, Dmitry Kozlyuk , Fady Bader , dev@dpdk.org, tbashar@mellanox.com, talshn@mellanox.com, yohadt@mellanox.com, harini.ramakrishnan@microsoft.com, ocardona@microsoft.com, pallavi.kadam@intel.com, ranjit.menon@intel.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, navasile@linux.microsoft.com Message-ID: <20200805100247.GB1716@bricha3-MOBL.ger.corp.intel.com> References: <20200625133038.25180-1-fady@mellanox.com> <14102736.rQ7LXLPuFW@thomas> <20200805083621.GA1709@bricha3-MOBL.ger.corp.intel.com> <2862680.3ZvUzCBnBg@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2862680.3ZvUzCBnBg@thomas> Subject: Re: [dpdk-dev] [PATCH v4 4/5] telemetry: implement empty stubs for Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Aug 05, 2020 at 11:06:04AM +0200, Thomas Monjalon wrote: > 05/08/2020 10:40, Bruce Richardson: > > On Wed, Aug 05, 2020 at 10:27:27AM +0200, Thomas Monjalon wrote: > > > 05/08/2020 01:39, Dmitry Kozlyuk: > > > > On Tue, 4 Aug 2020 09:29:46 +0300, Fady Bader wrote: > > > > > Telemetry didn't compile under Windows. > > > > > Empty stubs implementation was added for Windows. > > > > > > > > > > Signed-off-by: Fady Bader > > > > > --- > > > > > lib/librte_telemetry/rte_telemetry.h | 4 +++ > > > > > lib/librte_telemetry/telemetry.c | 51 ++++++++++++++++++++++++++++++++- > > > > > lib/librte_telemetry/telemetry_legacy.c | 26 ++++++++++++++++- > > > > > 3 files changed, 79 insertions(+), 2 deletions(-) > > > > > > > > You could #ifdef code in librte_ethdev that uses librte_telemetry and not > > > > build librte_telemetry at all. This approach is already taken in > > > > eal_common_options.c and it avoids spreading #ifdef throughout telemetry code. > > > > > > The problem is that telemetry can be used anywhere, not only in ethdev. > > > I feel it is better to #ifdef telemetry than every telemetry calls. > > > > > Given that the majority of telemetry has no external dependencies (jansson > > is only used for the older compatibility part), and it uses sockets for > > communication, is there a reason why it can't just be made to build and > > work on windows? The unix domain socket could be converted to a standard > > UDP socket on localhost, perhaps. Is there anything unix-specific beyond > > that? > > Yes of course telemetry should build on Windows. > But it seems nobody committed yet to work on it. > Feel free :) Thanks, I might give it a go sometime if I have the chance. However, I was mainly just checking that there was no known serious impediment to having it work.