From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 84C24A053A; Wed, 5 Aug 2020 13:17:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E9BCB2C23; Wed, 5 Aug 2020 13:17:58 +0200 (CEST) Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com [209.85.208.193]) by dpdk.org (Postfix) with ESMTP id 7971B2BB5 for ; Wed, 5 Aug 2020 13:17:57 +0200 (CEST) Received: by mail-lj1-f193.google.com with SMTP id s16so31980779ljc.8 for ; Wed, 05 Aug 2020 04:17:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xhNr866sNuVa2OQzzFFyLw9LjlYVsM7qOa3d7VZeM0I=; b=o9Rre5qFA2rr/woDKrQwnHNQTuvNrcDCycT8BE75cs7AgLsCGzlt9x5Uo/kHcZtttF hJROI/xHqNS9+YwfJq/FJSSnqmeI7XL9w9s76kM+H1o6dCFIHfLlqs3qJGJWZDnLyNAZ Gbw8GaS72xpQ0qDpTyiyalAyWWB97cVLjCs6cpzWVYaHsqOG8E1QUZsNGXxep0RkYsFe gjVu6Ri/wzhIzuxQFwZloneBJVAc7qiMLzLpK4tEBFiMWHSxeT/XBki2SnPqgoBUjAvd wkrGIfWJ95gsI/bTeagJnqkyV+s/moyS2IMJyKjqzLD2KMEpOo3VEPa7zrAZetmFlX7r S7xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xhNr866sNuVa2OQzzFFyLw9LjlYVsM7qOa3d7VZeM0I=; b=ivZZTMkDvawnAbC+A5JPgkk8DGvxMKHWuevmEDoUAQ2EgXM95JU2X4qwqZ29AA+5tg WEnRtWJ2XKo8Mznm86LAK20s1OT/qa4eZCxVZ6XUsIKA15u55W696elI9vRlUZTigeOK YznlwlsvgDRnVr+O1PGJuBDTTxTzrnFIud8DamPzWXPdsgJGhhB/6DsrA/9+ReYcxkbe bsm3VU8VPhDSbJwiH68XKbf1+0HwKLczVQevSXcwsBkzUvN0z/lrMjrbosLu+3d8OTHO M9ox0Icdx/A8orf2+192ngxtyaleVXV8ISvPEqPGE3V1EzTbrYO9OndoUYWWcW2mm6bx NgYQ== X-Gm-Message-State: AOAM530vTQsWx6sxGkQWL6gE9JXT/3Q4e5HD799PSgWCWwJ1K8PZiEL2 C5mV2AJTS0QZzKH9gBmZbfo= X-Google-Smtp-Source: ABdhPJxaf7zbypWxA6EcKv84hZ+kkS1BvQzQc5VQieCQyWaQpIegsLa7gMl1BVDENeDSN3ZSoAY22Q== X-Received: by 2002:a2e:b689:: with SMTP id l9mr1126108ljo.393.1596626276826; Wed, 05 Aug 2020 04:17:56 -0700 (PDT) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id j2sm752816ljb.98.2020.08.05.04.17.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Aug 2020 04:17:56 -0700 (PDT) Date: Wed, 5 Aug 2020 14:17:55 +0300 From: Dmitry Kozlyuk To: "Kinsella, Ray" Cc: dev@dpdk.org, Dmitry Malloy , Narcisa Ana Maria Vasile , Fady Bader , Tal Shnaiderman , "Kadam, Pallavi" , Olivier Matz , Neil Horman Message-ID: <20200805141755.10c9c324@sovereign> In-Reply-To: <727edaf3-a8a8-e55a-ce36-8bde541c810d@ashroe.eu> References: <20200620210511.13134-1-dmitry.kozliuk@gmail.com> <20200730210652.14568-1-dmitry.kozliuk@gmail.com> <20200730210652.14568-2-dmitry.kozliuk@gmail.com> <727edaf3-a8a8-e55a-ce36-8bde541c810d@ashroe.eu> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 1/7] cmdline: make implementation opaque X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 5 Aug 2020 10:31:31 +0100, Kinsella, Ray wrote: > On 30/07/2020 22:06, Dmitry Kozlyuk wrote: > > struct cmdline exposes platform-specific members it contains, most > > notably struct termios that is only available on Unix. Make the > > structure opaque. > > > > Remove tests checking struct cmdline content as meaningless. > > > > Add cmdline_get_rdline() to access history buffer. > > The new function is currently used only in tests. > > Should it be INTERNAL then? Is it useful outside of the test cases? There are already exposed rdline_*() functions that require struct rdline pointer, which is now only accessible via this function for struct cmdline instances. Thus, public API would be broken with INTERNAL for such use cases.