From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AA8C2A052B; Thu, 6 Aug 2020 05:50:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D18B92BF2; Thu, 6 Aug 2020 05:50:58 +0200 (CEST) Received: from mail-qk1-f194.google.com (mail-qk1-f194.google.com [209.85.222.194]) by dpdk.org (Postfix) with ESMTP id 6B30E2BF1 for ; Thu, 6 Aug 2020 05:50:57 +0200 (CEST) Received: by mail-qk1-f194.google.com with SMTP id 2so39667094qkf.10 for ; Wed, 05 Aug 2020 20:50:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=1eX0uFwKo6ew30Yh+YZlLDtYwhjCjewu1LMy+go149Y=; b=nV2wLR7pfT2hP4CRMvxoX6626ppAQkYRwLHsIxjDEr/BMjRJLd1M1Cx38LqgK7s70B +qQJUakiAYyZ7pcz9sf0Yn0a6V9jTPyzUE02LeO+a/hRoVNg5YvpkwLibTskQ+Zj/PkV wevqAJVNsotYA1CwPnUQP4sHpwMVfvJZEnpTcwHligyJRv43AOus5minhZHqdDJkYyVU wNyGeJF18f8FVz3KmifRcx3gAeDLOo1djal7faKDu+gh7xmuawsWWvafvKhcFlfKGG8C FyyXhJljCY0yr+9WkOkwtxtdRrBWexY9eR0S/cHOKks0odkTKEoJaRVEaRq4m/0ACE5G c9DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=1eX0uFwKo6ew30Yh+YZlLDtYwhjCjewu1LMy+go149Y=; b=RgFCe0dJiYfp2FeUSXDH9EmIAWFuECQjI3Lc3YgK1OAJ16rOjnDwzLV3+wsZwYk4gP LYCVXwyUbb6yTsl3XNmBJAAYCflY3K4KIc/UZY8CQvrMSlT+kHbattUdep/lZCLjtfZA i3abLgCUHEBh3c5btMGE8JZDJ9HJfJGL2A9khtSHO8k3yc9Rkq6Plele7tc3K3RnodO+ yL7b97LT1ax8M4LJ6FyQzx1X2w+emmDeszjuMmEVxGoC46+8EBrzKEcYYjq9x3aWbNBS FnuFwwao3gOW4nyd2r6GRhyPpTeXjbD85LNb6XUesceIZRF7DJYWfSrGx5SfC0C49oOQ xV9A== X-Gm-Message-State: AOAM533CSGiEoj3k20PtyOema/F+BrYdZ+GuRfvHaCZ/S64Wb2BFOPRF S8xlgSsN9E8KYfLbzAl/t3m8/UK/xx0= X-Google-Smtp-Source: ABdhPJzBu3Q4bHQZFsQZ8/O1jhpVgAbEZMG1sjBZrV2R0UtLQsG3gmcBEUBlCisZwca2fw3A6Y1Dxg== X-Received: by 2002:a05:620a:68a:: with SMTP id f10mr6597464qkh.281.1596685856686; Wed, 05 Aug 2020 20:50:56 -0700 (PDT) Received: from linux.home ([2604:2000:1344:41d:2015:dcc2:6079:f44b]) by smtp.googlemail.com with ESMTPSA id v2sm3961966qte.25.2020.08.05.20.50.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Aug 2020 20:50:55 -0700 (PDT) From: Gaurav Singh To: dev@dpdk.org Cc: Gaurav Singh Date: Wed, 5 Aug 2020 23:50:49 -0400 Message-Id: <20200806035049.22471-1-gaurav1086@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <26979354.Z9mb2dG3pe@thomas> References: <26979354.Z9mb2dG3pe@thomas> Subject: [dpdk-dev] [PATCH] net/bnxt: remove redundant null check in bnxt_validate_and_parse_flow_type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" vxlan_spec cannot be NULL since its already being accessed before. Remove the redundant NULL check. Signed-off-by: Gaurav Singh --- drivers/net/bnxt/bnxt_flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c index 320b53d94..c1c59bbe5 100644 --- a/drivers/net/bnxt/bnxt_flow.c +++ b/drivers/net/bnxt/bnxt_flow.c @@ -554,7 +554,7 @@ bnxt_validate_and_parse_flow_type(struct bnxt *bp, } /* Check if VNI is masked. */ - if (vxlan_spec && vxlan_mask) { + if (vxlan_mask != NULL) { vni_masked = !!memcmp(vxlan_mask->vni, vni_mask, RTE_DIM(vni_mask)); -- 2.17.1