From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0F0A3A04B0; Fri, 7 Aug 2020 17:06:08 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1920329D6; Fri, 7 Aug 2020 17:06:07 +0200 (CEST) Received: from relay10.mail.gandi.net (relay10.mail.gandi.net [217.70.178.230]) by dpdk.org (Postfix) with ESMTP id 801BE1E34 for ; Fri, 7 Aug 2020 17:06:05 +0200 (CEST) Received: from u256.net (lfbn-idf2-1-1144-40.w90-92.abo.wanadoo.fr [90.92.205.40]) (Authenticated sender: grive@u256.net) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 222FF240004; Fri, 7 Aug 2020 15:06:03 +0000 (UTC) Date: Fri, 7 Aug 2020 17:05:53 +0200 From: =?utf-8?Q?Ga=C3=ABtan?= Rivet To: Jerin Jacob Cc: Ferruh Yigit , Bruce Richardson , Ciara Power , dpdk-dev , Thomas Monjalon Message-ID: <20200807150553.ujvph5i5jzuu77ok@u256.net> References: <20200807123009.21266-1-ciara.power@intel.com> <20200807123009.21266-3-ciara.power@intel.com> <20200807124536.GA302@bricha3-MOBL.ger.corp.intel.com> <20200807132343.GA306@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Subject: Re: [dpdk-dev] [PATCH 20.11 02/19] build: remove makefiles and mk directory X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 07/08/20 19:31 +0530, Jerin Jacob wrote: > On Fri, Aug 7, 2020 at 7:04 PM Ferruh Yigit wrote: > > > > On 8/7/2020 2:23 PM, Bruce Richardson wrote: > > > On Fri, Aug 07, 2020 at 06:49:47PM +0530, Jerin Jacob wrote: > > >> On Fri, Aug 7, 2020 at 6:15 PM Bruce Richardson > > >> wrote: > > >>> > > >>> On Fri, Aug 07, 2020 at 01:29:52PM +0100, Ciara Power wrote: > > >>>> It was decided [1] to no longer support Make in DPDK, this patch > > >>>> removes all Makefiles that do not make use of pkg-config, along with > > >>>> the mk directory previously used by make. > > >>>> > > >>>> [1] https://mails.dpdk.org/archives/dev/2020-April/162839.html > > >>>> > > >>>> Signed-off-by: Ciara Power > > >>>> --- > > >>>> GNUmakefile | 17 - > > >>>> Makefile | 4 - > > >>> > > >>> Open question from me: > > >>> Do we want to leave a dummy top-level makefile that prints instructions on > > >>> build with meson and ninja - or even runs a build using them if they are > > >>> installed? > > >> > > >> Maybe we can keep "make tags" as well in top-level Makefile. > > > > > > Is it better to point people directly to the script? My concern about > > > having a makefile is that it may confuse people as to how to build DPDK. > > > On the other side, there is a convenience aspect to having a makefile, so > > > I'm open to being convinced either way. > > I was looking more of a convenience point of view. > Can we check how other meson based projects deal with similar problems? > > > > > > > > A dummy Makefile to print instructions may be helpful for people missed the > > change, I am for having it. > > > > But I am dubious on extending it, like for tags, although I found it useful I > > think we should integrate it to meson instead. > > I think, we can not integrate such stuff with meson. If we can with meson, > I agree we should take that path. +1 to provide basic and short instructions to use meson when someone tries to use make. On the other hand I think tag generation should not be part of the build system. The only dependency of build-tags.sh on make is for `make showconfigs`, they can probably be listed without using make. The scripts seems standalone, why keep make to call it? The config target could be inferred if that's the issue? -- Gaëtan