From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B89F5A0351; Mon, 17 Aug 2020 17:11:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BD54E1C0BC; Mon, 17 Aug 2020 17:11:48 +0200 (CEST) Received: from mail-pj1-f67.google.com (mail-pj1-f67.google.com [209.85.216.67]) by dpdk.org (Postfix) with ESMTP id B40BE1C020 for ; Mon, 17 Aug 2020 17:11:47 +0200 (CEST) Received: by mail-pj1-f67.google.com with SMTP id kr4so7971611pjb.2 for ; Mon, 17 Aug 2020 08:11:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=r9X+dRdCyDY/XY8CGiXVOPLw8r7q8FrIo3mroUbmPOI=; b=X7cNJ5DtBGoWoK/QaOm+SMnoP6lhTb41GCdacICYBbdrL5Ipoae1DLYxBlYGP3WzzL 6p2W9GQQSLZJzvadaGEiX6nxiRoyW3luNhk8hzRHq5oTu1SWXAFcatYo12M5M72RBrMN dy/zWEPliLOv0lwWfH8McTFwQ10CCb+MVsMuk4qbTCfx3/IDEpYuYRWpKcABFVPx9ciX /6OvzjIe1DEn/8nb/FJ3RAp+TUOiMZkGYX7Lh7faTqnkPq62CFX2KvgPePo1KjkoL3cr TSj8hNoTJM4pM8huAly9UB5fUxHLGwl3BoS3dWUJtMNceREzTCl2DbU+xbUF/Vjqg+56 NspA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=r9X+dRdCyDY/XY8CGiXVOPLw8r7q8FrIo3mroUbmPOI=; b=svKD2CNSbu4eRP+EuMY+Kuw8ysyn1vTKLWi5881IXNJAKj6fy9jR9Mf/JIS1dldKSv D4DvXWDMG0oRT6VSbao83Y1Qt3Bhv/5PmKvWmH2RvxDXdn4cZhWMSwn/d4ju4sg2JSeS zRt4PIVFQg3+KQHHukmMu8aSihJHJCKUlxPZ4keXGDh0vsvvVdxgxh4i1e7Xx+yWClEN Y7EH0iM7iamBYRFFroHa40dftzoIvkiTJ+5kcEzKwkaYmuanJlyaINMmAnZLCDxj3LIj CGgqFzQfSS1Pi2OdhWEPCEQKhgEJ79iImGXVvsQaWiOQ7BD8otfuBVSzRzTy4bsIDDEs SN7Q== X-Gm-Message-State: AOAM532KrXN/8UX5tE1kXG8aGAlVK/fJ3f3GpCQXg4YMEZ+450zvYk34 8IESpcdlApEo9/MT7aK0NOkueA== X-Google-Smtp-Source: ABdhPJydJZe4TfQbb/kZAa0BRw48uNeNtCS/heHE1l5Z18m4dSwHMzyD72aM2iDJIhN+ceBlw3rvGA== X-Received: by 2002:a17:902:a50e:: with SMTP id s14mr11098204plq.164.1597677106655; Mon, 17 Aug 2020 08:11:46 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id fv23sm17647631pjb.35.2020.08.17.08.11.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2020 08:11:46 -0700 (PDT) Date: Mon, 17 Aug 2020 08:11:37 -0700 From: Stephen Hemminger To: Bruce Richardson Cc: Dmitry Kozlyuk , dev@dpdk.org Message-ID: <20200817081137.3b00fd39@hermes.lan> In-Reply-To: <20200817103740.GA496@bricha3-MOBL.ger.corp.intel.com> References: <20200814173441.23086-1-stephen@networkplumber.org> <20200814213929.1d7ca040@sovereign> <20200814114549.528d144f@hermes.lan> <20200814220911.39097cfa@sovereign> <20200814122028.312c7c8b@hermes.lan> <20200817103740.GA496@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] eal: add option to put timestamp on console output X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 17 Aug 2020 11:37:40 +0100 Bruce Richardson wrote: > On Fri, Aug 14, 2020 at 12:20:28PM -0700, Stephen Hemminger wrote: > > On Fri, 14 Aug 2020 22:09:11 +0300 > > Dmitry Kozlyuk wrote: > > > > > On Fri, 14 Aug 2020 11:45:49 -0700, Stephen Hemminger wrote: > > > > On Fri, 14 Aug 2020 21:39:29 +0300 > > > > Dmitry Kozlyuk wrote: > > > [...] > > > > FreeBsd doesn't go through the same log code. > > > > > > Then --log-timestamp shouldn't appear on FreeBSD if it's unsupported. > > > > Was using same ifdef that is already there. There are several options already > > (like syslog facility) which do nothing on FreeBSD anyway. > > > While that is correct, I think that we really should support this on > FreeBSD also, since I don't think there is any technical reason we can't do > so, right? Even a sub-optimal solution where the timestamp write and log > write are non-atomic would be better than nothing. > > /Bruce FreeBSD now just uses default log stream (stdout). Linux has log stream to syslog and stdout. There is nothing Linux specific in the old or new code. The Linux code could just be moved to common, and both could use it. That is a separate patch, and someone with expertise and build setup for FreeBSD needs to do it.