From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A382CA034C; Tue, 18 Aug 2020 15:34:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A86592B94; Tue, 18 Aug 2020 15:34:19 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id E7C481F28 for ; Tue, 18 Aug 2020 15:34:17 +0200 (CEST) IronPort-SDR: 2epHIgdIrOmGYwGd9Yddxwr34hAjg0rFgdnAo/cacjKuylDLoFpduaI3wT26klJtKtLuFstOMv QFAtf6/8toqQ== X-IronPort-AV: E=McAfee;i="6000,8403,9716"; a="155978997" X-IronPort-AV: E=Sophos;i="5.76,327,1592895600"; d="scan'208";a="155978997" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Aug 2020 06:34:16 -0700 IronPort-SDR: s8KefYZId59dIGREFNbU3BJiCqM6BNZvlCB7WE+wMyeDi9Bo2xTOgLk+lWPCkRNrpXzwj5tJYZ 5P3NI77ydgZQ== X-IronPort-AV: E=Sophos;i="5.76,327,1592895600"; d="scan'208";a="441222790" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.19.21]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 18 Aug 2020 06:34:15 -0700 Date: Tue, 18 Aug 2020 14:34:12 +0100 From: Bruce Richardson To: Ciara Power Cc: dev@dpdk.org, thomas@monjalon.net Message-ID: <20200818133412.GE500@bricha3-MOBL.ger.corp.intel.com> References: <20200807123009.21266-1-ciara.power@intel.com> <20200807123009.21266-13-ciara.power@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200807123009.21266-13-ciara.power@intel.com> Subject: Re: [dpdk-dev] [PATCH 20.11 12/19] doc: remove references to make in Linux gsg guides X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Aug 07, 2020 at 01:30:02PM +0100, Ciara Power wrote: > Make is no longer supported for compiling DPDK, references are now > removed in the documentation. > > Signed-off-by: Ciara Power > --- > doc/guides/linux_gsg/build_dpdk.rst | 58 ------------------- > doc/guides/linux_gsg/build_sample_apps.rst | 16 +---- > .../linux_gsg/cross_build_dpdk_for_arm64.rst | 42 -------------- > doc/guides/linux_gsg/enable_func.rst | 3 - > doc/guides/linux_gsg/intro.rst | 2 +- > doc/guides/linux_gsg/linux_drivers.rst | 2 - > doc/guides/linux_gsg/sys_reqs.rst | 4 -- > 7 files changed, 4 insertions(+), 123 deletions(-) > > diff --git a/doc/guides/linux_gsg/linux_drivers.rst b/doc/guides/linux_gsg/linux_drivers.rst > index 185074013a..ba0e45d95b 100644 > --- a/doc/guides/linux_gsg/linux_drivers.rst > +++ b/doc/guides/linux_gsg/linux_drivers.rst In section 5.1 there is a reference to the "kmod" subdirectory, which is the make build directory name. This should be changed to "kernel/linux" for meson builds. > @@ -38,8 +38,6 @@ be loaded as shown below: > > .. note:: > > - ``igb_uio`` module is disabled by default starting from ``DPDK v20.02``. > - To build it, the config option ``CONFIG_RTE_EAL_IGB_UIO`` should be enabled. The deleted text needs to be replaced, I think. I'd suggest: "Building DPDK Linux kernel modules is disabled by default starting from DPDK v20.02. To enable them again, the config option "enable_kmods" needs to be set in the meson build configuration. See :ref:`adjusting_build_options` for details on how to set/clear build options." > It is planned to move ``igb_uio`` module to a different git repository. > > .. note::