From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A69A4A034C; Tue, 18 Aug 2020 16:45:09 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7FF735F69; Tue, 18 Aug 2020 16:45:08 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 37BE92B91 for ; Tue, 18 Aug 2020 16:45:07 +0200 (CEST) IronPort-SDR: Sd/YLXlaaxQeyIv4QZiWmZgLbssNSi2fqAE+habEfjiPhjnEkOeoRTU02L8MK8eM/u8CscC4go PHbGL8Q+EBFQ== X-IronPort-AV: E=McAfee;i="6000,8403,9716"; a="134434552" X-IronPort-AV: E=Sophos;i="5.76,327,1592895600"; d="scan'208";a="134434552" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Aug 2020 07:45:06 -0700 IronPort-SDR: Nt6dikUHAEKbMKbQTPQIHmr9kNNdfHG3w170EiNUhRk9PqXOx3U5BJF1C5ff+6gQfSMDFONezQ ULVctOGNJPbw== X-IronPort-AV: E=Sophos;i="5.76,327,1592895600"; d="scan'208";a="471833980" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.19.21]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 18 Aug 2020 07:45:04 -0700 Date: Tue, 18 Aug 2020 15:45:01 +0100 From: Bruce Richardson To: Ciara Power Cc: dev@dpdk.org, thomas@monjalon.net Message-ID: <20200818144501.GG500@bricha3-MOBL.ger.corp.intel.com> References: <20200807123009.21266-1-ciara.power@intel.com> <20200807123009.21266-13-ciara.power@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200807123009.21266-13-ciara.power@intel.com> Subject: Re: [dpdk-dev] [PATCH 20.11 12/19] doc: remove references to make in Linux gsg guides X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Aug 07, 2020 at 01:30:02PM +0100, Ciara Power wrote: > Make is no longer supported for compiling DPDK, references are now > removed in the documentation. > > Signed-off-by: Ciara Power Apologies for the multiple emails, but to review this properly I'm reviewing the text section by section. /Bruce > --- > doc/guides/linux_gsg/build_dpdk.rst | 58 ------------------- > doc/guides/linux_gsg/build_sample_apps.rst | 16 +---- > .../linux_gsg/cross_build_dpdk_for_arm64.rst | 42 -------------- > doc/guides/linux_gsg/enable_func.rst | 3 - > doc/guides/linux_gsg/intro.rst | 2 +- > doc/guides/linux_gsg/linux_drivers.rst | 2 - > doc/guides/linux_gsg/sys_reqs.rst | 4 -- > 7 files changed, 4 insertions(+), 123 deletions(-) > > diff --git a/doc/guides/linux_gsg/enable_func.rst b/doc/guides/linux_gsg/enable_func.rst > index b2bda80bb7..40c6f25a6f 100644 > --- a/doc/guides/linux_gsg/enable_func.rst > +++ b/doc/guides/linux_gsg/enable_func.rst > @@ -40,9 +40,6 @@ requires that the ``HPET_MMAP`` kernel configuration option be enabled. > Enabling HPET in the DPDK > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > -By default, HPET support is disabled in the DPDK build configuration files. This sentence can be kept. > -To use HPET, the ``CONFIG_RTE_LIBEAL_USE_HPET`` setting should be changed to ``y``, which will enable the HPET settings at compile time. > - This should instead refer to the "use_hpet" meson build option. I'm not sure who, if anyone, still uses hpet for DPDK timers, but that is outside the scope of this set, so let's just update to match the current situation. > For an application to use the ``rte_get_hpet_cycles()`` and ``rte_get_hpet_hz()`` API calls, > and optionally to make the HPET the default time source for the rte_timer library, > the new ``rte_eal_hpet_init()`` API call should be called at application initialization. section 8.5 in this chapter discusses kni, and the reference there to the kmod directory should be replaced by kernel/linux. To cover enabling the build of it etc., I'd just say it can be enabled in the same way as igb_uio and give the reference.