From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5574FA04AF; Wed, 19 Aug 2020 15:03:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3F3F2AAD5; Wed, 19 Aug 2020 15:03:48 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 6BF83AAB7 for <dev@dpdk.org>; Wed, 19 Aug 2020 15:03:46 +0200 (CEST) IronPort-SDR: HuWPIk+qBQaWeylLYu6KH/dz3T8pDv6ZhGyVN5pHTqiCUvZ8/yb21y7I9wJxaA93DCFK9KwP4n RP317wJwBHSg== X-IronPort-AV: E=McAfee;i="6000,8403,9717"; a="152515473" X-IronPort-AV: E=Sophos;i="5.76,331,1592895600"; d="scan'208";a="152515473" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Aug 2020 06:03:34 -0700 IronPort-SDR: 4PKlKdr90A+xpLoeeEv3Ck++zEq9bORtSYvTcrvSnxNT+kRuT+wBLBRE2925GVGbZ1aSmbc9k9 zdoZOHjCHqjg== X-IronPort-AV: E=Sophos;i="5.76,331,1592895600"; d="scan'208";a="472226578" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.0.199]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 19 Aug 2020 06:03:33 -0700 Date: Wed, 19 Aug 2020 14:03:27 +0100 From: Bruce Richardson <bruce.richardson@intel.com> To: Ciara Power <ciara.power@intel.com> Cc: dev@dpdk.org, thomas@monjalon.net Message-ID: <20200819130327.GA813@bricha3-MOBL.ger.corp.intel.com> References: <20200807123009.21266-1-ciara.power@intel.com> <20200807123009.21266-13-ciara.power@intel.com> <20200818114053.GB500@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200818114053.GB500@bricha3-MOBL.ger.corp.intel.com> Subject: Re: [dpdk-dev] [PATCH 20.11 12/19] doc: remove references to make in Linux gsg guides X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On Tue, Aug 18, 2020 at 12:40:53PM +0100, Bruce Richardson wrote: > On Fri, Aug 07, 2020 at 01:30:02PM +0100, Ciara Power wrote: > > Make is no longer supported for compiling DPDK, references are now > > removed in the documentation. > > > > Signed-off-by: Ciara Power <ciara.power@intel.com> > > --- > > doc/guides/linux_gsg/build_dpdk.rst | 58 ------------------- > > doc/guides/linux_gsg/build_sample_apps.rst | 16 +---- > > .../linux_gsg/cross_build_dpdk_for_arm64.rst | 42 -------------- > > doc/guides/linux_gsg/enable_func.rst | 3 - > > doc/guides/linux_gsg/intro.rst | 2 +- > > doc/guides/linux_gsg/linux_drivers.rst | 2 - > > doc/guides/linux_gsg/sys_reqs.rst | 4 -- > > 7 files changed, 4 insertions(+), 123 deletions(-) > > > <snip> > > diff --git a/doc/guides/linux_gsg/sys_reqs.rst b/doc/guides/linux_gsg/sys_reqs.rst > > index a124656bcb..a009f3146b 100644 > > --- a/doc/guides/linux_gsg/sys_reqs.rst > > +++ b/doc/guides/linux_gsg/sys_reqs.rst > > @@ -85,10 +85,6 @@ A number of DPDK components, such as libraries and poll-mode drivers (PMDs) have > > For DPDK builds using meson, the presence or absence of these dependencies will be > > automatically detected enabling or disabling the relevant components appropriately. > > > > I think you can drop the words "using meson" here as there is no > alternative any more. > > > -For builds using make, these components are disabled in the default configuration and > > -need to be enabled manually by changing the relevant setting to "y" in the build configuration file > > -i.e. the ``.config`` file in the build folder. > > - > > In each case, the relevant library development package (``-devel`` or ``-dev``) is needed to build the DPDK components. > > > > For libraries the additional dependencies include: > > In sys_reqs.rst there is also a reference to make in the "Required Tools > and Libraries". Change: > > "General development tools including make, and a supported C compiler such > as gcc (version 4.9+) or clang (version 3.4+)." > > To something like: > > "General development tools including a supported C compiler such > as gcc (version 4.9+) or clang (version 3.4+)." Also, one more thing I spot in that section is that we need to update our python minimum version to 3.5+ and drop references to 2.7. Therefore, I'd suggest just removing the whole sub-bullets and put a single bullet saying "Python, v3.5 or later"