From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5D376A04AF; Thu, 20 Aug 2020 14:54:37 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 04FD51C19E; Thu, 20 Aug 2020 14:52:14 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id D3AE41C11D for ; Thu, 20 Aug 2020 14:52:09 +0200 (CEST) IronPort-SDR: KvYBOaJnxjkl2HzPlLWDnfv4SEbzPlzwT4J9l3J8cQnrDE3W81ThbF8nTP8/UMYet5pmhqu4vu JABuyq66bWnA== X-IronPort-AV: E=McAfee;i="6000,8403,9718"; a="219594300" X-IronPort-AV: E=Sophos;i="5.76,332,1592895600"; d="scan'208";a="219594300" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Aug 2020 05:52:09 -0700 IronPort-SDR: 31Sdel1Utvy7nsZh97UFmywe6r7crCHqPMfSBLNIjBGaCV3YHlCUgIMCNVKEEBNhfiGeOUIcjH s52h87QXwRQw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,332,1592895600"; d="scan'208";a="498130700" Received: from silpixa00399953.ir.intel.com (HELO silpixa00399953.ger.corp.intel.com) ([10.237.222.53]) by fmsmga005.fm.intel.com with ESMTP; 20 Aug 2020 05:52:06 -0700 From: Ciara Power To: dev@dpdk.org Cc: Ciara Power , Bruce Richardson , Konstantin Ananyev , Marko Kovacevic , Ori Kam , Radu Nicolau , Akhil Goyal , Tomasz Kantecki , Sunil Kumar Kori , Pavan Nikhilesh Date: Thu, 20 Aug 2020 13:41:15 +0100 Message-Id: <20200820124140.13451-13-ciara.power@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200820124140.13451-1-ciara.power@intel.com> References: <20200807123009.21266-1-ciara.power@intel.com> <20200820124140.13451-1-ciara.power@intel.com> Subject: [dpdk-dev] [PATCH v2 12/37] examples: remove old build system references X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Remove the references to RTE_SDK and RTE_TARGET environment variables from the build instructions in the comments of the various BPF files, and in the ipsec-secgw common definition script. Signed-off-by: Ciara Power Signed-off-by: Bruce Richardson --- Ask for maintainer to review changes and suggest alternatives to the values added in replacement of environment variables. --- examples/bpf/t2.c | 6 ++++-- examples/bpf/t3.c | 10 ++++++---- examples/ipsec-secgw/test/common_defs.sh | 4 ++-- 3 files changed, 12 insertions(+), 8 deletions(-) diff --git a/examples/bpf/t2.c b/examples/bpf/t2.c index 9878eaf7bd..b9bce746c0 100644 --- a/examples/bpf/t2.c +++ b/examples/bpf/t2.c @@ -9,8 +9,10 @@ * (PKT_RX_VLAN_PKT | PKT_RX_VLAN_STRIPPED). * Doesn't touch contents of packet data. * To compile: - * clang -O2 -I${RTE_SDK}/${RTE_TARGET}/include \ - * -target bpf -Wno-int-to-void-pointer-cast -c t2.c + * clang -O2 -target bpf -Wno-int-to-void-pointer-cast -c t2.c + * + * NOTE: if DPDK is not installed system-wide, add compiler flag with path + * to DPDK rte_mbuf.h file, e.g. "clang -I/path/to/dpdk/headers -O2 ..." */ #include diff --git a/examples/bpf/t3.c b/examples/bpf/t3.c index f58ff64b3b..66faf80cc5 100644 --- a/examples/bpf/t3.c +++ b/examples/bpf/t3.c @@ -8,13 +8,15 @@ * Dump the mbuf into stdout if it is an ARP packet (aka tcpdump 'arp'). * * To compile on x86: - * clang -O2 -U __GNUC__ -I${RTE_SDK}/${RTE_TARGET}/include \ - * -target bpf -Wno-int-to-void-pointer-cast -c t3.c + * clang -O2 -U __GNUC__ -target bpf -Wno-int-to-void-pointer-cast -c t3.c * * To compile on ARM: - * clang -O2 -I/usr/include/aarch64-linux-gnu \ - * -I${RTE_SDK}/${RTE_TARGET}/include -target bpf \ + * clang -O2 -I/usr/include/aarch64-linux-gnu -target bpf \ * -Wno-int-to-void-pointer-cast -c t3.c + * + * NOTE: if DPDK is not installed system-wide, add compiler flag with path + * to DPDK rte_mbuf.h file to above commands, + * e.g. "clang -I/path/to/dpdk/headers -O2 ..." */ #include diff --git a/examples/ipsec-secgw/test/common_defs.sh b/examples/ipsec-secgw/test/common_defs.sh index df680805b8..f22eb3ab12 100644 --- a/examples/ipsec-secgw/test/common_defs.sh +++ b/examples/ipsec-secgw/test/common_defs.sh @@ -34,8 +34,8 @@ LOCAL_IPV4=192.168.31.92 REMOTE_IPV6=fd12:3456:789a:0031:0000:0000:0000:0014 LOCAL_IPV6=fd12:3456:789a:0031:0000:0000:0000:0092 -DPDK_PATH=${RTE_SDK:-${PWD}} -DPDK_BUILD=${RTE_TARGET:-x86_64-native-linux-gcc} +DPDK_PATH=${PWD} +DPDK_BUILD="build" DPDK_VARS="" # by default ipsec-secgw can't deal with multi-segment packets -- 2.17.1