From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D5EB5A04AF; Thu, 20 Aug 2020 17:54:26 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A75571C027; Thu, 20 Aug 2020 17:54:26 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 2D4671BEC4 for <dev@dpdk.org>; Thu, 20 Aug 2020 17:54:25 +0200 (CEST) IronPort-SDR: LD/x/DRTx7EnirQea7k+v3JJgAvmIsP3OSOIAcWHfelS1HWHvVltucgKW/S/jWjtWniHw8bfwR 0IE42oFzXk9w== X-IronPort-AV: E=McAfee;i="6000,8403,9718"; a="219635851" X-IronPort-AV: E=Sophos;i="5.76,333,1592895600"; d="scan'208";a="219635851" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Aug 2020 08:54:24 -0700 IronPort-SDR: teKng4GeCELvmz7ZVjUCgxHwcYliA3UuDhdp9Oa5M+mG9wcGIgyOhs+jk56P4SQlPPeBFlXxZv aQ6nwEepnUDw== X-IronPort-AV: E=Sophos;i="5.76,333,1592895600"; d="scan'208";a="472701640" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.0.88]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 20 Aug 2020 08:54:23 -0700 Date: Thu, 20 Aug 2020 16:54:20 +0100 From: Bruce Richardson <bruce.richardson@intel.com> To: Thomas Monjalon <thomas@monjalon.net> Cc: John McNamara <john.mcnamara@intel.com>, Marko Kovacevic <marko.kovacevic@intel.com>, dev@dpdk.org Message-ID: <20200820155420.GB824@bricha3-MOBL.ger.corp.intel.com> References: <20200721153950.748927-1-bruce.richardson@intel.com> <1786897.AIzr81cTuv@thomas> <20200722125949.GA1031@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200722125949.GA1031@bricha3-MOBL.ger.corp.intel.com> Subject: Re: [dpdk-dev] [PATCH] doc/guides: remove dependency on make build system X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On Wed, Jul 22, 2020 at 01:59:49PM +0100, Bruce Richardson wrote: > On Wed, Jul 22, 2020 at 02:45:54PM +0200, Thomas Monjalon wrote: > > 21/07/2020 17:39, Bruce Richardson: > > > When building the DPDK guide documents, the DPDK version information was > > > pulled using "make showversion", which meant there was a dependency on > > > the DPDK make-based build system. Change this to just read the data from > > > the VERSION file in the root directory. > > > > > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com> > > > --- > > > NOTE: When make build system is completed removed, we can change the > > > relative path to the VERSION file i.e. "../../", to instead pull the > > > path from "MESON_SOURCE_ROOT" in the environment, which should be more > > > robust. > > > > Yes it would be a bit better. > > If we merge this patch in 20.08, we'll forget about this improvement :) > > I suggest waiting 20.11 to merge the definitive improvement. > > > I'd prefer now, but I can be patient, I suppose. :-) Updated and improved version of this patch is now part of the "make removal" patch series. Marking this standalone patch as superceded. /Bruce