From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C87F9A04AF; Fri, 21 Aug 2020 11:24:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DD3E71C0B4; Fri, 21 Aug 2020 11:24:17 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id B5A891C0B0 for ; Fri, 21 Aug 2020 11:24:15 +0200 (CEST) IronPort-SDR: pL1yqQ7Ok4yxdduXr69vvD7d30QWiY4jrp4EeCfA54k/W7HkFhiKbQ6C0qwhvHBDItICfn0YJ1 O2bHTNh3vIhA== X-IronPort-AV: E=McAfee;i="6000,8403,9719"; a="143287981" X-IronPort-AV: E=Sophos;i="5.76,335,1592895600"; d="scan'208";a="143287981" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Aug 2020 02:24:14 -0700 IronPort-SDR: vaCNMLncrtb0EiG2i7/eEJGZAP+9tD6BLFRWC9O9++zPFpHRXq2HcmIzr702d+f183aVgHLija 7WZInTG8aENg== X-IronPort-AV: E=Sophos;i="5.76,335,1592895600"; d="scan'208";a="321200023" Received: from djhay-mobl2.ger.corp.intel.com (HELO bricha3-MOBL.ger.corp.intel.com) ([10.252.0.70]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 21 Aug 2020 02:24:13 -0700 Date: Fri, 21 Aug 2020 10:24:09 +0100 From: Bruce Richardson To: Louise Kilheeney Cc: dev@dpdk.org, robin.jarry@6wind.com, anatoly.burakov@intel.com, Olivier Matz Message-ID: <20200821092409.GA841@bricha3-MOBL.ger.corp.intel.com> References: <20200522132320.26373-1-louise.kilheeney@intel.com> <20200821091452.2482-1-louise.kilheeney@intel.com> <20200821091452.2482-6-louise.kilheeney@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200821091452.2482-6-louise.kilheeney@intel.com> Subject: Re: [dpdk-dev] [PATCH v5 5/9] app/test-cmdline: support python3 only X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Aug 21, 2020 at 10:14:48AM +0100, Louise Kilheeney wrote: > Changed script to explicitly use python3 only to avoid > maintaining python 2 and removed deprecation notice. > > Cc: Olivier Matz > > Signed-off-by: Louise Kilheeney > > --- > v5: fixed python3 issue casuing script to fail It would be good to add a little more detail of the failure and fix to help reviewers, I believe the fix is the typecast to int() around the division to avoid floating point numbers messing up the loop count. Reviewed-by: Bruce Richardson > --- > app/test-cmdline/cmdline_test.py | 9 ++------- > app/test-cmdline/cmdline_test_data.py | 1 + > mk/rte.sdktest.mk | 2 +- > 3 files changed, 4 insertions(+), 8 deletions(-) > > diff --git a/app/test-cmdline/cmdline_test.py b/app/test-cmdline/cmdline_test.py > index 954428e2bf..074fed7e7f 100755 > --- a/app/test-cmdline/cmdline_test.py > +++ b/app/test-cmdline/cmdline_test.py > @@ -1,9 +1,8 @@ > -#!/usr/bin/env python > +#!/usr/bin/env python3 > # SPDX-License-Identifier: BSD-3-Clause > # Copyright(c) 2010-2014 Intel Corporation > > # Script that runs cmdline_test app and feeds keystrokes into it. > -from __future__ import print_function > import cmdline_test_data > import os > import pexpect > @@ -19,10 +18,6 @@ def runTest(child, test): > return 0 > child.expect(test["Result"], 1) > > -if sys.version_info.major < 3: > - print("WARNING: Python 2 is deprecated for use in DPDK, and will not work in future releases.", file=sys.stderr) > - print("Please use Python 3 instead", file=sys.stderr) > - > # > # history test is a special case > # > @@ -43,7 +38,7 @@ def runHistoryTest(child): > i = 0 > > # fill the history with numbers > - while i < history_size / 10: > + while i < int(history_size / 10): > # add 1 to prevent from parsing as octals > child.send("1" + str(i).zfill(8) + cmdline_test_data.ENTER) > # the app will simply print out the number > diff --git a/app/test-cmdline/cmdline_test_data.py b/app/test-cmdline/cmdline_test_data.py > index 114d2cb6a0..2d9b3262a6 100644 > --- a/app/test-cmdline/cmdline_test_data.py > +++ b/app/test-cmdline/cmdline_test_data.py > @@ -1,3 +1,4 @@ > +#!/usr/bin/env python3 > # SPDX-License-Identifier: BSD-3-Clause > # Copyright(c) 2010-2014 Intel Corporation > > diff --git a/mk/rte.sdktest.mk b/mk/rte.sdktest.mk > index 803018ba3a..ad7ef138f0 100644 > --- a/mk/rte.sdktest.mk > +++ b/mk/rte.sdktest.mk > @@ -63,7 +63,7 @@ coverage: > @mkdir -p $(AUTOTEST_DIR) ; \ > cd $(AUTOTEST_DIR) ; \ > if [ -f $(RTE_OUTPUT)/app/test ]; then \ > - python $(RTE_SDK)/test/cmdline_test/cmdline_test.py \ > + python3 $(RTE_SDK)/test/cmdline_test/cmdline_test.py \ > $(RTE_OUTPUT)/app/cmdline_test; \ > ulimit -S -n 100 ; \ > python $(RTE_SDK)/app/test/autotest.py \ > -- > 2.17.1 >